From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76448C54E76 for ; Fri, 6 Jan 2023 17:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECAF28E0002; Fri, 6 Jan 2023 12:23:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7B3F8E0001; Fri, 6 Jan 2023 12:23:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42458E0002; Fri, 6 Jan 2023 12:23:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C21D88E0001 for ; Fri, 6 Jan 2023 12:23:50 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 836E1120E51 for ; Fri, 6 Jan 2023 17:23:50 +0000 (UTC) X-FDA: 80325046620.18.AD84ED4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 004F1140010 for ; Fri, 6 Jan 2023 17:23:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aADRfMLQ; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673025829; a=rsa-sha256; cv=none; b=2s8ReM4HyktL5R9cU8N24B5dmRg+mlZkwr3IOBueXUly9Xh+WVAfyhvAsisO4e7s3RE4L9 /NIODIdMcccrpUZM7eAsd/Hul9QNTBxhr4/cmqfwrZ597s91JwotBbb3TN+5yxpza1Acbc YuDQW02J4XG0LqJdpr5tBrCucl8irdQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aADRfMLQ; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673025829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3x1ChIU8b+v0wuj181ep4fqO8ApTtfDqjntuZWOTc8U=; b=dPiK1/b/T6A67LGB9J3mBVNhn8YdEFTWzBFeiicbakF21HTlHu8YnrH7LUmCIkYd14fyu+ J5dEdUf0+1nJzKwKZZPeBkDFEuboMfGi7/iZOk2XsEaQux8ln1lZO3TS2tet2pMQOja2mI Cui181p/jjcozaYAitS8M/Qom6Opnrw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0767061ED9; Fri, 6 Jan 2023 17:23:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03D60C433D2; Fri, 6 Jan 2023 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673025827; bh=AwyUBMt2K+2WekTeSn6jMv9BpnWBDC8Aaa/wrQ3tyK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aADRfMLQVEdU+XpDI4eDbnxHsiw+h9BZU9DKWnob3lhB8dRHQfQxlHP0RNw49yl6S tdhvKJvtT5NoSqUSbjFFY9TeFLb341BM2pEZliR9H+WzbSZ3E1mbBILjKDXWB0lKCg vsUY9K1my06hUR70qsABNLlv7/3h4duZyhRtMA1srXjh8V+kRMSG0W9vtNt6et3Zd/ RI2aQdsLz5/acP8vXACyB3Xw1q5dDE3NhGwLULXRPUEdE69GcGa5Rq5h+N2tJdilYj ujDsq7W3fMj2OypO+qk6aYrNjZaUCnGzJ8Foz3wWlPxPH69gZHsTJFrrLWvt3yh9fk abuwGEO6FiZrA== From: SeongJae Park To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v2 25/44] mm: Switch vma_merge(), split_vma(), and __split_vma to vma iterator Date: Fri, 6 Jan 2023 17:23:45 +0000 Message-Id: <20230106172345.149991-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230105191517.3099082-26-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 004F1140010 X-Rspamd-Server: rspam01 X-Stat-Signature: pehkp9rcodbni6pkuxf71h7pdb8iieai X-HE-Tag: 1673025828-295478 X-HE-Meta: U2FsdGVkX19/PkYDeevajNyEs3athqhDJZEJ1b+2SnRmpCP+pmWZC4x6OG2rZ292CKZu8yEPDPvxoojXcXHKfHGGX8Q2jTuJdIXzvvD5tshnMWcmpsR2qoHDEN1uAVWjwuRmzNsl5d8o9emMHEhuR35DjnSQyH0LIz++6YPCAu5roPnO+CZycUdSHqmI1JWwaRAXYQULF1MmwEoyBGsvslO06/kXfQz9KsRJ4vvNb6ULTciLljVeccIJllLEhzUym4F0jsvRmD5l1PcI2tx4vWEB2FTuql/SsF/wkBCApk60T743sHFP4HsoGbimBgI4EFUR0R68pBzrI2aQjLv5UvYDvv1lXSAjm/N2bmSsNPOSdXf0EBSH1mxCzKByhSROx35et7hDhpzOut1VX4AfBkOPZOgw0XxOw6iz0UrXN5t1+wwIsyF7Nq7Nfi7RqWAOX/DIh4fAzetIkTZp7P8IRgAGqcoPjZRCxn1OaHoX3OJ9DQzCA1Wk//jFd1RKKoC3LNX+qA/TpKmGIGv/aaf95HTCgAxKvKswfS0bb+5GMEBgdE6O67P+xZmkziUseGmkg+saqCAlvaidWkWxsEH1UgZO7K0JkzBvolRplgPuQmp1/vzFBafJ6OIP5qOeioDVZ/GMumpOW1uF+NWa6UyUiL4watbb2CZp2mlK01h3dG57dEW1EbV3Q4vbxg+KI/PUFrAebWwTubipu34WUtTrWvQj+bnPLLyc9zNg4HwBGV8ltSv449mImL032J8+aFZVmN4cu8LmQbvyoi9pcPX3CMC6PR3GuztTzQGtKQXBC/9HNC66G2wN5R+56dOB3W1VAESuaJiYSKDrQ11AobhjL9enVQ0BmjUBXtG8DLK4j91WaChgJ5iRwUcOX+asSZnzX2bdSjHLOyUnG73AgrMl/UpzX48A25DL8ILmQWsFfkkDGLE99CM5Bq1oBw9UybQxA2M1rzm3obkHLEZ2nH+ WedvisEG PnuZpJRomhG6qTzDsTpnJstz/rDmVeo/OXn6Czoj8T4iatIn44U9Vyiu3K/1/wfJ6csblmUmtaVMXR4Ufv6tfx04YiU1YdFFXMcBHiIdkBsoN/Cgdwo6CRjhX50OPxb1zazbz3EM3RM4DsyzHnE9WzHPD5s1kEJ9ly2Ga X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam, On Thu, 5 Jan 2023 19:15:59 +0000 Liam Howlett wrote: > From: "Liam R. Howlett" > > Drop the vmi_* functions and transition all users to use the vma > iterator directly. > > Signed-off-by: Liam R. Howlett > --- > fs/userfaultfd.c | 14 ++++---- > include/linux/mm.h | 16 +++------- > mm/madvise.c | 6 ++-- > mm/mempolicy.c | 6 ++-- > mm/mlock.c | 6 ++-- > mm/mmap.c | 79 +++++++++++++--------------------------------- > mm/mprotect.c | 6 ++-- > mm/mremap.c | 2 +- > 8 files changed, 47 insertions(+), 88 deletions(-) [...] > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2830,22 +2830,16 @@ static inline int vma_adjust(struct vm_area_struct *vma, unsigned long start, [...] > -extern int vmi__split_vma(struct vma_iterator *vmi, struct mm_struct *, > - struct vm_area_struct *, unsigned long addr, int new_below); > -extern int split_vma(struct mm_struct *, struct vm_area_struct *, > - unsigned long addr, int new_below); > -extern int vmi_split_vma(struct vma_iterator *vmi, struct mm_struct *, > - struct vm_area_struct *, unsigned long addr, int new_below); > +extern int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *, > + unsigned long addr, int new_below); > +extern int split_vma(struct vma_iterator *vmi, struct vm_area_struct *, > + unsigned long addr, int new_below); I just found this change for split_vma() is applied to !CONFIG_MMU, which the definition of split_vma() is not changed, so cause a build error. I posted a simple fix for that: https://lore.kernel.org/linux-mm/20230106171857.149918-1-sj@kernel.org/ Thanks, SJ [...]