Hi James, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20230105] [cannot apply to kvm/queue shuah-kselftest/next shuah-kselftest/fixes arnd-asm-generic/master linus/master kvm/linux-next v6.2-rc2 v6.2-rc1 v6.1 v6.2-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428 patch link: https://lore.kernel.org/r/20230105101844.1893104-14-jthoughton%40google.com patch subject: [PATCH 13/46] hugetlb: add hugetlb_hgm_walk and hugetlb_walk_step config: powerpc-randconfig-r005-20230105 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 8d9828ef5aa9688500657d36cd2aefbe12bbd162) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/5395f068d45f39d202240799d3a8146226387f5c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428 git checkout 5395f068d45f39d202240799d3a8146226387f5c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash fs/proc/ mm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from mm/filemap.c:36: >> include/linux/hugetlb.h:1275:34: error: incomplete result type 'enum hugetlb_level' in function definition static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ >> include/linux/hugetlb.h:1277:9: error: use of undeclared identifier 'HUGETLB_LEVEL_PTE' return HUGETLB_LEVEL_PTE; ^ include/linux/hugetlb.h:1306:40: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1308:13: error: incomplete definition of type 'struct hugetlb_pte' return hpte->ptl; ~~~~^ include/linux/hugetlb.h:1306:40: note: forward declaration of 'struct hugetlb_pte' spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1312:37: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1314:40: error: incompatible pointer types passing 'struct hugetlb_pte *' to parameter of type 'struct hugetlb_pte *' [-Werror,-Wincompatible-pointer-types] spinlock_t *ptl = hugetlb_pte_lockptr(hpte); ^~~~ include/linux/hugetlb.h:1306:53: note: passing argument to parameter 'hpte' here spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1321:56: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ include/linux/hugetlb.h:1323:25: error: variable has incomplete type 'enum hugetlb_level' enum hugetlb_level level) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1325:2: error: call to undeclared function '__hugetlb_pte_populate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] __hugetlb_pte_populate(hpte, ptep, shift, level, ^ include/linux/hugetlb.h:1325:2: note: did you mean 'hugetlb_pte_populate'? include/linux/hugetlb.h:1321:6: note: 'hugetlb_pte_populate' declared here void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ 3 warnings and 6 errors generated. -- In file included from mm/shmem.c:38: >> include/linux/hugetlb.h:1275:34: error: incomplete result type 'enum hugetlb_level' in function definition static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ >> include/linux/hugetlb.h:1277:9: error: use of undeclared identifier 'HUGETLB_LEVEL_PTE' return HUGETLB_LEVEL_PTE; ^ include/linux/hugetlb.h:1306:40: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1308:13: error: incomplete definition of type 'struct hugetlb_pte' return hpte->ptl; ~~~~^ include/linux/hugetlb.h:1306:40: note: forward declaration of 'struct hugetlb_pte' spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1312:37: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1314:40: error: incompatible pointer types passing 'struct hugetlb_pte *' to parameter of type 'struct hugetlb_pte *' [-Werror,-Wincompatible-pointer-types] spinlock_t *ptl = hugetlb_pte_lockptr(hpte); ^~~~ include/linux/hugetlb.h:1306:53: note: passing argument to parameter 'hpte' here spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1321:56: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ include/linux/hugetlb.h:1323:25: error: variable has incomplete type 'enum hugetlb_level' enum hugetlb_level level) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1325:2: error: call to undeclared function '__hugetlb_pte_populate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] __hugetlb_pte_populate(hpte, ptep, shift, level, ^ include/linux/hugetlb.h:1325:2: note: did you mean 'hugetlb_pte_populate'? include/linux/hugetlb.h:1321:6: note: 'hugetlb_pte_populate' declared here void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ In file included from mm/shmem.c:57: include/linux/mman.h:153:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ include/linux/mman.h:154:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ 5 warnings and 6 errors generated. -- In file included from fs/proc/meminfo.c:6: >> include/linux/hugetlb.h:1275:34: error: incomplete result type 'enum hugetlb_level' in function definition static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ >> include/linux/hugetlb.h:1277:9: error: use of undeclared identifier 'HUGETLB_LEVEL_PTE' return HUGETLB_LEVEL_PTE; ^ include/linux/hugetlb.h:1306:40: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1308:13: error: incomplete definition of type 'struct hugetlb_pte' return hpte->ptl; ~~~~^ include/linux/hugetlb.h:1306:40: note: forward declaration of 'struct hugetlb_pte' spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1312:37: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1314:40: error: incompatible pointer types passing 'struct hugetlb_pte *' to parameter of type 'struct hugetlb_pte *' [-Werror,-Wincompatible-pointer-types] spinlock_t *ptl = hugetlb_pte_lockptr(hpte); ^~~~ include/linux/hugetlb.h:1306:53: note: passing argument to parameter 'hpte' here spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) ^ include/linux/hugetlb.h:1321:56: warning: declaration of 'struct hugetlb_pte' will not be visible outside of this function [-Wvisibility] void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ include/linux/hugetlb.h:1323:25: error: variable has incomplete type 'enum hugetlb_level' enum hugetlb_level level) ^ include/linux/hugetlb.h:1275:20: note: forward declaration of 'enum hugetlb_level' static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) ^ include/linux/hugetlb.h:1325:2: error: call to undeclared function '__hugetlb_pte_populate'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] __hugetlb_pte_populate(hpte, ptep, shift, level, ^ include/linux/hugetlb.h:1325:2: note: did you mean 'hugetlb_pte_populate'? include/linux/hugetlb.h:1321:6: note: 'hugetlb_pte_populate' declared here void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, ^ In file included from fs/proc/meminfo.c:7: include/linux/mman.h:153:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ include/linux/mman.h:154:9: warning: division by zero is undefined [-Wdivision-by-zero] _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/mman.h:132:21: note: expanded from macro '_calc_vm_trans' : ((x) & (bit1)) / ((bit1) / (bit2)))) ^ ~~~~~~~~~~~~~~~~~ fs/proc/meminfo.c:22:28: warning: no previous prototype for function 'arch_report_meminfo' [-Wmissing-prototypes] void __attribute__((weak)) arch_report_meminfo(struct seq_file *m) ^ fs/proc/meminfo.c:22:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __attribute__((weak)) arch_report_meminfo(struct seq_file *m) ^ static 6 warnings and 6 errors generated. vim +1275 include/linux/hugetlb.h 1274 > 1275 static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) 1276 { > 1277 return HUGETLB_LEVEL_PTE; 1278 } 1279 #endif /* CONFIG_HUGETLB_PAGE */ 1280 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests