Hi James, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20230105] [cannot apply to kvm/queue shuah-kselftest/next shuah-kselftest/fixes arnd-asm-generic/master linus/master kvm/linux-next v6.2-rc2 v6.2-rc1 v6.1 v6.2-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428 patch link: https://lore.kernel.org/r/20230105101844.1893104-14-jthoughton%40google.com patch subject: [PATCH 13/46] hugetlb: add hugetlb_hgm_walk and hugetlb_walk_step config: m68k-allmodconfig compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/5395f068d45f39d202240799d3a8146226387f5c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review James-Houghton/hugetlb-don-t-set-PageUptodate-for-UFFDIO_CONTINUE/20230105-182428 git checkout 5395f068d45f39d202240799d3a8146226387f5c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/proc/ mm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/migrate.h:8, from mm/zsmalloc.c:60: >> include/linux/hugetlb.h:1275:34: error: return type is an incomplete type 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hpage_size_to_level': >> include/linux/hugetlb.h:1277:16: error: 'HUGETLB_LEVEL_PTE' undeclared (first use in this function) 1277 | return HUGETLB_LEVEL_PTE; | ^~~~~~~~~~~~~~~~~ include/linux/hugetlb.h:1277:16: note: each undeclared identifier is reported only once for each function it appears in include/linux/hugetlb.h:1277:16: error: 'return' with a value, in function returning void [-Werror=return-type] include/linux/hugetlb.h:1275:34: note: declared here 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1306:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr': include/linux/hugetlb.h:1308:20: error: invalid use of undefined type 'struct hugetlb_pte' 1308 | return hpte->ptl; | ^~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1312:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1312 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lock': include/linux/hugetlb.h:1314:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types] 1314 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte); | ^~~~ | | | struct hugetlb_pte * include/linux/hugetlb.h:1306:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *' 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ~~~~~~~~~~~~~~~~~~~~^~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1321:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~ include/linux/hugetlb.h:1323:46: error: parameter 5 ('level') has incomplete type 1323 | enum hugetlb_level level) | ~~~~~~~~~~~~~~~~~~~^~~~~ include/linux/hugetlb.h:1321:6: error: function declaration isn't a prototype [-Werror=strict-prototypes] 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_populate': include/linux/hugetlb.h:1325:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration] 1325 | __hugetlb_pte_populate(hpte, ptep, shift, level, | ^~~~~~~~~~~~~~~~~~~~~~ | hugetlb_pte_populate cc1: some warnings being treated as errors -- In file included from mm/madvise.c:16: >> include/linux/hugetlb.h:1275:34: error: return type is an incomplete type 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hpage_size_to_level': >> include/linux/hugetlb.h:1277:16: error: 'HUGETLB_LEVEL_PTE' undeclared (first use in this function) 1277 | return HUGETLB_LEVEL_PTE; | ^~~~~~~~~~~~~~~~~ include/linux/hugetlb.h:1277:16: note: each undeclared identifier is reported only once for each function it appears in include/linux/hugetlb.h:1277:16: error: 'return' with a value, in function returning void [-Werror=return-type] include/linux/hugetlb.h:1275:34: note: declared here 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1306:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr': include/linux/hugetlb.h:1308:20: error: invalid use of undefined type 'struct hugetlb_pte' 1308 | return hpte->ptl; | ^~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1312:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1312 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lock': include/linux/hugetlb.h:1314:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types] 1314 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte); | ^~~~ | | | struct hugetlb_pte * include/linux/hugetlb.h:1306:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *' 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ~~~~~~~~~~~~~~~~~~~~^~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1321:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~ include/linux/hugetlb.h:1323:46: error: parameter 5 ('level') has incomplete type 1323 | enum hugetlb_level level) | ~~~~~~~~~~~~~~~~~~~^~~~~ include/linux/hugetlb.h:1321:6: error: function declaration isn't a prototype [-Werror=strict-prototypes] 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_populate': include/linux/hugetlb.h:1325:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration] 1325 | __hugetlb_pte_populate(hpte, ptep, shift, level, | ^~~~~~~~~~~~~~~~~~~~~~ | hugetlb_pte_populate mm/madvise.c: In function 'madvise_split': mm/madvise.c:1023:9: error: implicit declaration of function 'hugetlb_vma_lock_alloc'; did you mean 'hugetlb_vma_lock_write'? [-Werror=implicit-function-declaration] 1023 | hugetlb_vma_lock_alloc(vma); | ^~~~~~~~~~~~~~~~~~~~~~ | hugetlb_vma_lock_write cc1: some warnings being treated as errors -- In file included from fs/proc/meminfo.c:6: >> include/linux/hugetlb.h:1275:34: error: return type is an incomplete type 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hpage_size_to_level': >> include/linux/hugetlb.h:1277:16: error: 'HUGETLB_LEVEL_PTE' undeclared (first use in this function) 1277 | return HUGETLB_LEVEL_PTE; | ^~~~~~~~~~~~~~~~~ include/linux/hugetlb.h:1277:16: note: each undeclared identifier is reported only once for each function it appears in include/linux/hugetlb.h:1277:16: error: 'return' with a value, in function returning void [-Werror=return-type] include/linux/hugetlb.h:1275:34: note: declared here 1275 | static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) | ^~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1306:40: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lockptr': include/linux/hugetlb.h:1308:20: error: invalid use of undefined type 'struct hugetlb_pte' 1308 | return hpte->ptl; | ^~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1312:37: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1312 | spinlock_t *hugetlb_pte_lock(struct hugetlb_pte *hpte) | ^~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_lock': include/linux/hugetlb.h:1314:47: error: passing argument 1 of 'hugetlb_pte_lockptr' from incompatible pointer type [-Werror=incompatible-pointer-types] 1314 | spinlock_t *ptl = hugetlb_pte_lockptr(hpte); | ^~~~ | | | struct hugetlb_pte * include/linux/hugetlb.h:1306:53: note: expected 'struct hugetlb_pte *' but argument is of type 'struct hugetlb_pte *' 1306 | spinlock_t *hugetlb_pte_lockptr(struct hugetlb_pte *hpte) | ~~~~~~~~~~~~~~~~~~~~^~~~ include/linux/hugetlb.h: At top level: include/linux/hugetlb.h:1321:56: warning: 'struct hugetlb_pte' declared inside parameter list will not be visible outside of this definition or declaration 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~ include/linux/hugetlb.h:1323:46: error: parameter 5 ('level') has incomplete type 1323 | enum hugetlb_level level) | ~~~~~~~~~~~~~~~~~~~^~~~~ include/linux/hugetlb.h:1321:6: error: function declaration isn't a prototype [-Werror=strict-prototypes] 1321 | void hugetlb_pte_populate(struct mm_struct *mm, struct hugetlb_pte *hpte, | ^~~~~~~~~~~~~~~~~~~~ include/linux/hugetlb.h: In function 'hugetlb_pte_populate': include/linux/hugetlb.h:1325:9: error: implicit declaration of function '__hugetlb_pte_populate'; did you mean 'hugetlb_pte_populate'? [-Werror=implicit-function-declaration] 1325 | __hugetlb_pte_populate(hpte, ptep, shift, level, | ^~~~~~~~~~~~~~~~~~~~~~ | hugetlb_pte_populate fs/proc/meminfo.c: At top level: fs/proc/meminfo.c:22:28: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] 22 | void __attribute__((weak)) arch_report_meminfo(struct seq_file *m) | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +1275 include/linux/hugetlb.h 1274 > 1275 static inline enum hugetlb_level hpage_size_to_level(unsigned long sz) 1276 { > 1277 return HUGETLB_LEVEL_PTE; 1278 } 1279 #endif /* CONFIG_HUGETLB_PAGE */ 1280 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests