From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F9ACC3DA7A for ; Thu, 5 Jan 2023 19:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92A1B8E0008; Thu, 5 Jan 2023 14:32:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2948E0006; Thu, 5 Jan 2023 14:32:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72C6C8E0008; Thu, 5 Jan 2023 14:32:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CDB08E0006 for ; Thu, 5 Jan 2023 14:32:57 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3B8DA1A044D for ; Thu, 5 Jan 2023 19:32:57 +0000 (UTC) X-FDA: 80321743194.18.9509351 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id A6C8C80015 for ; Thu, 5 Jan 2023 19:32:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uTr2lhO6; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672947175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IELmxBW8z1fPFBQY3SLF+cywNZemPcxDQ9U0ufWixU=; b=8pS38Sp3M4CKITmzEr0cL9Y3MtlphbQa7UU5F0PJUwj8/wU0QDYfFQ4M31QbTrI6tR41jb 93qQvYchv2sirto29MBK+D2d5af11+zEXs0TzVQeaWyxRrtF9xOmEKX7rsEaLgXUXCrpOl I/7/wBVihjKGO8fuhpDPruQZPrL4XcI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uTr2lhO6; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672947175; a=rsa-sha256; cv=none; b=6yMTA7VkR7EUlz91QhvnkqQhvqA2aXZKvqT9RuwdKqpV1PFIkG5MO4ONSZ2L53bl3nEWEk B2xFE4/y4F2VjU16hV9fOKhsybafNGKuiw5728XgYWIGNpfsKZcGFnCMfZHkumeFYXq3+B 9l8kJJUxGs1bJMhSj/kcRu6k/JTH6rk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9BB4D61C12; Thu, 5 Jan 2023 19:32:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66086C433D2; Thu, 5 Jan 2023 19:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672947174; bh=EgMjUg/SgTSer8lGkKyb8lKAMLgl0roZnntm9yvxsKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uTr2lhO69gTJMzuNEnGSg2lCfR3saYLkD3ZXYywixKzKKRqxBA01HT6pfqzGl6boF MpYs/Y7ZL7ZJt7BVf/TQIyjEgQ6+7RLdNVloWea7+Rea6KWPyvpCsx0XcnRXa0V+qb 9zQOqHPo6kMxmtyTulPk80tTV8yrdoM9hTmF1CemwIIkyMkdDvqRaQ2bTRignR+273 PvAMOfMWbE5Z2XTwP5X3OpqapXhbLNHWMParTyoS4hRsCrGklqClaPzZ7VQlE5Rkdr CuaQ5bqWL9aWdPB3+YSzHO49GmL17c07RHbEkc/QJ1+QYu8hBrnQgvsETOCnxCY2uG avrzTiCBGx6qg== From: SeongJae Park To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , SeongJae Park , "damon@lists.linux.dev" , kernel test robot Subject: Re: [PATCH v2 26/44] mm/damon: Stop using vma_mas_store() for maple tree store Date: Thu, 5 Jan 2023 19:32:51 +0000 Message-Id: <20230105193251.112393-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230105191517.3099082-27-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 6oicbmx8do81tkrh7w7dcjdnpen1c8cd X-Rspam-User: X-Rspamd-Queue-Id: A6C8C80015 X-Rspamd-Server: rspam06 X-HE-Tag: 1672947175-718544 X-HE-Meta: U2FsdGVkX1+2a189w5jqsishux2auTlIAkU0KDZ9bhyW90QxgAc+4muqyqjAT5JFzIdY5IeqWTS78QQRqKrOuFXNezYgxy/uRiJQgkdZSrUm3byIBz0kuTtg56q9cwAo475cpFWo432Ct9qdLlNBOk/iFlpPQfTHWarYns6JJp96DppTBsHUH1RhlrBknvvBexCKFVxJhPgv+5jUvU0OeGna601un+vU4wjm8EKQDMhEGhBsKlQpDMPzIO4iGfL6h+VnH56BcM+l0b3SHlttnAsbUGvnYAFGRh7NLTxNGY1RDmFXKC5J+OjE4W1u2dqU5nflE1skx3LNryXGJNrent+Z+T7jumgFrKLtcrcxYTFYR8mYWpKKlRN2O6iKWbRhNYynkH4T+hC4fOHjBraIvxo0y/5IkIBDiDy985YMymdT9nsUdvpCBN9EQp5hTSOVuKEh3hJeUFMscwjjk5O9lewXTloSix7+ApaAQfjj8jgaxAE87F7JYGUFUeuFr/avOq8tGTII7pyguhSZFp70AZ0cpcR/Zz3vvNOFa3UBecQ5QNKbQPy64YITXRmWEp68xaNuWwvQCBDK9CIjIdhMMlm2AoYU9yJooDjOtif6TDi2VGZQJYtm0CsW1EWFnhcTNxrrcjll0sPZ61TDizw0sNLVzHhD2ubeH5mRGZTk/EVLDUyO6EU1bucPi/73xHa307sIe4C/G6qJHORBFBidAGnW8HzaW1bSZqnSiHhj0n3mnjgxotslljlbr1u0oIC6Be9vk+bU0TJDrN6uXT+c3+PMdLSSTxjQhgxvlgvw+tt+/17ZBv83Ww7DMWxVZGTIX8qlpQnnegQoJHvTNxW3xOutkKBBXbW0/ee1kTFpYn087ssKXIT5V0JmHAAaqHc5BaVKLim0mBGiQdc09b4jdb6kNGc2DXmHZpksgtPccjVXgyrNHTPimaCAvGjGz/Zsjo+LhFz+j81DmRMhZpS MeUdVzjN ZahOEvwlZtSvTSkv5DRdVK9L0npHP3X0FS1oe394rF7nVMfz9JeZlOVhOen4LzL6E8KDCS6jf91yYadOgNhdudnPg5GHiMjvWH0zipqL4j+a8whJoXwAONxyZAqCUxrY9zhkjTyFA5YcNu//QBfipf+VZTz5vQSTj9x/j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liam, On Thu, 5 Jan 2023 19:16:00 +0000 Liam Howlett wrote: > From: "Liam R. Howlett" > > Prepare for the removal of the vma_mas_store() function by open coding > the maple tree store in this test code. But seems this series is not really removing 'vma_mas_store()'. Wouldn't it better to do the preparation and removal together in a same patch series? > Set the range of the maple > state and call the store function directly. > > Cc: SeongJae Park > Cc: damon@lists.linux.dev > Reported-by: kernel test robot > Signed-off-by: Liam R. Howlett > --- > mm/damon/vaddr-test.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h > index bce37c487540..41532f7355d0 100644 > --- a/mm/damon/vaddr-test.h > +++ b/mm/damon/vaddr-test.h > @@ -24,8 +24,10 @@ static void __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > return; > > mas_lock(&mas); > - for (i = 0; i < nr_vmas; i++) > - vma_mas_store(&vmas[i], &mas); > + for (i = 0; i < nr_vmas; i++) { > + mas_set_range(&mas, vmas[i].vm_start, vmas[i].vm_end - 1); > + mas_store_gfp(&mas, &vmas[i], GFP_KERNEL); > + } On the latest mm-unstable, vma_mas_store() uses mas_store_prealloc() instead of mas_store_gfp(). Seems the difference would make no problem to this test code in most cases, but could I ask the reason for this change? Also, should we check the return value of mas_store_gfp()? > mas_unlock(&mas); > } > > -- > 2.35.1 Thanks, SJ