From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F054BC3DA7D for ; Thu, 5 Jan 2023 16:54:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 707A18E0002; Thu, 5 Jan 2023 11:54:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B6398E0001; Thu, 5 Jan 2023 11:54:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A53C8E0002; Thu, 5 Jan 2023 11:54:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4C80A8E0001 for ; Thu, 5 Jan 2023 11:54:30 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 160AFC018E for ; Thu, 5 Jan 2023 16:54:30 +0000 (UTC) X-FDA: 80321343900.04.60750D7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4DA071C0007 for ; Thu, 5 Jan 2023 16:54:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ueRSNc0H; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672937667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWRj6/eWh/7U/GGUYegeNVXzOfbnPlvbA0oY0KoEBNo=; b=Iu6SqZnnEWHpCY6kFNh6nf95aBzCLKMegOMghsNz+1t7W536wYnduaZU2/9jLFoGcrzAXs GZCWDoahssC1BADHnzVxeHs1oQaaErFS/oa9MATrUy/QknJnEsUWqFeTgg/1TrUZWFUzVI iTiVBartLsJZM5mdP8CDX+AYp1Ka9Ec= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ueRSNc0H; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672937667; a=rsa-sha256; cv=none; b=kAC1qO/XNqjjUwEYsACye2Sl2Byy9rnzVnjKBepxbckXHQNj8rUpy0SoVthwmAG2+mQDPK ds3Sf+RIPr8nTmhJH+6Jce+SS5/1nMq1sWCfGQllwKNg+8qweGlid/kd67Q2Oo4AHtVnLs XUX6cV2zy5kKwE8bf/1RXlQuJSnNQcw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4526761B8D; Thu, 5 Jan 2023 16:54:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E97B1C433D2; Thu, 5 Jan 2023 16:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672937665; bh=n2kMHDliaAZWCMeqSunat1mUVNB+pE0uEb3Yf7pq5UY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ueRSNc0HAV9M3m/AOphjY+CVwANJuketclXLKQ7wfqTHXQ20tcNRf8N6PmgoPqizq 49G6ZE2C9QbaVTz/ZqxxGBI+wRh4Z9MVPGo4gw56dkEALok/7RWrRYca3R3pjZWZBV HNKI8Yvzr9wfiIfX2KN5xIHyslq9uvfG7zqTX9lCeo9+VE2Zvt9vHllCOVIATkpV2I Bi9tnwyg6ygv9rntn6HbDB1pbzuxRxZFC3I6fyKJezZa1SitXvJC/unlyMGdaXa6Ba OyV4TVir3bQNyv/oayJN3rCQ9x9CoyUfXMiuIQ1ElElyqM6quNL7RNKTvnlj1TxwYY QvTZBoPLcRYEg== From: SeongJae Park To: Greg Kroah-Hartman Cc: SeongJae Park , kernel test robot , devel@driverdev.osuosl.org, damon@lists.linux.dev, linux-mm@kvack.org, oe-lkp@lists.linux.dev, Andrew Morton , stable Subject: Re: [driver-core:debugfs_lookup_fix] [mm/damon/dbgfs] ff25f87cfc: kernel_BUG_at_lib/list_debug.c Date: Thu, 5 Jan 2023 16:54:23 +0000 Message-Id: <20230105165423.3221-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4DA071C0007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: q4917bn8hzqwi6s8idce7n97bz8mutr1 X-HE-Tag: 1672937667-237497 X-HE-Meta: U2FsdGVkX19VZQ2oK3vCTan6iRZLpnSUsI4O+QjXAO/kWNLHoz0C5MpHFAMsB5cYRLonMuupzrog3x0lt+qlkzYpqsOEGOL8XHI8JpHTDjuiFJD/i5lRMkrZ44Awg2W1Ave1tbMKF8iKzQQ1jBf1jX/4DvHkuBmowV+cnQOVVT1TBTIz2AmJZvHBdn9jJsafxeGadqbxN71WIsx1mY5/FzI0OmQGdLgF7LSdgM86Knd6XKOGAf1AFIGRAjNDG1Y1gm2LdG8xLRSTXQiAE72ocUoAL54yrecRy82hAfrw7VmI9wLbLHizl3q02Z5jrREkHkGUZJbyqplsyBxGw4wNEoxT6U3Oli/DWb7SLqYpnlcjwTj/2PKasa3XoudWlZE2cmrchn2FyLXsGZG/3O9r2I6UMzVM2bHmDCNuOfhymup9D/uqQt72XC5KEIFzy4auPvvLq6uTDbAa9negcg8m/MEZ3Tf8zEpLPiz/aRGMPfXBhC/rHDbI2lUMRK+pFClVfaqlnVnJYC0ynlwCdYxS8MY4mLBDZfetqmGLSGME/6OZoPuX3/XLFXUmbLqwSjQErT/5YPJ8ssBvMX/RyjEUkE8pGmVgP7r7jY/DcNq2yt4bWRQZ8pE3CrQDEtE0QN2H+WaqzGR5aZtJa32q70v7ibn6+AEKgvq3VsKNQ6gLGrcFgzYeziLekzZy7/hbsYpyFKrxwOuZYlxSFpS5QjfI3XTHwVIvIHO5x/kzBf/SKzcn9L8iIBzS0nnuQmIdl3vUR4pMu/YS4ewCUvjECnHjuLpixnjKVCA1Xl8n3Ywv3fUqlVFXBLQr43CgyG4TgkAlZIc5MN+NnwYg+EUSHtj6xZnDQXgnEYfJC97U3xVBtc7jSShbcfivij1HzIQP3s/gFocypMtstMCkYKSyxRVELuHVtZhsBZ1FLElXWJWgQru9i0mKTAf2Y7bgMl+c6YyUt6X61sFkVuRKiZtT0W8 cSrYVN2l 6oQT+v1cVoX493/HGGdZwewjkmvbZqdu34kSyZibRmbsK4st4Fri+WjZDeSORvcgDmQGTZx3+tnsxVMY7fYUVndAK8eGPc35XfL7LIFfZGp58AIVpmOTXeinxhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 Jan 2023 10:53:57 +0100 Greg Kroah-Hartman wrote: > On Wed, Jan 04, 2023 at 06:35:39PM +0000, SeongJae Park wrote: > > Hello, > > > > On Tue, 3 Jan 2023 21:16:09 +0800 kernel test robot wrote: > > > > > [-- Attachment #1: Type: text/plain, Size: 7528 bytes --] > > > > > > > > > Greeting, > > > > > > FYI, we noticed kernel_BUG_at_lib/list_debug.c due to commit (built with gcc-11): > > > > Thank you for the report! > > > > > > > > commit: ff25f87cfcfc34ebe652987f2a7beb184762785b ("mm/damon/dbgfs: fix memory leak when using debugfs_lookup()") > > > https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git debugfs_lookup_fix > > > > The commit is for fixing a memory leak due to missed dput() call. The patch > > has posted originally by Greg and revised my I[1]. The revised version has > > merged in mainline during v6.0 stabilization period (1552fd3ef7db). > > > > The problematic tree (driver-core/debugfs_lookup_fix) is based on v6.2-rc2, so > > the revised patch is already applied. But the first version of the patch is > > applied again on the tree[2], probably by mistake, and caused double 'dput()'. > > > > So I think the commit seems needs to be reverted. > > > > If there is anything I missed or wrong, please let me know. > > > > [1] https://lore.kernel.org/damon/20220902191149.112434-1-sj@kernel.org/ > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=debugfs_lookup_fix&id=5167d3e8149e332204274910da1057e8f907d7d2 > > Yeah, this is my fault, sorry. That branch/tree has not been looked at > carefully in a while, I need to refresh it properly and verify it all is > correct. I'll drop this change as part of that work as well, sorry for > the noise. No problem, I'm glad to help! :) Thanks, SJ > > greg k-h >