From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3042C5479D for ; Thu, 5 Jan 2023 03:41:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 404378E0002; Wed, 4 Jan 2023 22:41:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B4798E0001; Wed, 4 Jan 2023 22:41:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C708E0002; Wed, 4 Jan 2023 22:41:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 190718E0001 for ; Wed, 4 Jan 2023 22:41:30 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E2065A0ADD for ; Thu, 5 Jan 2023 03:41:29 +0000 (UTC) X-FDA: 80319345498.14.77F1C7F Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf27.hostedemail.com (Postfix) with ESMTP id AD6444000D for ; Thu, 5 Jan 2023 03:41:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5GSO3Gz; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672890087; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mXROzE0n8NEHkDXHpiTgxX9spWPmw5TrxUlMtHTlV/M=; b=ruWnHbyzAD4htohiCXiyGERqps1UNBBaju8ygRL7HZokJqhUpcJAyUaopLGUDG6BHYzM7K ZW3DURpgk8BQ4P6ftpUycvybfhjrJjxEMSRycFvt5IiChzCg3la4tvlAGsbdkQwljumuBI +r8e8phHzR0zUgJjVSKRVHltsg9T/O4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5GSO3Gz; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672890087; a=rsa-sha256; cv=none; b=SVt+aZW5RpraH/7OOXWGpxxNWrPVqD7Y72GEpOwrfJiiq4W5myR4VlMC2hUXmiJODTaPTI C8svgqFu8KR3sQP45ZWweRN7RzsD6NN12aZ17zxjRL2mcfOiQJKRoGvGNBeSQQRbnV9JYD PSwU26u4N+81muV8REVKq00kQLZBZW4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672890087; x=1704426087; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:content-transfer-encoding:in-reply-to; bh=jhdOYu/i/WR/3sag1mrvD/fdCUONvVid9L0DwaMBfmI=; b=W5GSO3GzA7z+JiZcFtvSo2SoGfPc3qwHzFTj0XF+Wjf2Wuk23s7AAwX6 VSpyCl+fZ74R3lvtgiJ7Wqb+ehZMhtjt+nf+9JZoM0cxgp3rSc3v14qyh QDXQx4YUj0ihOmTPOPi0uAAW4VsmGiuMtbajBXSBp2Sct0XqK+OFww6yv bo6eoo5lzezLsSWKCZJbv3lhQCWss/gqxQFnmZtF11MkxQopPgg466nli uVIe/cG1XmGu8WW08wsSfjuPF5v/6gb1pheVFX1/VwENoaN9kIyvbB3R2 NsW1QlHVgKe3am58KXg+r4Hp6Qt31X4ns12BD8K7uvNskSu8taKg5c4hs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="384401925" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="384401925" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 19:41:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="829395002" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="829395002" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga005.jf.intel.com with ESMTP; 04 Jan 2023 19:41:13 -0800 Date: Thu, 5 Jan 2023 11:37:00 +0800 From: Chao Peng To: Borislav Petkov Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Nikunj A Dadhania Subject: Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for large page Message-ID: <20230105033700.GB2251521@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-2-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: AD6444000D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 5n8hg5in6igh4zi9aiqjkcdf8h8b69t9 X-HE-Tag: 1672890087-378766 X-HE-Meta: U2FsdGVkX1+2J39vmi0wPhLG6oErCP1O19DIQybrI7Nzq8SR5x6GEI7QRZ5W3g82F1fmyEGc7Akyh2urhZEpD1YxhMdw1fd182XyXzIlU9GrIxXiISmTpZha1g0232Deay5Rp6cZO9kI6/Gngc56SU10DUdXzGXrB0j7KL9eJgAILBWycuSqbpwy48iWov0N+63I1JfER5cjXbK9wbhonhk6mM58VCUjKewEOX8V58t1sqfNGdADaHahYnumjFfgLhgQMTA0itkcEorToIhixGNbQXseQ4bgfKurQ16NrgudujibaIBxLMUH4yakYRWN3YY4+WAVzLG/PvllT/pT2qXr7dtgPYpMyJipOi7xL0dnzL6KlujTbIfIWY7Lx5OTI+TFC9eR+ycPTKNUysuKmlM75R9t4v61L6UbQNtvnCMb6PgfNzKc2gGqQkyWoseqKBgKxVFF8TIE9pY1RgmjWDxrmM8jKtKcwXBmUVkC+JRpZdMTjbA4Z97RndFULYHwc5n8Xvlk0sYAaHBDopAs3Gznhf7N4XLPNr41vVzjZmDVGpl4p88kKGja3p0g2xJWKq6V7uIHirDX4fr6FokAQGd/WimwC8llvcsjS20uhsoNMzn6I+prnfJbgdRE8VeCyUe/744SDebkm+FOKY8sqvlq3sxKYwp+1/eFf4eAug0lE6VTEqLe7GwkvURPAbKHZHIol6q2FcwOZvCOObHs9g1mGrRaVUO81+TBg/ylCMw+D79BqETMXFBORv9JGXzHNxxD6X2D5XEAVN/e2raPer+RiI7TxKC2uzDk2I5TtsH254YOXQ7U1cwyHYY8BjAWupuJEUav0vk0C4aga9r5ERL/daE5R8/fmaH87rzmJB+7qa21pg76SBW4oe3DC2cWgSSFqchAHsfMDhIiufKPJUgWtdw0zXlS7c/TFsjSfPZCKWXpHDUxwvzrYk/XsidnMZvWptjueJs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 01:16:04PM +0100, Borislav Petkov wrote: > On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote: > > From: Nikunj A Dadhania > > > > Aligned end boundary causes a kvm crash, handle the case. > > > > Signed-off-by: Nikunj A Dadhania > > Signed-off-by: Michael Roth > > --- > > arch/x86/kvm/mmu/mmu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > index b1953ebc012e..b3ffc61c668c 100644 > > --- a/arch/x86/kvm/mmu/mmu.c > > +++ b/arch/x86/kvm/mmu/mmu.c > > @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm, > > for (gfn = first + pages; gfn < last; gfn += pages) > > linfo_set_mixed(gfn, slot, level, false); > > > > + if (gfn == last) > > + goto out; > > I'm guessing this was supposed to be "return;" here: If we finally need this, this should be "continue;", we can't skip the remaining huge page levels. Thanks, Chao > > arch/x86/kvm/mmu/mmu.c: In function ¡®kvm_update_lpage_private_shared_mixed¡¯: > arch/x86/kvm/mmu/mmu.c:7090:25: error: label ¡®out¡¯ used but not defined > 7090 | goto out; > | ^~~~ > > /me goes and digs deeper. > > Aha, it was a "return" but you reordered the patches and the one adding > the out label: > > KVM: x86: Add 'update_mem_attr' x86 op > > went further down and this became the first but it didn't have the label > anymore. > > Yeah, each patch needs to build successfully for bisection reasons, ofc. > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette