From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C509C46467 for ; Thu, 5 Jan 2023 03:39:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF0C38E0002; Wed, 4 Jan 2023 22:39:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA12C8E0001; Wed, 4 Jan 2023 22:39:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C416E8E0002; Wed, 4 Jan 2023 22:39:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B41498E0001 for ; Wed, 4 Jan 2023 22:39:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83C0DC0362 for ; Thu, 5 Jan 2023 03:39:19 +0000 (UTC) X-FDA: 80319340038.17.33A7DA4 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf19.hostedemail.com (Postfix) with ESMTP id 26FD31A0007 for ; Thu, 5 Jan 2023 03:39:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EiwCaXBd; spf=none (imf19.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672889956; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o6JH9jd5EO4UcXmANGw+9sT3I/5Mb3/7J9kyVuv6/RU=; b=6OogDUH4HhyIneO/hV1raKlYj2nDMsinW35nosCIS8mnAOvKwRL930q5BCuVTR5hH2lT0o 9/05ybzHekEl3hEf1IFp3AiYI6CbWfapDO/SnTF7YTg8CJRUAIhxN0k6/mn9anNeIfSSla qVdUhSWyTYtIO0ot4fWv9BE51nKNfBI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EiwCaXBd; spf=none (imf19.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672889956; a=rsa-sha256; cv=none; b=bCY90S/fya2XHphSbTjfFBqYXlT4Fagl5o4clbYM+O3X+/0cjMQ5B8Kv9Sl4VU5+UqfnjQ nS91bLNITvvvozpteGfBefBsf21TkeXXAEkU43jXz2UPYBgkDDfQHwo44yT5zcy1ZRGdQI ZEv0/eDgEHbtbUJFHXCJXnJXrOF1LyU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672889956; x=1704425956; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=7+whF6O83FkAi7trCF9TEjov28V0K0S8cRinP/bHSI4=; b=EiwCaXBddgQHbw17ExXcSftEmqIBCOp7+/PrLP6gPQ0G5bzNwp5sZ7DU YmoNWMtX/Wvvymb8b2QvwJQzeeG3LKBr6SoaUZGVIqtcx3HbFUl+7AzAi VwWN2Hu2rHRcl3rOmU/omA5HHLi0D2zjYUZW1e6/5AA01qDHW+Ft+f2WT Im+336O6w0hxP6HQlESjELAu+TAlHgrkhVpBYwwcqd3jeWbyD6XgNaFPF VJ6ZBX8qqcRoXk5S3426icpVqrMRwqPcIuiHWWIYkB1JzOILMqz3lScK5 w92KKmeRUj1wR0l5MBDUmSUlUxhJpxwcCM/VOky1ftr18Gq7Lb3nUKQDH A==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="349328883" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="349328883" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 19:39:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="829394357" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="829394357" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga005.jf.intel.com with ESMTP; 04 Jan 2023 19:39:04 -0800 Date: Thu, 5 Jan 2023 11:34:51 +0800 From: Chao Peng To: Jarkko Sakkinen Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com, Nikunj A Dadhania Subject: Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for large page Message-ID: <20230105033451.GA2251521@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-2-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 26FD31A0007 X-Rspam-User: X-Stat-Signature: pije6rhib4ng7mcs95fehudeihc99bum X-HE-Tag: 1672889955-699666 X-HE-Meta: U2FsdGVkX1+FpKCAeYTXv+k6Kc++FlAg+Xas5RDkzURPDxZjoeDzRq2lerXIzo5EKjHtJ+zFWDm9sZAON4Uh4aHlfLKwOFJsrCHcswrEc7gEuVqQ2jX51bHzNHRZh0EGCpAnS+rw8IGB7ZsVM7H/ApxdPGvRrpSF9T7zS3DAPmAfTM9AIPK5BRegbn+fn2qekE9P5fHiYW+oBeR+8nd3sVOg5cY9v2di7ahSsFpi+RaNMhYyMpHJ/Muz7QTZNR67Y5ln3egO2DtdD7XRM/YXDFyIvUM2cbzBdhjCf0P4pwKA4KTLFWi85wSniW9It+oLT8jU+jN71mVzftCtrMTK/TaP3azWn3z2t1NNroYD71WDoN1C4zWlGSoOzOkcs3tYKZt2mGLDb3C33O/owtj9PtgkJjH2KQRsU0mmD8ivovIa9MtstlyWdUEX0T9ZvlFv/An8x/dHCe7jsV0hzMcOZUSWap1jpKqwZcYUt4i+mKOLuFtJQa1Ci5NIQGv+PwtyolTI4rmFzeBUUN2xKyosO6tLY2TO3AeD5h7b83X7ps/Po/UkkJKOYhTQqsQ4xe/t3s8W63Um0oaEUq5zxFQ3h8exj/wsE5vfkDjdQTXUam7mhCXrWUjSxfYgCb9w01dW3JMVy08CtzJOm5E7EuHTwRkM3dEzbIzk+PbIzUU+9X9G3Z8gLdZ3yzhT2MjekS6qeG4HJzRD1XwGZG/fEnEc/uUOdJ8FTFX5nJZPaHjx+2fhXVvv/DrowIw2Q5kaUoQDCE0p0IcXoakYkOmlqcMB5N7cASQjDfuh+VQdG1u801WWD9tuJ9tG8NjFuFYOvzRxbgQkRRn87C04JQ33kaT/qbiWVLI8tNgLNfQsVktCR6BKivSdbmZ6xb+WgWOZaDtfJsIFM01Uoag0B7/8zc0D15HaQKysgDWQFtQnXib5+OPPD5fjcEIwiqagv8tISfd3WYXzWSTAjLQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 04, 2023 at 12:01:05PM +0000, Jarkko Sakkinen wrote: > On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote: > > From: Nikunj A Dadhania > > > > Aligned end boundary causes a kvm crash, handle the case. > > > > Link: https://lore.kernel.org/kvm/20221202061347.1070246-8-chao.p.peng@linux.intel.com/ > > Chao, are you aware of this issue already? Thanks Jarkko adding me. I'm not aware of there is a fix. > > > Signed-off-by: Nikunj A Dadhania > > Signed-off-by: Michael Roth > > --- > > arch/x86/kvm/mmu/mmu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > index b1953ebc012e..b3ffc61c668c 100644 > > --- a/arch/x86/kvm/mmu/mmu.c > > +++ b/arch/x86/kvm/mmu/mmu.c > > @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm, > > for (gfn = first + pages; gfn < last; gfn += pages) > > linfo_set_mixed(gfn, slot, level, false); > > > > + if (gfn == last) > > + goto out; > > + Nikunj or Michael, could you help me understand in which case it causes a KVM crash? To me, even the end is aligned to huge page boundary, but: last = (end - 1) & mask; so 'last' is the base address for the last effective huage page. Even when gfn == last, it should still a valid page and needs to be updated for mem_attrs, correct? Thanks, Chao > > gfn = last; > > gfn_end = min(last + pages, slot->base_gfn + slot->npages); > > mixed = mem_attrs_mixed(kvm, slot, level, attrs, gfn, gfn_end); > > -- > > 2.25.1 > > > > > BR, Jarkko