From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8927CC53210 for ; Thu, 5 Jan 2023 01:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2654A8E0002; Wed, 4 Jan 2023 20:39:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23C398E0001; Wed, 4 Jan 2023 20:39:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 152348E0002; Wed, 4 Jan 2023 20:39:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 090E68E0001 for ; Wed, 4 Jan 2023 20:39:01 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D1861160156 for ; Thu, 5 Jan 2023 01:39:00 +0000 (UTC) X-FDA: 80319036840.12.F81331D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 48D03C000C for ; Thu, 5 Jan 2023 01:38:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dTardMPj; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672882739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iL5xB5HfG9cFdqqw1T7Vg0Wv3W0CVfKo+qbv9RQt2Tk=; b=Ap/pE6QUgwv8oRpNCkgJRIe8LfVkjsm1c3d4WWCzAV7FnqeZaQgoIFRq6GLEXHwgMd5AQ2 xoC3QYKqu7QMABUOJ4VXppEv8jVMdd+532chl8Wmlj+My3BnvQbzGt8WMPeGgUNq+xxC8J sqXkUtwtbUdxxm+mHvgxpvRXnQF5loI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dTardMPj; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672882739; a=rsa-sha256; cv=none; b=1D6oq+dplAVhUqLVNHsvDsUSL5mvip208x1R/EM6Of1VaiQKCb0xh19SUCIpQQoOEj+vw2 X+5Vq2eDTVs60suKPMLups7DuP2DGBB01OSOUEaKFqkoYMbhDroL82RigevQLknjFteXPg 1u+AdAeVy5o7c/r6OeDYJdG1xyWC0ww= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 35496618B9; Thu, 5 Jan 2023 01:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97678C433EF; Thu, 5 Jan 2023 01:38:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672882737; bh=Hba6ddPoEuFTAiIDFk8w8K0/JAQAQv7vkxWx0br15B0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dTardMPjP6dU0Nt3lM/chNUUy2Ia0ipFBa82JnL+BAQDimpfCGwbvTkIwTmXwc2OJ OIWCs0xbqjRK5ZtRyWd9GW4oW0BZYDOHuNPOMxr7n1d0/1tsJ/H++ZkCi9UR8H5Ss9 gHXUcp4AeRhRk67n6rU7CEpSu0SZtzc/OtUcJoeA= Date: Wed, 4 Jan 2023 17:38:55 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: hughd@google.com, hannes@cmpxchg.org, david@redhat.com, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@Oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com Subject: Re: [PATCH v2 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs Message-Id: <20230104173855.48e8734a25c08d7d7587d508@linux-foundation.org> In-Reply-To: <20230105000241.1450843-1-surenb@google.com> References: <20230105000241.1450843-1-surenb@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 48D03C000C X-Stat-Signature: udtjno5pqbqkdsbjtkkekm6ak1g5bs79 X-HE-Tag: 1672882739-875694 X-HE-Meta: U2FsdGVkX19wz3le8Uq1CqCVnNvPTZ3qfg+DnOirFfPcZwjT2+pe0LEwA8XXvv7fGu1BQmvzG9xG5U6/b0+uUxIxa0/YRJ9UZtMGXcFQiS1bmiTpcjFLw7WTE/LyrMaB23e+Xhr4cn4qFwQKaHnFO7JgJXEuLjI1hZvqVNG+dh6VuG3GYzQKIJ3wZNY4UlxrlWU7eNFc+ZmWwlfL8hCSkpxCDUf+2PoztxC/aBgVF8kCTe1ZXaYsomR/LjIRvxGJkxHqWZbeOXk8rfpTyWhkusJGev/16nvVA6AgWgN73YBqeWsZLXKITPjSagUgY/u5EGuwl+BVUDcz5l2qX7VcmXyHRJ2q1DWfvn2bfVncgJzmgbT3nbL+8IWY4ZfSo49UBJ4N1aab3NkilAKbF9PgkpmX0BfUr2Didr3+KY0HZV2S89te6cCNRy4RoutkoKUEBbVwKyXqKE2s+vhltsLKa+npsLA12+0amWejHoCHzVL3D1Vw9O7pktFQd/4AWXj1MSnPPGPqkgaaNepzQf3Dj9CfC5FmsHIPRX+e2BB4J2A/E5jZqQDYf2SG+eDv9GdnBKouHa8QF9esfvsgEBKn/sPt2ytb55aJSbPZJzjWWs4JEIsY9qNTzaTTbIZHSB8jnzD++7+J/y60t6p7bwHx1MqZ+zDNEl2H7+6ACeH+az64zUJNTvNg/SGVw/n2VLV68wKg8Hx/u7OArvwDMJ+cKBqmcPkfiiCarufajuBOfi1Zlc8XfFpE4cBnnkYhgQpr1kF5+X5hcHjUbvBymUj6LJhwPpKHtS8RNYAx/5yohC4Rr0V2l9+g8L9jG4lUIKj3m4V8D3y2cTb3JABCaZPTxH2WtsAK6GctluUhG1T7hGDQOCAkmGzAKNHr/B0qKwBr1qR7Con4GeSk0bN6Nk04SFZxpk4xG8zrVVvvNZzPxALYRriUca3LeaG2xoegbcoei3l/8+EXcMZ/5v3aGPk K5kYRLHF OLLPPrjEKyb1QbSTD9OtB7ucjN+VrOn3bBIU+v4njiy6SuTqUlDhYMFhfw3CfJD8HeGipgq/TCreAoSLeIjhAmzha0M6uTPbqEZLdNOCmXTfJvH1b1FnodYn3KjEJisu3fuoTFJdMisROer+KstXw2mFMPy0iFDLbHFyjAtDohdlLPr9BZ4pJv9hl5TBuGmQrSiXgHEtSR+fiR6U27tTPL/Ggiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 4 Jan 2023 16:02:40 -0800 Suren Baghdasaryan wrote: > free_anon_vma_name() is missing a check for anonymous shmem VMA which > leads to a memory leak due to refcount not being dropped. Fix this by > calling anon_vma_name_put() unconditionally. It will free vma->anon_name > whenever it's non-NULL. > > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") A cc:stable is appropriate here, yes?