From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D0A7C46467 for ; Wed, 4 Jan 2023 13:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97338E0002; Wed, 4 Jan 2023 08:35:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E47138E0001; Wed, 4 Jan 2023 08:35:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35778E0002; Wed, 4 Jan 2023 08:35:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C72668E0001 for ; Wed, 4 Jan 2023 08:35:04 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A483AA0B98 for ; Wed, 4 Jan 2023 13:35:04 +0000 (UTC) X-FDA: 80317212528.10.F7D0293 Received: from p3plsmtpa12-02.prod.phx3.secureserver.net (p3plsmtpa12-02.prod.phx3.secureserver.net [68.178.252.231]) by imf27.hostedemail.com (Postfix) with ESMTP id 049894000B for ; Wed, 4 Jan 2023 13:35:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of atomlin@atomlin.com designates 68.178.252.231 as permitted sender) smtp.mailfrom=atomlin@atomlin.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672839303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0RGflrWi7RBkhjN/GOBI/cexfG1L5LT1CKzy5weMHg=; b=bvLnstevaDOIZgZdQV1YGxZhhn/aQPAMm9IkY5m45yzsNsZjjW1EcOj//rLlLNnMj6x61g DFfMN9O/7C0xjcqygFPEjfMq60onGK4++0eV797mENbTqI6T2WjS+eQaFBImusEBoVn5yg YRz2FmB7UtOiISaRaL10wbcy+EBeVYM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of atomlin@atomlin.com designates 68.178.252.231 as permitted sender) smtp.mailfrom=atomlin@atomlin.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672839303; a=rsa-sha256; cv=none; b=yyFAvtRtxwKoa1PAjD6ednipgwHNTlx2G1+HbDpe2tOflDHSZ1BywCmgmZC3tmDtXj9QXb 9Bvcb0r+f/0piQiDOueVKbt43oK12LvWo/ihsSQQa43lpWTyQ5msxwI2HPQg9ey9qU8Ny+ Bdw755UlOa4Dshf1D8wEx3XJKGTF3Qo= Received: from localhost ([82.17.115.212]) by :SMTPAUTH: with ESMTPA id D3v2pfNMzdnFID3v3pOI73; Wed, 04 Jan 2023 06:35:01 -0700 X-SECURESERVER-ACCT: atomlin@atomlin.com Date: Wed, 4 Jan 2023 13:34:59 +0000 From: Aaron Tomlin To: Frederic Weisbecker Cc: Marcelo Tosatti , cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v12 2/6] mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies Message-ID: <20230104133459.5yaflf3yicpmhbbh@ava.usersys.com> References: <20221227121137.102497574@redhat.com> <20221227121341.981235373@redhat.com> <20221230132132.GA186035@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221230132132.GA186035@lothringen> X-CMAE-Envelope: MS4xfFA/uiN5hbKR/L31JmptVVhPRsARrLU7WBDehIBzhMxSZcxbBRUHhVl5Q3RD9uMKRFoYIB6a9w+0oldFH4hNfryhz98qvH5hD2s7YKCfhbG/wW1toJr8 ibdeHnwgiZ5xuZQgFsoruKjde1wlQe7xGBXq6DG0OZd66zFZ0bR55hlRdhPobkaMNpc1zGsv2vJiI0hlQ6eL23baSaapoe+p/KwdsViua2WPV5o1CHBYSWpW EgXeY0oNbfEbjHzGmoTMH8dR0XegGWkrvGOLSR6gnB9DZLgudtEngQcLdeEaca8SXBPGKLNH1pBYj3BBAWREpABvBQHIv8VbCqnpOfKyfNRETKexXOXQfQ4J 5r/y+9bMe4iywjpm7R3vQ2Mg91dtGTlhnQUx6nIECbDikyein5POLuPVRmU47edKImUfpBlJOs9BjxUoJdplajJRHHZjuJ8T0W5yRsf4gXSnYwMFbYqLGgqQ XsuPxuDLkxEUoVvN X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 049894000B X-Stat-Signature: bpb6nxc3qwi6ze9tpnbomb51xfpatscb X-HE-Tag: 1672839302-639141 X-HE-Meta: U2FsdGVkX1/3yKZVsAwq0ORoizJRisJneFXUCXr4mzl+ppmB3SAHJFIHnAlyaO9m0KXHXX2R0uT3N4vRxsTl3jcoAqzpavNZyM3lyL9u2sA/TK820a0vieorC6p0RxPAy/Lz4k9qEI/njU5ttZonAJD2OYI3qQUIdL5v5EeEyBr4dw6GEfqazSQQ0rmuf6SjFUy7zqkBUCLx7+jEKW7EvTH9ap1HtgQR/7fSNa/h7c1H+Jwz6loXBUwCgm39a41pJXXN9NS/OwqnmFSRgEZGZPgONDJxWENRRIeIpkEA/kMkQiTanQRfY5xJYkN18jGmoc3ADimex6f9/vAwJ5fcC6j65k7mgTKz9RSKoqyyGw4SIVcaM8qolJmsQrPPYWLFPcU4SzG95WZuW0A7tynyawThxa1uynDFxNdR/wVL1aIKTV8bp5BoxcUtpmooemi6ij2NBlP3Mo6Hz/4HVl/zU6cC74tSmUEvq0Qqm++nLdqC9d/WLTcCi1eudnrV6tQFPhVjC1zQnG9jkiPvAh7Um+IGfRvKUHuY6B7shQDikhBuaYNXz6rfIZxc9MptOLDssolOIh1vVKbOOcG1r9XZ8tTFmhcpOWUgb8+IEuM1aoE1wNAFzLrYt+fw2PZXYsm9v8IulG073JIXV/hkHef17nHcUDpX+cBM8c+U8gIf1FjEXYt4kHcvdJN78OccOxjPdBhDwLINgr/8u1Jlo7K2l4N8xBjMJ2luEzl8mRleZ92Sv5nax5m0xJUW8eKIZB9B3FEfNNZr5yOLEXpwq19P7R9VyMScD6b9P1otwxXLhDWz9DjpnOUloIl4uiTxAUqzNy1PLYFmBR+mT1k0BVTbZZsidiCHP9fEymT6Q843iFSSCrQUdViV4+B6fcae5NZdcVX0p0Xz3GHi45mDLnbv+vcWCTykGpKXcOp9yWfjdd4Tya67oTLjCcjxSNjnSYz8Vk7QonLg1jCZcTEXwE8 xaogsdad xbdUYtH47qR1vKHM0CtTFyIlDb7U8VP+V/bao2Nq479nhGkRnIoHcxSoUK/sQY+akyfMfd7Rm6m/tXoc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 2022-12-30 14:21 +0100, Frederic Weisbecker wrote: > On Tue, Dec 27, 2022 at 09:11:39AM -0300, Marcelo Tosatti wrote: > > @@ -606,6 +608,7 @@ static inline void mod_zone_state(struct > > > > if (z) > > zone_page_state_add(z, zone, item); > > + vmstat_mark_dirty(); > > } > > > > void mod_zone_page_state(struct zone *zone, enum zone_stat_item item, > > @@ -674,6 +677,7 @@ static inline void mod_node_state(struct > > > > if (z) > > node_page_state_add(z, pgdat, item); > > + vmstat_mark_dirty(); > > Looking at this further, about the two above chunks, there is a risk to > mark the wrong CPU dirty because those functions are preemptible and rely > on this_cpu_cmpxchg() to deal with preemption. Hi Frederic, Agreed. Kind regards, -- Aaron Tomlin