From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9B9C4332F for ; Wed, 4 Jan 2023 12:04:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 739428E0003; Wed, 4 Jan 2023 07:04:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E9318E0001; Wed, 4 Jan 2023 07:04:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D9A78E0003; Wed, 4 Jan 2023 07:04:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D7168E0001 for ; Wed, 4 Jan 2023 07:04:42 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 19088160C81 for ; Wed, 4 Jan 2023 12:04:42 +0000 (UTC) X-FDA: 80316984804.14.BC2B904 Received: from outbound-smtp04.blacknight.com (outbound-smtp04.blacknight.com [81.17.249.35]) by imf22.hostedemail.com (Postfix) with ESMTP id 70E23C0008 for ; Wed, 4 Jan 2023 12:04:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.35 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672833880; a=rsa-sha256; cv=none; b=qEatr4qQkczb7K0TTJseZxk6odoqpSntYTM1bat64rM8TwFSG4k1/adaX9EsjFB46fwmRY 9RXXfkuKGKV66OlPJ9ZwkJ0M28dnjkvd6L55z1V5h+z/hU+NYp7smEgRRgrPc6QZ3WGNPX bMp+TrO3oW3SnnoxQGeIBAQF1szb60M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.35 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672833880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWl6zQMXCoPWNHt0fQZq0uP9F9H2ek+7j8yPsdTXj54=; b=hK/EtPrykKqnuVq9q7IGwffBHYOiSqF3g6qdlx8keiBw55qMBlNk68lsi7B8gHJ4h8TXKf HXj3SNuJfOs9FQpapc6MxsXrOv6p4e78oTGRzSR9gwgHFjA78y47GL6Gw6aHVHDS9KcZR6 fBH07t+bP+62LbRYr4IWHQO1zkuuSUw= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp04.blacknight.com (Postfix) with ESMTPS id 5FFC3BEC5C for ; Wed, 4 Jan 2023 12:04:38 +0000 (GMT) Received: (qmail 28552 invoked from network); 4 Jan 2023 12:04:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 4 Jan 2023 12:04:38 -0000 Date: Wed, 4 Jan 2023 12:04:36 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Linux-MM , Andrew Morton , Michal Hocko , NeilBrown , Thierry Reding , Matthew Wilcox , LKML Subject: Re: [PATCH 6/6] mm: discard __GFP_ATOMIC Message-ID: <20230104120436.nto7semvbrsvakjg@techsingularity.net> References: <20221129151701.23261-1-mgorman@techsingularity.net> <20221129151701.23261-7-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 70E23C0008 X-Stat-Signature: 557jhnqzco711x9shemazew9nst9xd6c X-HE-Tag: 1672833880-527266 X-HE-Meta: U2FsdGVkX18+7J86wWzl1JY8xrffuaW+hOKn/XvezRoUQMFfTPdnspQCjA6GnaxmtrQsUjsM0ay6UPUjcLJMdp+UWxYU5xQDkr/8t5Ov4W20VcQSHalBKGEUv8Fr+trs8EJUA5/5mYFlZ+lP8JvxX+LmEgPbnkgagPH5/FzpLgb82TqoUN1n89Tsogwk6XIZW1FhHz6m25Kk6tuQR2mpcKUyDFtP4SLO0dvra/dtp0JzVisBEaqw2UKyWVyd74zs8t1fgyJH1b++RbJzRSFmGLIe7l0CwoyXmuTGDn6VWHCn1yvh7pdTJu/XxZvFmVxnT2csAsvbRRwOsF+vlT+9gLv4cbkURebGHF9DFJUFMIre9h38JU1Mb7EvPd6CUsVuMrwrcBUMudYPrE5OUax1P/Q1EXlSftedfeIXT25XRQFXGoqnMzpR1PUg2FgSgX5cxqfN+sBGp0zbHSDRTb5iniXu4XGJXm+1IuVrtnwt3TfDoo+Qc4+9k/wc/H1Q2+wYr/2ndBj6m4Pv4kySiisK0mn4VmU6m2YB7w1UA+Y9Hx5ke0b4+5ShQITh+qJKnT1xwVNAoB9ne+A3wMAolq63Q+vocEc4fbHie6N0pL4+w1RARmCHEa4CUdbH52DhZLZTvg2FkeEnJgaPoQ8uE4V5jngCummdRRCiyxFI+WXnmn8p20PgN/Vt3OVsGybJZjhRc/W2ZItts/bfmfTdtzw/BEkEesYM5ilrcSNIsVSkmIRtU3Z4TghLo7JKrgtUmQe1OgXGVkH7RoLoJThlktToiYEMSHHPq/+U91UMAcvyBm6QOVyg8pNrVIuCFgNIrKcLdMdHcBG9YwBE7O/PCNeUMu4CUkatOh9gkgspnaE4EL6Da4ATWP7mhMpALefQQNegHXjzSA1X3f5+kRp/p/WRHUPXic1agXnlTuvuQm2ol9dWHOF6o/f61PEnhJNwNP8pJ/PH1h0j30BT6rzx/p7 iitzgCp5 Cp/e9zEFPoRD0gEQbHiZHAttqVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 07:17:48PM +0100, Vlastimil Babka wrote: > > @@ -4081,13 +4081,14 @@ static inline bool zone_watermark_fast(struct zone *z, unsigned int order, > > if (__zone_watermark_ok(z, order, mark, highest_zoneidx, alloc_flags, > > free_pages)) > > return true; > > + > > /* > > - * Ignore watermark boosting for GFP_ATOMIC order-0 allocations > > + * Ignore watermark boosting for GFP_HIGH order-0 allocations > > There's no GFP_HIGH. We could either keep GFP_ATOMIC here if we want to talk > about the high-level flag combo, or __GFP_HIGH if about the low-level > detail. We're deep in the page allocator implementation so the latter would > be OK. > Fixed -- Mel Gorman SUSE Labs