From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC88C4332F for ; Wed, 4 Jan 2023 12:03:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 369B68E0002; Wed, 4 Jan 2023 07:03:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 319548E0001; Wed, 4 Jan 2023 07:03:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 209CB8E0002; Wed, 4 Jan 2023 07:03:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 13CA58E0001 for ; Wed, 4 Jan 2023 07:03:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E75EDAB10C for ; Wed, 4 Jan 2023 12:03:50 +0000 (UTC) X-FDA: 80316982620.02.CBFBFFF Received: from outbound-smtp63.blacknight.com (outbound-smtp63.blacknight.com [46.22.136.252]) by imf22.hostedemail.com (Postfix) with ESMTP id 471D4C000D for ; Wed, 4 Jan 2023 12:03:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672833829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WS9AkiOJEglBQzS1TvCc+BWrnal6YlhtabWMfuS4QZo=; b=iHh6SPpH5Ea6NLsUlZe9HCQPKVgCLVQph9GlCWfmAu31TEKzQy5fmzMHD68DadxbKd/qgC pWmYj71P/BFhwgDkS3+JFRk4yAX1GAmGKfSXbMJ65fLz+5YIYZLNRkqTAJxBk1rGM+e9wq XsJVWWTw6s9t9HgpDk0vpvp26rxhgME= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672833829; a=rsa-sha256; cv=none; b=q3UPY430/0+4sWcxLQwa58A+KVOc3d2ts3JN/rTY39oWyt5aKrwydCvgV9lGBJH+0l0QEd x4pWHGrEXyq6rFbvXTTIl+JaiE0EFvU/xOIiwMBNAqqDkzOgzMgDRy+Xcwoddx7zY117Bi uzZUvNadFTy3neTm29O2+FOAGvDe7Tc= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp63.blacknight.com (Postfix) with ESMTPS id E2B04FA8C9 for ; Wed, 4 Jan 2023 12:03:47 +0000 (GMT) Received: (qmail 18400 invoked from network); 4 Jan 2023 12:03:47 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 4 Jan 2023 12:03:47 -0000 Date: Wed, 4 Jan 2023 12:03:45 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Linux-MM , Andrew Morton , Michal Hocko , NeilBrown , Thierry Reding , Matthew Wilcox , LKML Subject: Re: [PATCH 5/6] mm/page_alloc: Give GFP_ATOMIC and non-blocking allocations access to reserves Message-ID: <20230104120345.imuc3pguzyjm5oi4@techsingularity.net> References: <20221129151701.23261-1-mgorman@techsingularity.net> <20221129151701.23261-6-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 471D4C000D X-Stat-Signature: zkwerzc695jexgsxg3dkgjwf64wgg1aj X-HE-Tag: 1672833828-591871 X-HE-Meta: U2FsdGVkX1/oshnop8utilm/D9HiB9tslLWN7tJHhH0letndLB9kC3Bv1PlLV22mhsqbYwdctKJLj7jMKEBgKN5xBAb56lH4ckofIkKQqfp3um13U10sImOS0GsqbQPshUmM/vjODreBatLbFUCmJ3t1tjX6zY9SRN4NZv3QuzFW7hfyq9tKBOMID8qBH4ciwus1YATrXPwX2ugz+5JcT9hrzaEQwwIdxoCMZ57KnhCR+6LtbCnibgrrA418KEY6l5s4SvGnRQsSUA1KJt/83Omzths5P4Lc6knfvWhRnmlxXFVJC27dM0NJcR9f0dTBUhRVA+hchOaNHRj7/KK3YklTjTxG1Mk/GzqR4gKZ96t3UbVDa23XpPfz80SBF7hiU5LNrB+c2J5pe6/9VqW7Q0G52iEwaSJa0r8gj2DxE0cxmyuTtju0pSbvprxeWO9MaeYPS+/paeJozIvPXKsTvunKG493bA7Fl6no/IC7nCYKiyNuzpWVh0muZLpu2pN3FZmobIt614op+3d/gseBvlsoaY866KXFOiK0sWlOzJyR0OsqUQTHuv1f1vcR9xEKSIepOtlv5xHOQNStEBzipNe1OrPji5DepQPtlk3GF8kviDQ8tB2FC1PZIqs+6YN/w6Zdw6tBa3i777KcRz2t4vSYrnmfVnpEmdLhssY5CLWrQeepcIb+vBm9cQ12yNvNmXrQFeS+oYHvQGcA582DJ6UMjw4MCyFr3nENt8MCxvbqJLlyKmPjM4xGCtRtnVOhqd3EjrBa0Vi0U3rltpm4WL6kYkD+GO3mui9RWf0fJEiMfUfZgazEh/F6yXxocVE7cLid49e6048aEpUR2a5UMJMbCBXZlcuxgC/dULC8g0dLidYRuFRtHVwz23potDua6r4rwy65WiGLM1NJYtmkDTVAy8kg6WoMxYdIB49GhdZcOgIkFURspt4PNJ5MvV5ySPMB5HHLOoFpbu6HIYN XYJjPIAO xDbFTNe1qZCtO0DQgMADUlrJslOKJbiX8ken4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 07:07:06PM +0100, Vlastimil Babka wrote: > On 11/29/22 16:17, Mel Gorman wrote: > > @@ -4846,28 +4846,30 @@ gfp_to_alloc_flags(gfp_t gfp_mask, unsigned int order) > > * The caller may dip into page reserves a bit more if the caller > > * cannot run direct reclaim, or if the caller has realtime scheduling > > * policy or is asking for __GFP_HIGH memory. GFP_ATOMIC requests will > > - * set both ALLOC_HARDER (__GFP_ATOMIC) and ALLOC_MIN_RESERVE(__GFP_HIGH). > > + * set both ALLOC_NON_BLOCK and ALLOC_MIN_RESERVE(__GFP_HIGH). > > */ > > alloc_flags |= (__force int) > > (gfp_mask & (__GFP_HIGH | __GFP_KSWAPD_RECLAIM)); > > > > - if (gfp_mask & __GFP_ATOMIC) { > > + if (!(gfp_mask & __GFP_RECLAIM)) { > > This is supposed to be __GFP_DIRECT_RECLAIM right? Otherwise that includes > also __GFP_KSWAPD_RECLAIM and GFP_ATOMIC sets that one... > Yes diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 0b2093d17b48..2217bab2dbb2 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4856,7 +4856,7 @@ gfp_to_alloc_flags(gfp_t gfp_mask, unsigned int order) alloc_flags |= (__force int) (gfp_mask & (__GFP_HIGH | __GFP_KSWAPD_RECLAIM)); - if (!(gfp_mask & __GFP_RECLAIM)) { + if (!(gfp_mask & __GFP_DIRECT_RECLAIM)) { /* * Not worth trying to allocate harder for __GFP_NOMEMALLOC even * if it can't schedule. -- Mel Gorman SUSE Labs