From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8138C3DA7D for ; Tue, 3 Jan 2023 19:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BE98E0006; Tue, 3 Jan 2023 14:16:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4155A8E0001; Tue, 3 Jan 2023 14:16:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2683A8E0006; Tue, 3 Jan 2023 14:16:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 101C28E0001 for ; Tue, 3 Jan 2023 14:16:12 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BD451120B1E for ; Tue, 3 Jan 2023 19:16:11 +0000 (UTC) X-FDA: 80314443342.08.FF7B359 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf21.hostedemail.com (Postfix) with ESMTP id CDFBE1C001F for ; Tue, 3 Jan 2023 19:16:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Fn9AI5Pz; spf=pass (imf21.hostedemail.com: domain of "prvs=4367607b20=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=4367607b20=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672773370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bKgaIgCzl+sBGwA7v3YqE5kXwxl/qwPaI+k5PR78ySk=; b=Hv3LsKL2BB6AN4OTiaT64oQy0L8ae6hJ7CR2vFy5wQ2G25Qep6NK9mhZvK6pTF5Z9DZQjM DHb4dCSRD7vM6Fz8kjQbQ+91qUhRE7hdIHJw1DveWbeFi4PNNM5qFYE6jWnIF3au1mpyK2 T4GAtMjZnfMhELCnljF924b0x08kjHk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=Fn9AI5Pz; spf=pass (imf21.hostedemail.com: domain of "prvs=4367607b20=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=4367607b20=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672773370; a=rsa-sha256; cv=none; b=hi0MFFs6OgbYSIc0SruSB2WBFese5vo48/Z6gR3zJgCk0aF8h7H7q+wYg2Lg2Ol+FWX6fW 5zl49AsSxsUcqV6RJ9MFtkPxo3Cp6NZeKhIB/6uGoAT0u4yJUed2jMRQDLJEOT7uhvFCaH ebBpCrvFlLato6RRVtHr4uGkJMhp4cs= Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 303IGKq1000953 for ; Tue, 3 Jan 2023 11:16:08 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=bKgaIgCzl+sBGwA7v3YqE5kXwxl/qwPaI+k5PR78ySk=; b=Fn9AI5Pzt5fWce8TrPp38MtIaxA+R6KoCEo7gA05GbPH08YLfKJIJwEX5XNk2siJaio0 GId5zC3U08Wf2hLSi7EkjGIiSAJKca98E5qvrkuq1OXtK8t8IIC2i/IMmqKjREWHswUm OsMxKJuAoFYZOXhlLjJ0+7iVek4JHjDhfv0lttvfTo+u2QhqDpYw5d7lfnycSCbQD2Yl 4k/X6BP4ZPOq6ZgpZa0u7pGkuHa/G0lVgHNKdAii1L/BR+MsI/cNwvX5OLJWP+7Yc7YI QLDoh6MofKMSvlxnl3S30XHsrQ0lPWXDNXxzpEO2iglhcm6GsdimxkJBSixBaX77d2dF wA== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3mtk356u4a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jan 2023 11:16:08 -0800 Received: from twshared22340.15.frc2.facebook.com (2620:10d:c085:108::8) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 11:16:07 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id B8920E1F5E0D; Tue, 3 Jan 2023 11:15:54 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox , Christoph Hellwig CC: Tony Battersby , Kernel Team , Keith Busch Subject: [PATCHv3 03/12] dmapool: use sysfs_emit() instead of scnprintf() Date: Tue, 3 Jan 2023 11:15:42 -0800 Message-ID: <20230103191551.3254778-4-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230103191551.3254778-1-kbusch@meta.com> References: <20230103191551.3254778-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: Ur9a9GFNQCWUHk1yRMzIhC2Njq_cBAX6 X-Proofpoint-GUID: Ur9a9GFNQCWUHk1yRMzIhC2Njq_cBAX6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-03_07,2023-01-03_02,2022-06-22_01 X-Rspamd-Queue-Id: CDFBE1C001F X-Stat-Signature: zmtsmn7fmuob8dmjsanpmi4q78qxeyaq X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672773369-333257 X-HE-Meta: U2FsdGVkX18y98zYo00lS9OPLYgoxAFfGthkefrZmI72XqhjV30MMnU3iHuH3HN5SYPHJ5INQLJtMtDYvx4ja2NNoZVXqqvRCG8Z71aWXpSlMwzggmWFy3XTY4Dkz5QdzUBNx4IGwHQNgmypcarjGyEi2KaAXTn1DjcAQ4chA8KER/x7X+Qjpv07111SbJHcMUiLfmPODOuTYC9dn1Ks101yKP3Gr83+WTPxUOSgDSirmr9gquhgk4KCIwYXUayHf13DpB9FJepKC5ROlt4RXjKEbJuyOR7wQKzaQt3cxsMBvwsRk8Z2BRpHp84dhOTHLnG9cxVNUhNnr6eaYzbZ6UlDxuE3+PQ/MtKSPQ7psVP8bF4uUezN5QuHqeEj/IYmtcVB7yAVNCguz8d6SPboGeEpVXttMr215mlcWfQ82esv66V8Y7gXhD+9tuarTa07DxGniQKMqCTTsVK39xtRfyDjTLsmfucQsSEua2jDLd8UG5YeEe3KycUh8q3kUXwDJdZVd3Mxf7PVY3Q9VTciJ9A7Hs0p9ZRSxiG6mpOlH2AIn/UjDN6Jj5eVYieagbmCTXseNDn6zddiad5+4BW73LepX7W/et8x1hEZu9O6bkwD6MSEPqw2zsASM2lRxtXhJu7/2WGWIWh9zjEeGfIWQVa9ZDdfLZACljvJu4ADV+lSXigo6Wc/L9LQ2WnUyGs5TplZj/wQq2XSXQWfZGHARkb9plH4fVg3RcjVQ8qv85m0SAM1Q70EDNvB3Ntogt4GG4CKp18o5cbkhBVR6FUEiy4C2zdIngWBgoKa1ZoGFXU2rLulQ+876P+KkNhaA4j5EM4pFVGjydeW75Pc550Eq4XItNPhXgJCpPEIz8rIWdXeb3nEJltVvaLZhCPe/URzIlYNWrS6ixoyUjsSyaFffwf06907pAhTGoILkd2QCNq05cF9UOJ25Ro2zrISrBJK3UecFSQ29W6C/Sg6pEf uGwCpPX+ gw5TQvX91h9dSKMx61I2tX5oNRz8LJG2tpjb9Oxkbft5BFi6htKbAbOqSaS5HbAZ1aky9sb3EK+pALAZH6alzZGWI3cO7DB0jB0KQ51ECJNzTZaZSQzVtmVdyy6XJL3/+QSEBeNKAr3yzrvL3+EOZe5VsFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Use sysfs_emit instead of scnprintf, snprintf or sprintf. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch Reviewed-by: Christoph Hellwig --- mm/dmapool.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index 559207e1c3339..20616b760bb9c 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock); =20 static ssize_t pools_show(struct device *dev, struct device_attribute *a= ttr, char *buf) { - unsigned temp; - unsigned size; - char *next; + int size; struct dma_page *page; struct dma_pool *pool; =20 - next =3D buf; - size =3D PAGE_SIZE; - - temp =3D scnprintf(next, size, "poolinfo - 0.1\n"); - size -=3D temp; - next +=3D temp; + size =3D sysfs_emit(buf, "poolinfo - 0.1\n"); =20 mutex_lock(&pools_lock); list_for_each_entry(pool, &dev->dma_pools, pools) { @@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct = device_attribute *attr, cha spin_unlock_irq(&pool->lock); =20 /* per-pool info, no real statistics yet */ - temp =3D scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n", - pool->name, blocks, - pages * (pool->allocation / pool->size), - pool->size, pages); - size -=3D temp; - next +=3D temp; + size +=3D sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", + pool->name, blocks, + pages * (pool->allocation / pool->size), + pool->size, pages); } mutex_unlock(&pools_lock); =20 - return PAGE_SIZE - size; + return size; } =20 static DEVICE_ATTR_RO(pools); --=20 2.30.2