From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 314ACC3DA7D for ; Tue, 3 Jan 2023 19:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8ABBB8E000E; Tue, 3 Jan 2023 14:16:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80DDD8E0001; Tue, 3 Jan 2023 14:16:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 639368E000E; Tue, 3 Jan 2023 14:16:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 491A88E0001 for ; Tue, 3 Jan 2023 14:16:26 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2EE9740B75 for ; Tue, 3 Jan 2023 19:16:26 +0000 (UTC) X-FDA: 80314443972.13.0EBD9C5 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by imf12.hostedemail.com (Postfix) with ESMTP id 5B13040005 for ; Tue, 3 Jan 2023 19:16:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=W7drp1G3; spf=pass (imf12.hostedemail.com: domain of "prvs=4367607b20=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4367607b20=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672773384; a=rsa-sha256; cv=none; b=BrmZ0yRldAQjDqEbGzR0v10zhBIeEOokndhH0/uVdHzG35eYzsZB0dMR7g+mVyRhfYMTbM Io8nJDtWKHXowEgrt4PrxkcwMEEdphKAl3s0njf+PqVmCp6+1aEFvBEzDGUhi+3L4A+KS7 WZLt3MPm+NFRYPw8yDKWjqaT+mQhKkY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=W7drp1G3; spf=pass (imf12.hostedemail.com: domain of "prvs=4367607b20=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4367607b20=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672773384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4vF82BWEqxBKkQknzp3N1SGxBDFI+587r5lj6iGRioE=; b=BtEARVyKdLml4CkLNOQ0tXP/vZ9F7Ns8Ly+baAQwcWur2AgP0CY3zyHuWFbzvgPlO78dAY UMMT2pq7ql+5jKyaBBm5Y8NcsEb5EebVLDRt4Vibh/jlQkRLsymUMgX5sC+ZxkWZ8fgj9U 3qGzbxS/edl2ZfunQNR4NB21aCiinO4= Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.19/8.17.1.19) with ESMTP id 303IGE6s009019 for ; Tue, 3 Jan 2023 11:16:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=4vF82BWEqxBKkQknzp3N1SGxBDFI+587r5lj6iGRioE=; b=W7drp1G31q2A8YZXGiuHPW15tyy8FmzSChFaIlpYEPSTwiUgnKKEYYGO4bM7BjVNVj4N TY30UuhiwqRZmR3Yl+43quKXJC+j1M6Hqr8aga6uRYM+5MmMRSKwEoPt6N15R3zzWCwE GObl7RUpLHxm989ZWdK8WWXOo0GG64GbFsL+yvYjtjq+VPosePoZtB1axDB5kb0nGGhM q5zbuav5cwz2wmNWyTDZXPTtKQRuugNRngNlz7dwlzcdbGdm7y48Atn/Ve83egwcX2oY Gc/ilIip37gg8tK+C1ENyS47b5XZ6Wc5S4t23evmBL7rvHLHtDu62Bm/RfSXI05lSI0G Rw== Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net (PPS) with ESMTPS id 3mthn4aefr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jan 2023 11:16:23 -0800 Received: from twshared41876.03.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 11:16:22 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 6D499E1F5E20; Tue, 3 Jan 2023 11:15:55 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox , Christoph Hellwig CC: Tony Battersby , Kernel Team , Keith Busch Subject: [PATCHv3 12/12] dmapool: create/destroy cleanup Date: Tue, 3 Jan 2023 11:15:51 -0800 Message-ID: <20230103191551.3254778-13-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230103191551.3254778-1-kbusch@meta.com> References: <20230103191551.3254778-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: 9Z6De_AUmEvHUwZ6fDeoPweHCEiJp2o5 X-Proofpoint-GUID: 9Z6De_AUmEvHUwZ6fDeoPweHCEiJp2o5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-03_07,2023-01-03_02,2022-06-22_01 X-Rspam-User: X-Rspamd-Queue-Id: 5B13040005 X-Rspamd-Server: rspam01 X-Stat-Signature: oec87tncwfcaxpw9ubeqpixiy6ie97zj X-HE-Tag: 1672773384-450991 X-HE-Meta: U2FsdGVkX19wi+9ViJPzhIEl8mAY4/rNwwrHnYLHmiTY0xivQHwPEHUpqxZPNDW3chEYUAWgd2kib2xr/eDftNILDEjpYe8kn4H3+QNdGyL7nANrQexo0gLDiDcBpk1Gkb6rfgw1al8bu+mcLo7Yoe+CneS9Vy/K97fjMT0RqPlZlN69rSgkttlUwydkROc1YTiCvlV+rzIW+mnaRH0uXKJh5bHGbrr81oiLihRC0msY+Fjeec7Eusjd5vQ1MqoS/Df1LR2WhI0PiPfiUUtJK/Pq9uObysRlQh7gFTah7M7ksgG1YslwGiCzOHV7ye7jjV0lGm20wJQa9X+RdUx11wByTyxvuX9jRjIMSRCF+dImoFQShbl6ksc8XmMpHhFBX+qo+CmHE7ebM/+MCz902M4V44EPGouyKW8U39nhAxepcQMIJ2HScZUo3bMeUpY4Qx8niO8T57iHhcHlh1zvtNPKW2EQ9vSKKDE1HKCaDiq1FcCaKcakYqjEAUIgsBhpmlXSUZVgvejhpsHf5kCbz6DbrERZle3A2Vgk/pRl24R+2KcrvgYYJ89k89RtPH90CXfgVgazbOH1OMaN3y2WNLPsubIApX0b9qsF2h43l/uAQF7YLNpENznQEUZbeuTnwqCfs7l3KUp9+WKW2PTMtXrRF4VoaJ0pX2qUgWjQNB3X6TS7MZniWfKoFWIrd5lhPVhreitmF8ezg4absVphMqZJHDMUiHPWIC8AYcZJYNc456xu88jZmSNMsmPTud539VvjKw+did+gUWnoHs5KGok4WUXaVbM4nus3zGmYY6JqOMmIBkZAXsVkqdyYOE109NHW4NjNEXRvYtuyxEMvMFrGfVjfUvfNly2zcOs/jYOOVkeFj8c2qNukbXz954WXFbxOHePNZgeR+b0Ydq00jmthxmiFC6FdQh6ZIBhOUctPzmd/2E778Lzc9Q4N+nEK3lvEj+D6DRM7ez50KHC kjFvrPdi eZik4ri5jMG9DlTmBbw8gt6vk8yocClEio8a8dWhd+wP7SHmNwWHuyLNSEbhVcgy5hpYR1I5rSKeK9SlkHK7/IppQIjStCgSysdz4nbvIw8vUJPw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Keith Busch Set the 'empty' bool directly from the result of the function that determines its value instead of adding indirection logic. Signed-off-by: Keith Busch --- mm/dmapool.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index d23747a71bff2..db4de646a3a91 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -138,7 +138,7 @@ struct dma_pool *dma_pool_create(const char *name, st= ruct device *dev, { struct dma_pool *retval; size_t allocation; - bool empty =3D false; + bool empty; =20 if (!dev) return NULL; @@ -188,8 +188,7 @@ struct dma_pool *dma_pool_create(const char *name, st= ruct device *dev, */ mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); - if (list_empty(&dev->dma_pools)) - empty =3D true; + empty =3D list_empty(&dev->dma_pools); list_add(&retval->pools, &dev->dma_pools); mutex_unlock(&pools_lock); if (empty) { @@ -263,7 +262,7 @@ static struct dma_page *pool_alloc_page(struct dma_po= ol *pool, gfp_t mem_flags) void dma_pool_destroy(struct dma_pool *pool) { struct dma_page *page, *tmp; - bool empty =3D false, busy =3D false; + bool empty, busy =3D false; =20 if (unlikely(!pool)) return; @@ -271,8 +270,7 @@ void dma_pool_destroy(struct dma_pool *pool) mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); list_del(&pool->pools); - if (list_empty(&pool->dev->dma_pools)) - empty =3D true; + empty =3D list_empty(&pool->dev->dma_pools); mutex_unlock(&pools_lock); if (empty) device_remove_file(pool->dev, &dev_attr_pools); --=20 2.30.2