From: Keith Busch <kbusch@meta.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>
Cc: Tony Battersby <tonyb@cybernetics.com>,
Kernel Team <kernel-team@meta.com>,
Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3 12/12] dmapool: create/destroy cleanup
Date: Tue, 3 Jan 2023 11:15:51 -0800 [thread overview]
Message-ID: <20230103191551.3254778-13-kbusch@meta.com> (raw)
In-Reply-To: <20230103191551.3254778-1-kbusch@meta.com>
From: Keith Busch <kbusch@kernel.org>
Set the 'empty' bool directly from the result of the function that
determines its value instead of adding indirection logic.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
mm/dmapool.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/mm/dmapool.c b/mm/dmapool.c
index d23747a71bff2..db4de646a3a91 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -138,7 +138,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
{
struct dma_pool *retval;
size_t allocation;
- bool empty = false;
+ bool empty;
if (!dev)
return NULL;
@@ -188,8 +188,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
*/
mutex_lock(&pools_reg_lock);
mutex_lock(&pools_lock);
- if (list_empty(&dev->dma_pools))
- empty = true;
+ empty = list_empty(&dev->dma_pools);
list_add(&retval->pools, &dev->dma_pools);
mutex_unlock(&pools_lock);
if (empty) {
@@ -263,7 +262,7 @@ static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags)
void dma_pool_destroy(struct dma_pool *pool)
{
struct dma_page *page, *tmp;
- bool empty = false, busy = false;
+ bool empty, busy = false;
if (unlikely(!pool))
return;
@@ -271,8 +270,7 @@ void dma_pool_destroy(struct dma_pool *pool)
mutex_lock(&pools_reg_lock);
mutex_lock(&pools_lock);
list_del(&pool->pools);
- if (list_empty(&pool->dev->dma_pools))
- empty = true;
+ empty = list_empty(&pool->dev->dma_pools);
mutex_unlock(&pools_lock);
if (empty)
device_remove_file(pool->dev, &dev_attr_pools);
--
2.30.2
next prev parent reply other threads:[~2023-01-03 19:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:15 [PATCHv3 00/12] dmapool enhancements Keith Busch
2023-01-03 19:15 ` [PATCHv3 01/12] dmapool: add alloc/free performance test Keith Busch
2023-01-03 19:15 ` [PATCHv3 02/12] dmapool: remove checks for dev == NULL Keith Busch
2023-01-03 19:15 ` [PATCHv3 03/12] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2023-01-03 19:15 ` [PATCHv3 04/12] dmapool: cleanup integer types Keith Busch
2023-01-03 19:15 ` [PATCHv3 05/12] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Keith Busch
2023-01-03 19:15 ` [PATCHv3 06/12] dmapool: move debug code to own functions Keith Busch
2023-01-08 17:06 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 07/12] dmapool: rearrange page alloc failure handling Keith Busch
2023-01-03 19:15 ` [PATCHv3 08/12] dmapool: consolidate page initialization Keith Busch
2023-01-08 17:07 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 09/12] dmapool: simplify freeing Keith Busch
2023-01-08 17:08 ` Christoph Hellwig
2023-01-03 19:15 ` [PATCHv3 10/12] dmapool: don't memset on free twice Keith Busch
2023-01-03 19:15 ` [PATCHv3 11/12] dmapool: link blocks across pages Keith Busch
2023-01-08 17:08 ` Christoph Hellwig
2023-01-03 19:15 ` Keith Busch [this message]
2023-01-08 17:09 ` [PATCHv3 12/12] dmapool: create/destroy cleanup Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230103191551.3254778-13-kbusch@meta.com \
--to=kbusch@meta.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tonyb@cybernetics.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox