From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2BDC3DA7D for ; Tue, 3 Jan 2023 07:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 503B98E0003; Tue, 3 Jan 2023 02:51:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B38A8E0001; Tue, 3 Jan 2023 02:51:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 354328E0003; Tue, 3 Jan 2023 02:51:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 260FC8E0001 for ; Tue, 3 Jan 2023 02:51:03 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F184AC0486 for ; Tue, 3 Jan 2023 07:51:02 +0000 (UTC) X-FDA: 80312716764.07.592553C Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 8B8C140004 for ; Tue, 3 Jan 2023 07:50:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=OFk5vCvK; spf=pass (imf17.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672732260; a=rsa-sha256; cv=none; b=6NTLFfqhfs3yB5EzKxcLwsx4b5DqEJy1bzO8eaStYBaYa3GGO+XLdnP9nab5g01YFNL/mS Iqy3DjxLgQiSFzvuz4fD7P98g+bpstgbvj+WrtbofOgSMnp+yGGgCXcVwwqSDTDgVmkixD lxtkt5KAfgGmkonKTv5HGA5D2EgKD1Y= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=OFk5vCvK; spf=pass (imf17.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672732260; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UN+4QdP10C7vIuKX4Eh8/LWwOKBNyBebpbBsufTIiuk=; b=AV7WSqU3tQrhz1i99+zaABAeYNosK414npmsDO4ncZRJdzAU4KW7atC62E+vvpgGLjXpB9 JOIh3QYc0DM4aWbdQi80ddo3cLprgOK49W8XxXMqfN2c2Hvm51BL9kYTXb2M+WwwCQJXjz GR6xQJ7q/OLgLNMp2bl/oYEB44TYOic= Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230103075056epoutp044036e0d60a313ce801e52b62631275bf~2vR-XNy_a0204502045epoutp04O for ; Tue, 3 Jan 2023 07:50:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230103075056epoutp044036e0d60a313ce801e52b62631275bf~2vR-XNy_a0204502045epoutp04O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1672732256; bh=UN+4QdP10C7vIuKX4Eh8/LWwOKBNyBebpbBsufTIiuk=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=OFk5vCvKGA3aePJKpFFuUDQEPGmWjbAtc7tx+XOCQRXK+a4q18DaLN3Hykr8DRIBw lEYxJ4/+XZE5Ya8tjfqtCrNkKjJ9RMRHIx1m/wNCDF9GqOkbVyQJa0jQrA21vOv+XO R/yPw9z4t/0aOj4r/DKlJrGBcxAJ+eqRlmVNM7gY= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20230103075055epcas1p400c80b8ca07cf14cdfbb4b392bd4e78c~2vR-HOCkB0794907949epcas1p4G; Tue, 3 Jan 2023 07:50:55 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.38.249]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4NmPzz3770z4x9Px; Tue, 3 Jan 2023 07:50:55 +0000 (GMT) X-AuditID: b6c32a39-7eb28a800001a220-8f-63b3de5f1002 Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id D3.E5.41504.F5ED3B36; Tue, 3 Jan 2023 16:50:55 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH] page_alloc: avoid the negative free for meminfo available Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim To: Lorenzo Stoakes CC: "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "mhocko@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230103075054epcms1p308aa577d10429a2e0e6167de510be6b6@epcms1p3> Date: Tue, 03 Jan 2023 16:50:54 +0900 X-CMS-MailID: 20230103075054epcms1p308aa577d10429a2e0e6167de510be6b6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKJsWRmVeSWpSXmKPExsWy7bCmvm78vc3JBjuvC1rMWb+GzeLlIU2L 1Zt8Lbo3z2S06H3/isni8q45bBb31vxntbjzbR67xetvy5gdOD0Ov3nP7LFz1l12j02rOtk8 Nn2axO5xYsZvFo++LasYPT5vkgtgj8q2yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0 MFdSyEvMTbVVcvEJ0HXLzAE6TEmhLDGnFCgUkFhcrKRvZ1OUX1qSqpCRX1xiq5RakJJTYFag V5yYW1yal66Xl1piZWhgYGQKVJiQnbFleQtLwTOeik89i5gaGOdzdTFycEgImEhMPhfRxcjF ISSwg1Fiw/f7TCBxXgFBib87hLsYOTmEBQIk1v+8xw5iCwkoSZz9cYUdIq4r0dS9mgXEZhPQ lni/YBIrSKuIgIbEixtWICOZBbYwSVw+uocNpEZCgFdiRvtTFghbWmL78q2MIDangLrE75lH oWpEJW6ufssOY78/Np8RwhaRaL13lhnCFpR48HM3VFxK4lz3cSaIVyIkXuxRhwjnSLzfOYcV wjaXeLahhR3iK1+J//s8QcIsAqoSh/5egproItE3/yDYZcwC8hLb385hBilnFtCUWL9LH6JE UWLn77mMMI80bPzNjs5mFuCTePe1hxUmvmPeEyYIW02i5dlXqLiMxN9/z1gnMCrNQgTzLCSL ZyEsXsDIvIpRLLWgODc9tdiwwBQescn5uZsYwelTy3IH4/S3H/QOMTJxMB5ilOBgVhLhnfRi U7IQb0piZVVqUX58UWlOavEhRlOglycyS4km5wMTeF5JvKGJpYGJmZGJhbGlsZmSOK9NxLpk IYH0xJLU7NTUgtQimD4mDk6pBqbw7hVvroefTmg4sOxoBlv2ReMrv/VPfdn0LvrpxAWvJs1a f+biwhU1tbG3Flvw7v5xPymwkOvvxuCe3itdqw2/Gkwzyz37pXN+5+mOtl8rpszzsXnjfGFy yNTXTc3Tjuw03MyTtSbBPplNUnGmvt0DJU0fuUeTGFs3hL96+s18ScZ2Xg2t4o13cyPMg/c+ WvD1TeNFVcaFV6JCPsx13rawUS2g/fm3yas9XBny394o2tV9zPLqgde3d65tXZUZvSzlv3q7 /uJyiae8y24XRO3K/r3muKpF3ZU21bW/Xn1aKW/BL6h/3miG2t4DX1a0MbpypMsvO/6XZ7tS 3jy2KJ6fC0I8zqxkZsxNeqAoIRwWqcRSnJFoqMVcVJwIAEZ/ai8oBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230103072834epcas1p3441ef50a6cc26ac48d184f1244b76a0e References: <20230103072807.19578-1-jaewon31.kim@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8B8C140004 X-Stat-Signature: ky43qat5teg76wsphzuaqkyytef5mop4 X-HE-Tag: 1672732259-906047 X-HE-Meta: U2FsdGVkX192yvHIwohzyd9FOsa7z1XlWWeJVVFV8zJemN/lSBojP6pTds4BW/w8xc1Kg+RqCyxQk1Sp+sd9TfTrcpjL41NGMbZuUFKfUAZ690F81yMdVfXUoGKffbwqJoP2BQnUxzo8LLtfiP4FQCDt4xYEoEdL6GrEQ1uZBEB4sibYUFql0dMJb43TY38EUl3JZ2tEOq31K52/WMIdR24pt8s1ohbAINXL1N9KvvJeNWZIKASW0j6VfAbgsMTYlJ2+iSTAySmQgdPDHhvKVoppKDwmXXZ7mlcah8/UmNyK2eH/kizaoqde30Tgg9kXIoVNGxnfls2qXxpwtOW58RWbJRbshvhVFpBnwxyn0K0HGH0K626vyLMFO4Bz9hLNoZMXzN9XUmm1iNsqXiCBV7xUP+sA6mh9xmusSJuipiSuUX/UT9MsJqcSCIzKMBzW3hwrA8zFRAemQCT+k9cRc26gav+Bxkp13SsbN2r7b1nG2LGmtHQbot9EV2dASE7Kqa0BjmLA4E6LVNJooVqywOFwx8CYvdR5cjFG1CnreLCV0DRFjGRQipkzic2u+bytYmjB3OK/XfUQecMx6v7YkSOTUvZkf4GLFz9L0jIIMiDqDbLqt0K3HX9pm1a44M0TuVRpZd5zT8dzXXW5VUeC6NtFQJvUFWBMiCdq9DWv86zpJAvxShkgOCaKVeGawr9nzafo57VtmWYIOQ5ORocmyEXJx/CA8bGrT1NToa7poOhPqNZwP2fHlAqv0Nt1PBNVqUJUSXfsLbpiM037eIhPpZaysBdcSbxDtqMQYX1iP+UnVBwX1+8PzYMwooyCnuJBumyxYpy4byKjF+Ph66UCRenRsHnxqph5wCO5FpG6knTIBWqSvOZQ/7rvQyEh8WUJZNYLvMm3JV3IXQSDVbCCBD+a/wHnsiLY6JCkVwwNU7FaEqQxiPC2ExNofsw947XMYbFgOoh8fI10zTdSAf7 WJ4l+9XI ZcttFcBuOV62+zVRYMIohrxr9Xbk7KtYLMSUA06kcTZ6bH32NDepZCX+mq89ZZRIJZYT739WfWtvOlO1wqD7modIEAFQOvOgN20mPs0zMi7KwptwdGYTqu/0KWaASuqy8hLtlM3THmbjGnhXxpCT6hP08SC0a/Qy0UGTHXpNZ7KBWdpU5gZMcwAMuEwlN1ILYKKb1PIvPR6SN+P9rnodW/PUifSrCaQZEtro1l7FNnReEU6qkA7Yi046BCtXpC1Vn3RlwLr4kan9uCFWSB5zGp8/VcP9qG+XKU8nWLxs9FGxC68k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >--------- Original Message --------- >Sender : Lorenzo Stoakes? >Date : 2023-01-03 16:35 (GMT+9) >Title : Re: [PATCH] page_alloc: avoid the negative free for meminfo available >? >On Tue, Jan 03, 2023 at 04:28:07PM +0900, Jaewon Kim wrote: >> The totalreserve_pages could be higher than the free because of >> watermark high or watermark boost. Handle this situation and fix it to 0 >> free size. >> >> Signed-off-by: Jaewon Kim >> --- >> ?mm/page_alloc.c | 2 ++ >> ?1 file changed, 2 insertions(+) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 218b28ee49ed..e510ae83d5f3 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -5948,6 +5948,8 @@ long si_mem_available(void) >> ? ? ? ? ? * without causing swapping or OOM. >> ? ? ? ? ? */ >> ? ? ? ? ?available = global_zone_page_state(NR_FREE_PAGES) - totalreserve_pages; >> + ? ? ? ?if (available < 0) >> + ? ? ? ? ? ? ? ?available = 0; >> >> ? ? ? ? ?/* >> ? ? ? ? ? * Not all the page cache can be freed, otherwise the system will >> -- >> 2.17.1 >> > >We already reset to zero at the end of the function, wouldn't resetting to zero >here potentially skew the result? > Hello I did not mean the negative of the final available, we should account the actual size by removing some improper portion of it. The free should be not negative in that perspective. If negative, other parts like pagecache an reclailable would be decreased. Actually pagecache and reclaimable are caculated with min, so I think reseting to zero at the end the function is not necessary. br