From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD487C46467 for ; Mon, 2 Jan 2023 12:15:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541648E0002; Mon, 2 Jan 2023 07:15:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1328E0001; Mon, 2 Jan 2023 07:15:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E0618E0002; Mon, 2 Jan 2023 07:15:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2CF508E0001 for ; Mon, 2 Jan 2023 07:15:52 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 028611A08D5 for ; Mon, 2 Jan 2023 12:15:51 +0000 (UTC) X-FDA: 80309755344.09.A7E00C1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id 473E8180012 for ; Mon, 2 Jan 2023 12:15:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Vdfb5kx7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1syY9TgP; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672661750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7p+1CYr35IMfZeXzMv9mW+b7Hyipf7RXjCQLefUwxuA=; b=dsdaAjSvBHP6zRODiu3rxdmKprxpRrF7pk2NuRcoVhB/KPjdsM8NOUVt7Aen2lUepR9cmD MnjN3BeY/xWNvXxSMnkuHi+AfWrq1xg/8YTDSEXlrnziM8D4yrBz2+3HxOQZd+viaahh35 xWAzMx/0xBLX3HpjWnBQDZC91xGRNQA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Vdfb5kx7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1syY9TgP; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672661750; a=rsa-sha256; cv=none; b=CVu2h2BgIS5S7jRGQQ8JQMe8L+eN7r4gcIr/axWZQI3r74BuWq+b6WZ2vgiQhcPDT8poKL QkOathGSzbFGYnhsn5kFkClRgavizo8pnest6GdDVJzDu/3/6tm6Ei7+ze4ticYPAMTyq+ zHIw1f6h0Jv1hTj5c843ma8gDholWTA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 16C32340CE; Mon, 2 Jan 2023 12:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672661749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7p+1CYr35IMfZeXzMv9mW+b7Hyipf7RXjCQLefUwxuA=; b=Vdfb5kx7HXP1I4jfRVpYYRPbixX/OUrc798QzUyANCeCVUgrahv/iTI/auD/sNIdXdZSKb iI9TexVwDI77ARJL7kqzT3x7diyi2vgNz2rlIqnwPLKMMvZYqRyaCIEGL08IbqgzEk/L08 dTV7Fs4vSHI6NTBRRthFFsD9cE38F7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672661749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7p+1CYr35IMfZeXzMv9mW+b7Hyipf7RXjCQLefUwxuA=; b=1syY9TgPoXIKMrutE+opNx6jC7wdgkUilzJMOgw1RjxHqG/Pa1+Zaf2Sg595NbauTyu4SI CB/VK0K3JpeupHAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 05C39139C8; Mon, 2 Jan 2023 12:15:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b71oAfXKsmPSCgAAMHmgww (envelope-from ); Mon, 02 Jan 2023 12:15:49 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id BEB2BA073E; Mon, 2 Jan 2023 13:15:46 +0100 (CET) Date: Mon, 2 Jan 2023 13:15:46 +0100 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Theodore Ts'o , Jan Kara , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , "Matthew Wilcox (Oracle)" , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org Subject: Re: [PATCH 5/6] ocfs2: use filemap_fdatawrite_wbc instead of generic_writepages Message-ID: <20230102121546.fqpy55koaavfazm3@quack3> References: <20221229161031.391878-1-hch@lst.de> <20221229161031.391878-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229161031.391878-6-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 473E8180012 X-Stat-Signature: 3ewndpzmpf6knixfp3113heak7dzomia X-HE-Tag: 1672661750-48137 X-HE-Meta: U2FsdGVkX1/v5Tktow/2P17S6jMd2wDfodyl5+2dkomexlEgY69QWOgu0c94Zp69Wv5C0JcVL5m/KHgF+LvGnIFnG09r/L5mDCUwbhW+gcdVPLpXmRr/Fg4XKBXms1GcUeWFexIarVpHcdK+lvgGoTg6a0tSvgy2cD5/+bFhUvjt2A9zttW8n5MAl/1yGoN1g1kumJWSFNMsYm9MhbbWF5q+LGeV/S0yCrKwoA7rxVyhEARZDdO8UF8b2ufixLpVp8ViBiAbwHsznqLtRIQttjffveB7pXNDFZrdJmadL9JxxzWs4uFcrN5aPbIWxSpF3hJUi6cOLk52Ob+aAsytBXUy1cGlXsEzQWd/Xaqc7riFQuCjjRN5iEESnzepDrrLQ3MRC9gubIkQ8Y3okVEc/xwWO92rQ1f1SZ/BsjLQSKYc1Ku/blSp1whL2Y89p6BfRXsM8OtSivIaCU0u4NASiJZl1ueZlQKQzzB98zSm+72TPt0lFeeBGhG+ElGgJBtFmyfBYEQzxGQqoW0K5wQuqosHD2OHRLNn4UgszpsyYlYcTlsLzEmWUTJR7ynhhm1ex3SWoSuw2t9zjS6ZiAENivq3N73OW4SqpkhDjzXZKJgKUxQmW6E5Kzifnftm2ZQJEzib7KCzVSvvL+5i0p1cBvZUXwZX+FIlUyFaBEkVUjK+R/Nf8we+4e2JNybn9rWMWpMOQrsoPwde4oOPTn7zLDXJmOEDfwdko8aX4Gs5P3/+kGl28RK8TwvULSCdhLp6a41Wpy6xbwrPhsgIHYGmiKRJcPnrqHy+ko2gH2BCxIbTv3WSb7+FhtAeERSNWJApO4oenl0PjfXMONDNlelXLR0NBmPcNfLX5kb5niwrnj4fpDjXcDI6qkToq1wqMTqNGhj0/HfmuqJqhGAaMnocHfs2PN01DwiUu6KXGYCPjqfthYMCxZMxf+js4jGTwRuch02+MAIGOiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 29-12-22 06:10:30, Christoph Hellwig wrote: > filemap_fdatawrite_wbc is a fairly thing wrapper around do_writepages, > and the big difference there is support for cgroup writeback, which > is not supported by ocfs2, and the potential to use ->writepages instead > of ->writepage, which ocfs2 does not currently implement but eventually > should. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ocfs2/journal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c > index 59f612684c5178..25d8072ccfce46 100644 > --- a/fs/ocfs2/journal.c > +++ b/fs/ocfs2/journal.c > @@ -852,7 +852,7 @@ static int ocfs2_journal_submit_inode_data_buffers(struct jbd2_inode *jinode) > .range_end = jinode->i_dirty_end, > }; > > - return generic_writepages(mapping, &wbc); > + return filemap_fdatawrite_wbc(mapping, &wbc); > } > > int ocfs2_journal_init(struct ocfs2_super *osb, int *dirty) > -- > 2.35.1 > -- Jan Kara SUSE Labs, CR