From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877D2C3DA7A for ; Mon, 2 Jan 2023 12:13:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03AAF8E0002; Mon, 2 Jan 2023 07:13:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D5F8E0001; Mon, 2 Jan 2023 07:13:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF4E78E0002; Mon, 2 Jan 2023 07:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D05808E0001 for ; Mon, 2 Jan 2023 07:13:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 96AE4A6C42 for ; Mon, 2 Jan 2023 12:13:30 +0000 (UTC) X-FDA: 80309749380.01.661D3B9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id CE6B84000A for ; Mon, 2 Jan 2023 12:13:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O3X5uNr3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aB8cuOBt; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672661608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tLH69wvDgw4zlrii5ssfaa8PJzW+0Xgf+S3GjAQjclc=; b=inyT/exYhg8gePoe52zmp/gdt/yaT86MyuIkfzkxebX1DdCn5Y329FHd8ZLXyA6FzEgLYM PrfJUdy57zNv2CGJ7R65Dhc3wYjsKAcla6TC9/eMOl3whLO8hma7u5jbl+buWWITXPcgER VMWSeInU+rpvm+U2hbFz/HhD9pPw2B4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=O3X5uNr3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aB8cuOBt; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672661608; a=rsa-sha256; cv=none; b=uQk2pMbubHGZkFfVXijTH7UGD9907jpADaOf5gnMea7CDIESc+nILZMN2ziDpBC62EjRuA zBuQu3yEUdbE95IUlKOJyVzJJ7ytQh1aTehdWYY2hb2ysuCjiFsE+OxaA3EDyCp+ltH9p/ C+ah/uw4zNpsVDHjt5USjk5AjhdP42A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6097A340C4; Mon, 2 Jan 2023 12:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672661606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tLH69wvDgw4zlrii5ssfaa8PJzW+0Xgf+S3GjAQjclc=; b=O3X5uNr30fACrbTuGy88BO/nRLzdSVEm2bxn/xKiI+MpkbqJN5mRMd7HJ8HvLHcTYgjnul T1kABhab6ZerssRLV+082h0drbFI0NxPisaG4yhBbgoUD7mZ3K5JF5IzFQSqBa4eM7UCjy zsC5iKSZreJNKK8xkH3kwsC2ep5D8lg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672661606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tLH69wvDgw4zlrii5ssfaa8PJzW+0Xgf+S3GjAQjclc=; b=aB8cuOBt2GCeTl1/MOPlOVFJIPokVJ83QnUy+vrqechFA1EvlGXkDRJFBrSsx+awFiQdU7 tAP9c4Iwzy8UA7BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EF21139C8; Mon, 2 Jan 2023 12:13:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 12o6E2bKsmOoCQAAMHmgww (envelope-from ); Mon, 02 Jan 2023 12:13:26 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id D6987A073E; Mon, 2 Jan 2023 13:13:25 +0100 (CET) Date: Mon, 2 Jan 2023 13:13:25 +0100 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Theodore Ts'o , Jan Kara , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , "Matthew Wilcox (Oracle)" , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org Subject: Re: [PATCH 1/6] fs: remove an outdated comment on mpage_writepages Message-ID: <20230102121325.swmgrnjgvvnxz2fh@quack3> References: <20221229161031.391878-1-hch@lst.de> <20221229161031.391878-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229161031.391878-2-hch@lst.de> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CE6B84000A X-Rspam-User: X-Stat-Signature: jex1s754ephd9gu5hggwebe1ru9ew8z1 X-HE-Tag: 1672661607-836259 X-HE-Meta: U2FsdGVkX1+CqWDbRQGVufF3/7Afp2QoasKMkBeZploAPZX5xcR/E8fz/Uh880+0u+UO7wBOv5Wp/hSMyjpIBr4MegX0a0miXbjrZLveVqrbrylU27Xw4zGfd/XGkXKFxcOpJCxN65xaN2RH0CgMG6jN7151zEE5y98lkiVR64k6uN6vhYNj+bVoCkOKesv4BKO+8oL8vuwAan3YPM/ec35HEQw0531E77JASpYrA6go8OdxVVi2V7e16II7MNJpUnXaow2DEIiinouNymv67eQh6NwkvY+bHwODk/u/uk7rwdEPPMPYT8CXm5sy1oFMLu2WJqMQOjWqM9nVWzd1iwyQyQpTDRRhGrafq9t+AXqEa3nozZzMQJFu2kzD7xFdHLqb5rNU8brDGv5Gft/PrOCc40keMQSjv/0vxX3mPIPwapq1Abh48Iea5iQnED5l0BgTqfb8OxvKoICGXEZhm0n++0eSPA1/H+lIw44hpN+LRmBCyrYLtEebj64J4ULQYPcMPQ02axCo5Qk+sbyQtn2QlAdNzQpSVh8PiwX844ro/LkqbcVmyL7GsiCNuYmf+klIreZsz7fsaJHv2pqZ4vZWFhDlV1ihOoMlFcwcdKK7la5wExO6L5PUAiy17JeqzZAZRFZmW1kzvZ9uaMNsf5LfL3PMMJwJSL1sC9TkmvKNLsWYSMFaU5geUHF26gbSl0GHTQRz9/lCz4fhYAL+ml5Hs++qOCKfdDV3NeWo1nN0dQexnJCK4iYL+bcaYq0I4KvRpl9lVQH464NA9MN6iTzo7EEwSeny8Xh1JaC9EEZcggAam6FdAcC6DSJg7N7jRpoYcfeQX/+Ys6m5vlzFm6b75wZv5klEloDE0XhfwHRUC2toDxeBtibGNe8e383MEHq72K1rfZ2ra3AC63oeUA7I/f0MU7kbwjuz2zEVoVs79Eho+AJuG3I3QKz3S6av8xiZOmUAhIM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 29-12-22 06:10:26, Christoph Hellwig wrote: > mpage_writepages doesn't do any of the page locking itself, so remove > and outdated comment on the locking pattern there. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/mpage.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/fs/mpage.c b/fs/mpage.c > index 0f8ae954a57903..910cfe8a60d2e4 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -641,14 +641,6 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, > * > * This is a library function, which implements the writepages() > * address_space_operation. > - * > - * If a page is already under I/O, generic_writepages() skips it, even > - * if it's dirty. This is desirable behaviour for memory-cleaning writeback, > - * but it is INCORRECT for data-integrity system calls such as fsync(). fsync() > - * and msync() need to guarantee that all the data which was dirty at the time > - * the call was made get new I/O started against them. If wbc->sync_mode is > - * WB_SYNC_ALL then we were called for data integrity and we must wait for > - * existing IO to complete. > */ > int > mpage_writepages(struct address_space *mapping, > -- > 2.35.1 > -- Jan Kara SUSE Labs, CR