From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F3BC4332F for ; Fri, 30 Dec 2022 21:45:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FB4E8E0002; Fri, 30 Dec 2022 16:45:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 983E48E0001; Fri, 30 Dec 2022 16:45:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 824AF8E0002; Fri, 30 Dec 2022 16:45:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 703298E0001 for ; Fri, 30 Dec 2022 16:45:41 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3D7C78017B for ; Fri, 30 Dec 2022 21:45:41 +0000 (UTC) X-FDA: 80300304882.23.AA85ACE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 909B820007 for ; Fri, 30 Dec 2022 21:45:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QZEU0Xf0; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672436739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=77TGjesLms8GJlPT18Lts6DxutB1PQryHVXZeNmikq4=; b=ntlOhjcfYHfcy8KEOD+/UkjGVEO3IITKEi1mVQB6SWw53j2Oh+WFHEARfF4+Z9jop6Z1Dx hQzJPaxXYsnm8jxdLcIhhIw0r/rF1I86DW3ZSrOEj+qf+EvhEtGINoJpsEr6C/yD6kL0M7 VpjPNlppt8le0mYS1sdialkqEu4nZgQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QZEU0Xf0; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672436739; a=rsa-sha256; cv=none; b=3ylVxrz0SuEyoEiTCcVfKdLERIlifQR6oSNlTOUGMiDAoGLcaPnnxuaic0pb5PxygKte/2 9hm/hEdry4YFZ3OZ0yasaoknnVAe/CEO9GIawp1aH6m9StDzjvlddE2Zt5AGyuVMkTdBlx nSYGCwjmqbAaRewWUoiGDp0iHiuwJIg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13855B81C22; Fri, 30 Dec 2022 21:45:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A096AC433EF; Fri, 30 Dec 2022 21:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672436736; bh=cVumx4Nm/N9nn3OVGA7It+mlETPOyLHvs1Havnr2L+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QZEU0Xf08tqRC03cMUp8ZVX2PqiCbdTTp/+3KWjVK6nFZli66GShQzIkgdGTev7A1 97qHlLG6zRpYCC30idfLCXk3IWs+OGJwp+KQxv1Frl7MFtMpI65euANI7IqJx4ev2m mI9fkU9sqboXIdOLqXkFAhCPyrE6v4yfTjbVKXRs= Date: Fri, 30 Dec 2022 13:45:35 -0800 From: Andrew Morton To: Kefeng Wang Cc: , , Subject: Re: [PATCH v2] mm: huge_memory: convert split_huge_pages_all() to use a folio Message-Id: <20221230134535.240f49e0ad8bf6d82f8cc393@linux-foundation.org> In-Reply-To: <20221230093020.9664-1-wangkefeng.wang@huawei.com> References: <20221230093020.9664-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 909B820007 X-Stat-Signature: gfu9ayk8er6xfpw7wutf1n4pdcw6uixq X-HE-Tag: 1672436739-177780 X-HE-Meta: U2FsdGVkX18BrK5/vDbsgpt3ep5FT8yJJDCz4w3rLV815SuT36CXWTgAvQ+TyGx5STwjy6pWdB20tI33UCAkbuqQ9YTBh2YqhZZS0VanCMTQYNRyJ9ot7STSok8d4Z64GhwA/UkbOi362ry+42sZQoB0ALwgXIg8UQj3RU33t2FawGjK8aQZx3jQg1T3PZ2hEVkFa4//rY2SXl6rAn8DVn6Tm+KiXGRmSCR7ltwLz1U9RfZJP74w27AtxYlqoLbGMEgQc5Meq3nKlbBAxik7ltTm60iFeLaevaX1nwZDvvlL/DToRbQglvLlUR/T53E38tYtPl9jYafnOdXm5LHhMVFAt2z57jmhgHxMmXot4gT/rjTpPRk43sbcoA6MU2dj85XNRBQ1kz1HX4VvcbVaA5VMabOZ+eximSBfzK5f/ZOekmVkwMTU8qpJtkrr+n+cw0aTcEZtZ+C66CY6CW8TVCSJc/G5B7FBauGVKgEs3Wjn3syVsJC9dh1SLjYn+Beubs1wSgPsnGkzXXjBGHSUDtmXAE0Wo7zr2XGCtqMXNn6mFVD5Y3J2mtoX44fM5vvmdb/3t/sG/uhCfLWebJCxzYslIYg7BX9bJxmFIKwi2m6MJ4Q9oVU+QLwN5xU1utYuhFCwIzMYS+Z4rKrCTkSYTcSh7ZrcRqM2K8BGUzA3TUqryRRmc5wZwrJo/Hd8RENfymQYHRUkxALpHF9Z+Bo+NqygHv0Yi8npQ5+WLWNwxyTqb+hitISFg+xiUzK1TQhXpXZrxOTlizuuDt/j7h3M9ioSuUoehPxS/aeNTMSuk5Xvjk4Ia3LJL+N6aU35T7XDP7t3/SMf3waHue13N4LJjfCLnHRAr1oj+QvcRW4/H8frFo0lo569karkbLK5+gNd8dmbq1lyccIycw7uMF/Phcw31ZWNBV2jDIGlz0P+mWQ3kEiXpjXwlFS75AdlZV7CgvHiHNhrLBUrSBhG42V Fxhb83VT efBR6I9ANnOAiaOhgzDy4GJWRxiXDpyVJIRhZydqjnphtXtEAd/hmtllh1Hg8Iw1rhCvQQBoUXxvIc42rWfpqNHHk9+NG6Q7rsr6Chlk1u859+whlSChykK7riQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 30 Dec 2022 17:30:20 +0800 Kefeng Wang wrote: > Straightforwardly convert split_huge_pages_all() to use a folio. > > ... > > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2932,6 +2932,7 @@ static void split_huge_pages_all(void) > { > struct zone *zone; > struct page *page; > + struct folio *folio; > unsigned long pfn, max_zone_pfn; > unsigned long total = 0, split = 0; > > @@ -2944,24 +2945,32 @@ static void split_huge_pages_all(void) > int nr_pages; > > page = pfn_to_online_page(pfn); > - if (!page || !get_page_unless_zero(page)) > + if (!page || PageTail(page)) > + continue; > + folio = page_folio(page); > + if (!folio_try_get(folio)) > continue; > > - if (zone != page_zone(page)) > + if (unlikely(page_folio(page) != folio)) > + goto next; > + > + if (zone != folio_zone(folio)) > goto next; I'm still not understanding the above hunk. Why is the "page_folio(page) != folio" check added? Should it be commented? > - if (!PageHead(page) || PageHuge(page) || !PageLRU(page)) > + if (!folio_test_large(folio) || > + folio_test_hugetlb(folio) || > + !folio_test_lru(folio)) > goto next; > > total++; > - lock_page(page); > - nr_pages = thp_nr_pages(page); > - if (!split_huge_page(page)) > + folio_lock(folio); > + nr_pages = folio_nr_pages(folio); > + if (!split_folio(folio)) > split++; > pfn += nr_pages - 1; > - unlock_page(page); > + folio_unlock(folio); > next: > - put_page(page); > + folio_put(folio); > cond_resched(); > } > } > -- > 2.35.3