From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8301C4167B for ; Fri, 30 Dec 2022 13:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC1C38E0002; Fri, 30 Dec 2022 08:21:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D71198E0001; Fri, 30 Dec 2022 08:21:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C60F88E0002; Fri, 30 Dec 2022 08:21:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B46E08E0001 for ; Fri, 30 Dec 2022 08:21:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D81F140EC2 for ; Fri, 30 Dec 2022 13:21:38 +0000 (UTC) X-FDA: 80299034676.14.2E6D700 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 088FB1C0016 for ; Fri, 30 Dec 2022 13:21:36 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THS0fZnV; spf=pass (imf20.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672406497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4jBApHay/Y2Pb+S9z4zvfVXmhA3MyKdi2+ZtE0uVCW8=; b=NB590cCCJx/XIKZbO89t8XJz8sOyZqEEuG5g3Al8ji+4arUSkKm0zCu0/8g/sYc4woL3tx +CWtxqyM0gMqvGU4JMZcrF55nHM9aAsIawNrZiJ2IslKfZ2d5IZp/vAC/wjnKEINkAkK2P mEu+jZLZh95fOIUTTWHa9AulHqBa/zk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=THS0fZnV; spf=pass (imf20.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672406497; a=rsa-sha256; cv=none; b=7qhUqSJ9pX73GQgkZ+7ytkBwc0XVl6mAyZoJHDjhFaXhzva212oMcK0vOumge67ZX+Ka62 6T3DlzIodnIePEUnO8k8h+FGdS0/VR38ArkYEFL2aIp48zbOkCkjO6rZRPV3zawfGUkxuW nHh7jMMv8/UbDONftfTnmW5jmiFR46Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF1B1608CD; Fri, 30 Dec 2022 13:21:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE49DC433EF; Fri, 30 Dec 2022 13:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672406495; bh=LqE9lGO8Ffb2OElWi6b389XL0OH0I74Q2AQefVosmI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=THS0fZnVtjfLfCQHzNCAc6pECMpuUj89rW0AM2Z/cFZfM9e1uAoot+UF/PuK3pjDy 5mN3bRt701/lD9nlTfxgBxQ8qdlUEpZTvs+sf4B83iiJOSBXesDac4Po1xGS5Knw4a CqohHqsBoCTPzufJvXaqJoujUbmwmBamvSjLR0dU7hDJx9z+AGpI0m2d8CgzUsYm9h GXIPeMGPCKitFCgifTpp3+KdDHWl0QyPn/TfhyNyTQYIysecm7O36Rn54g2JlSKH9w X8jBHpRrO8mWKSB4gQenha65v6lFBzkt9IkmcDd9AqmSIHx6xeQBZ0AUp0PkkRq3YI 5WceaFQRtxyyw== Date: Fri, 30 Dec 2022 14:21:32 +0100 From: Frederic Weisbecker To: Marcelo Tosatti Cc: atomlin@atomlin.com, cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v12 2/6] mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies Message-ID: <20221230132132.GA186035@lothringen> References: <20221227121137.102497574@redhat.com> <20221227121341.981235373@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221227121341.981235373@redhat.com> X-Rspamd-Queue-Id: 088FB1C0016 X-Stat-Signature: 1cczne9c94jaa37qbzjdwpnm5mdipt3m X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672406496-177493 X-HE-Meta: U2FsdGVkX1+E8J3eElTqKB6+rR/hh26eicr8fTVHq3SAerHPuvZ/Kah6dVeCWQ75UJnAKZlcV/XRK6CDYgoI0b4gIRMFA2sD7ztK+IykMyTzzYxH2aCBkqgM8wrfKRfIOj/5cgl8Ptr4q5xi35qq20ibvdQ/0Shag9AvwrqMK86S7+kh/uG3tFqyTOqybTwwqMYGIl/Np5ydWYtdXctFf6hiOQUXq/0qe4V783MCjKgtlrDPQrahgOxWP0O2KznoqMW8/PXodWFPXVb3luGE38O+pxgCmxs9yfaXZ0I4dijQOho164t/2tL5U5YD94wBusd0GiSpbRg9Sli8CPRjnqXZV26zZWUpL0sv4DrgOqRFLMwwJJctyrgl78bT+IQQN/B/ea9pHltAKN1Rak6fx+C3uhqibFitfTrdsScGQrSj6xY7Ox5PsDJYDUnl9FCagxeTXcJ08DybJcdbaxmS0SqJLAa6WiHjsvpgLf8hnosQ45HSuqftfx29Tt5j4lQhYarl7apd/SU3GUoV8ep0kzczXeuorY8jgkteyaZKo3E/i6lRcfQMFeI1HVTrJhZciBx22XZ8t/HCYyoc7NMjzq+w3D0Hxf+wK2ChYxTFCrknMdE4tZ0XWbnmwY99vr5jlU7h/t89Sg+80VTBl8Vui0DlgsIqybf3ddRs3TMJft8Rx0Ipj+k2IyCzpn0FoJya/rHsU5Qo+yfgcHiwHgrIWtRdpMgNJrr6igB5FWv7L5SYbGnllFn8gx5Q3EkV11DbaR3PBVHkZs2nZYrv7YsrtShFWB4haX5k0eQUM6z6URKH/COBRVkNWkKuR7rCNa+lSmflxlpRftIsTkuOtjE27Y3uG/93P/hHVqWdFiLRobnAlyFB1jqneiqNq1FILHY5DUAUdMfmxDwzwPQZ9oRdP7AS8da5Ye0TtAD8aAIw24b/HIjf/450Xd5ySN6CaBa3guNmsszV92yQPcx8Ge2 o3PJdmqa NgCC+SzQrHeLF7MPk+2OU20StVXhFMRqE8INvhUytQT5dKseMiEeb3mEM3FKr6z/H/fARD6O2lnFYkEI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 27, 2022 at 09:11:39AM -0300, Marcelo Tosatti wrote: > @@ -606,6 +608,7 @@ static inline void mod_zone_state(struct > > if (z) > zone_page_state_add(z, zone, item); > + vmstat_mark_dirty(); > } > > void mod_zone_page_state(struct zone *zone, enum zone_stat_item item, > @@ -674,6 +677,7 @@ static inline void mod_node_state(struct > > if (z) > node_page_state_add(z, pgdat, item); > + vmstat_mark_dirty(); Looking at this further, about the two above chunks, there is a risk to mark the wrong CPU dirty because those functions are preemptible and rely on this_cpu_cmpxchg() to deal with preemption. Thanks.