From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>, SeongJae Park <sj@kernel.org>
Cc: <damon@lists.linux.dev>, <linux-mm@kvack.org>,
<vishal.moola@gmail.com>, <willy@infradead.org>,
<david@redhat.com>, Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH -next v4 3/8] mm/damon: introduce damon_get_folio()
Date: Fri, 30 Dec 2022 15:08:44 +0800 [thread overview]
Message-ID: <20221230070849.63358-4-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20221230070849.63358-1-wangkefeng.wang@huawei.com>
Introduce damon_get_folio(), and the temporary wrapper function
damon_get_page(), which help us to convert damon related functions
to use folios, and it will be dropped once the conversion is completed.
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/damon/ops-common.c | 18 +++++++++++-------
mm/damon/ops-common.h | 9 ++++++++-
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
index 75409601f934..1294a256a87c 100644
--- a/mm/damon/ops-common.c
+++ b/mm/damon/ops-common.c
@@ -16,21 +16,25 @@
* Get an online page for a pfn if it's in the LRU list. Otherwise, returns
* NULL.
*
- * The body of this function is stolen from the 'page_idle_get_page()'. We
+ * The body of this function is stolen from the 'page_idle_get_folio()'. We
* steal rather than reuse it because the code is quite simple.
*/
-struct page *damon_get_page(unsigned long pfn)
+struct folio *damon_get_folio(unsigned long pfn)
{
struct page *page = pfn_to_online_page(pfn);
+ struct folio *folio;
- if (!page || !PageLRU(page) || !get_page_unless_zero(page))
+ if (!page || PageTail(page))
return NULL;
- if (unlikely(!PageLRU(page))) {
- put_page(page);
- page = NULL;
+ folio = page_folio(page);
+ if (!folio_test_lru(folio) || !folio_try_get(folio))
+ return NULL;
+ if (unlikely(page_folio(page) != folio || !folio_test_lru(folio))) {
+ folio_put(folio);
+ folio = NULL;
}
- return page;
+ return folio;
}
void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr)
diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
index 8d82d3722204..65f290f0a9d6 100644
--- a/mm/damon/ops-common.h
+++ b/mm/damon/ops-common.h
@@ -7,7 +7,14 @@
#include <linux/damon.h>
-struct page *damon_get_page(unsigned long pfn);
+struct folio *damon_get_folio(unsigned long pfn);
+static inline struct page *damon_get_page(unsigned long pfn)
+{
+ struct folio *folio = damon_get_folio(pfn);
+
+ /* when folio is NULL, return &(0->page) mean return NULL */
+ return &folio->page;
+}
void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr);
void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr);
--
2.35.3
next prev parent reply other threads:[~2022-12-30 6:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 7:08 [PATCH -next v4 0/8] mm: convert page_idle/damon to use folios Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 1/8] mm: memcg: Add folio_memcg_check() Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 2/8] mm: page_idle: convert page idle to use a folio Kefeng Wang
2022-12-30 7:08 ` Kefeng Wang [this message]
2022-12-30 7:08 ` [PATCH -next v4 4/8] mm/damon: convert damon_ptep/pmdp_mkold() " Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 5/8] mm/damon/paddr: convert damon_pa_*() " Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 6/8] mm/damon/vaddr: convert damon_young_pmd_entry() " Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 7/8] mm/damon: remove unneeded damon_get_page() Kefeng Wang
2022-12-30 7:08 ` [PATCH -next v4 8/8] mm/damon/vaddr: convert hugetlb related functions to use a folio Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221230070849.63358-4-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox