From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com,
linux-mm@kvack.org
Subject: remove generic_writepages
Date: Thu, 29 Dec 2022 06:10:25 -1000 [thread overview]
Message-ID: <20221229161031.391878-1-hch@lst.de> (raw)
Hi all,
this series removes generic_writepages by open coding the current
functionality in the three remaining callers. Besides removing some
code the main benefit is that one of the few remaining ->writepage
callers from outside the core page cache code go away.
Note that testing has been a bit limited - ntfs3 does not seem to
be supported by xfstests at all, and xfstests on ocfs2 is a complete
shit show even for the base line.
Diffstat:
fs/jbd2/commit.c | 25 ---------------------
fs/jbd2/journal.c | 1
fs/mpage.c | 8 ------
fs/ntfs3/inode.c | 33 +++++++++++++---------------
fs/ocfs2/journal.c | 16 +++++++++++++
include/linux/jbd2.h | 2 -
include/linux/writeback.h | 2 -
mm/page-writeback.c | 53 +++++++++++++---------------------------------
8 files changed, 45 insertions(+), 95 deletions(-)
next reply other threads:[~2022-12-29 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 16:10 Christoph Hellwig [this message]
2022-12-29 16:10 ` [PATCH 1/6] fs: remove an outdated comment on mpage_writepages Christoph Hellwig
2023-01-02 12:13 ` Jan Kara
2022-12-29 16:10 ` [PATCH 2/6] ntfs3: stop using generic_writepages Christoph Hellwig
2022-12-29 16:10 ` [PATCH 3/6] ntfs3: remove ->writepage Christoph Hellwig
2022-12-29 16:10 ` [PATCH 4/6] jbd2,ocfs2: move jbd2_journal_submit_inode_data_buffers to ocfs2 Christoph Hellwig
2022-12-29 16:10 ` [PATCH 5/6] ocfs2: use filemap_fdatawrite_wbc instead of generic_writepages Christoph Hellwig
2023-01-02 12:15 ` Jan Kara
2022-12-29 16:10 ` [PATCH 6/6] mm: remove generic_writepages Christoph Hellwig
2023-01-02 12:16 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229161031.391878-1-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=jack@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark@fasheh.com \
--cc=ntfs3@lists.linux.dev \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox