From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D8AC3DA7A for ; Thu, 29 Dec 2022 23:28:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9B3A8E0002; Thu, 29 Dec 2022 18:28:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B9D8E0001; Thu, 29 Dec 2022 18:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3A0E8E0002; Thu, 29 Dec 2022 18:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B2E4C8E0001 for ; Thu, 29 Dec 2022 18:28:26 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 80B81140EB1 for ; Thu, 29 Dec 2022 23:28:26 +0000 (UTC) X-FDA: 80296935012.04.ADFAE1E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id ED2B840005 for ; Thu, 29 Dec 2022 23:28:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SUK0ZE5B; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672356505; a=rsa-sha256; cv=none; b=PUFyEYObd0fTpLzUWqEr0cvf7QrxEuQXZdItZE+21g+amGXxzK6nhUbkg0G6Z9hCSnPfTj REnjsGvbz5uqMRP+gHKhncBqfLowuWrYhuOR1sf5o93ASmYSON/i6l8ztrBYC/797kLDng eUnDrVaHUq//jxRLetFL25mfCk/teok= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SUK0ZE5B; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672356505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x3u0DqVoDgI6WINRHZblKppTXPtXzAZftK2TaRdYtws=; b=oBqV8Tn4a36FT48mNKq5aMGIDNwVskhm+7aoEWLrGQOoQceIqnDoExoHqoeVpYRJuV69K9 2yO4MRJJusjMD719HcyM25A69x4ZuDzzA8hyXB11XAwwpn2h504pysfEV4zljYIedgGChi 7J+zPA+zRktiJ/Yv1crL4msxADhNE48= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E45036190D; Thu, 29 Dec 2022 23:28:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25E15C433EF; Thu, 29 Dec 2022 23:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672356503; bh=hN/O7/DsuJPZHbYIvsoTEdsXX7zDNtXmGUbeZYQ3mIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SUK0ZE5BGDKMs5/xALYV1saOFeKVO2nJ8FAJznkv7TQsU68qSa07W/sYlc1kPR6pj dytmpDxpqcnK3icXGgVcwh4PKI62Maekws6/7SIxfdhfet9Ps0PfqZd9YbEMq+BvTZ WFbuwIgw4im7BqFkB2o8w4LQjrikOasuiYlP1OVw= Date: Thu, 29 Dec 2022 15:28:22 -0800 From: Andrew Morton To: Kefeng Wang Cc: , , Subject: Re: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a folio Message-Id: <20221229152822.a283198e5df331caaac88a55@linux-foundation.org> In-Reply-To: <20221229122503.149083-1-wangkefeng.wang@huawei.com> References: <20221229122503.149083-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: ED2B840005 X-Rspamd-Server: rspam01 X-Stat-Signature: ci8acp9sqsowuaainkmuw634fmm3kxpf X-HE-Tag: 1672356504-189670 X-HE-Meta: U2FsdGVkX18RkKKRXazt6iFZCBcbbOGTEMGOAt8YyRgGejnDHs/t6NidznstjXWKLd0gIkmmOLszl2lSJm+G03LW+FqRZR6RVvTdBPh0tUcE/e4up3k15+RDW6NhHzT2ph6xlJlT9nzVfb5jRpVSX/afooGALVMFszoDRVv1BiwoDyi/MJW25TPuSUMqmke+fVrO+/SaV5gHKcZz0UaZJuk20mJQaofLBQGrdmzwKgO1nycCg0/yQp2uX+ci3fOVj8V3C+dxreBA1SWj5WKEVtImKS+DowHJQwiUbT0SYkuv5qpD8NloKaah8ipf5U9KxQAp9RMbViu5eM4npyMqrMMzCi6XuU5KRXIYNm0DaTTYvUygKkLlTJvEHUmjpyWKubUXc0uGuQs3wPSh5sgJ7oZh/N/3M7rNKuNpFIImgTG/LyIkyuBwjepgUgwKirxuvpaU5llDk44biyZuptNNK3SvvT05yWf8THg5m4XeV8AtCpr9817az0CR2UPv/AGQ0WNqvOYhmWHeOcjGmoiUvDtcna0S3fRyB4HhKxfeGMLXz8nyg36UBW3CFZZr0Qz5Fi3isJtLwiPEUZlETN9CGfuAJS0WaSh/7oQOQxW8Gqoaft6iGYmPOHnXk5ko0kytEMJDaUIog9Wbv0iz890jCqbqR4scgd6GPxtmObxVNN288xTekd44adaz+9EL0CgDK6MV8HkOSHd51G5K0b2Y+jCahtd3CNO2vpwE8UkKSYAS25GgnYNRXeCCgLi8i1BTHOFunRfjgRtlOXDPBWmcZjH7rNANN657do018Hv9TDzAlxAq2RGndAN9QQfTdFnM+v7BdeB0FhHpYB53JfwEqh90SB1vthS5Cs6GOGArGYFnqrNGjI2EguRoslfWmY/CGyQ26GYX6Z4yrOA0VzQRdS03qCRb6v6qehh8XvilTRARo4Y2QM6nACZV4vM6qUMNI7TZCIhHon6lowPFTnX UfYhu0QV KLU3LlvHTW8HuIgit7e7z40IP2Znm0fcbAJ+YWL8FQUaaPzcnCccglf8IhEtN3N+GdYrxhH50y3NcvWHuMtGT0eqWaFBprIQq/NE2W791lMlheUiW9qSsrkGihA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 29 Dec 2022 20:25:03 +0800 Kefeng Wang wrote: > Straightforwardly convert split_huge_pages_all() to use a folio. > > Signed-off-by: Kefeng Wang > --- > mm/huge_memory.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 266c4b557946..c8cbe7f62eaa 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2932,6 +2932,7 @@ static void split_huge_pages_all(void) > { > struct zone *zone; > struct page *page; > + struct folio *folio; > unsigned long pfn, max_zone_pfn; > unsigned long total = 0, split = 0; > > @@ -2944,24 +2945,32 @@ static void split_huge_pages_all(void) > int nr_pages; > > page = pfn_to_online_page(pfn); > - if (!page || !get_page_unless_zero(page)) > + if (!page || PageTail(page)) > + continue; Why is the PageTail() test added? > + folio = page_folio(page); > + if (!folio_try_get(folio)) > continue; > > - if (zone != page_zone(page)) > + if (unlikely(page_folio(page) != folio)) And this? > + goto next; > + > + if (zone != folio_zone(folio)) > goto next; > > - if (!PageHead(page) || PageHuge(page) || !PageLRU(page)) > + if (!folio_test_large(folio) > + || folio_test_hugetlb(folio) > + || !folio_test_lru(folio)) > goto next; > > total++; > - lock_page(page); > - nr_pages = thp_nr_pages(page); > - if (!split_huge_page(page)) > + folio_lock(folio); > + nr_pages = folio_nr_pages(folio); > + if (!split_folio(folio)) > split++; > pfn += nr_pages - 1; > - unlock_page(page); > + folio_unlock(folio); > next: > - put_page(page); > + folio_put(folio); > cond_resched(); > } > }