From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4DDC3DA79 for ; Thu, 29 Dec 2022 23:17:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FE708E0002; Thu, 29 Dec 2022 18:17:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AF3B8E0001; Thu, 29 Dec 2022 18:17:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6769F8E0002; Thu, 29 Dec 2022 18:17:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5805A8E0001 for ; Thu, 29 Dec 2022 18:17:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2ED8580EB6 for ; Thu, 29 Dec 2022 23:17:11 +0000 (UTC) X-FDA: 80296906662.28.9C4BCD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 69D56A0008 for ; Thu, 29 Dec 2022 23:17:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dGIvhk7n; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672355829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wu6ZiJ3VTPz0QvDWWr5BvnBuxN49QLrRcWJHGiV2AE8=; b=g3sDfXgRZJLJlyGSxyQ4WFN27w4Uf3q96R1sFpgGZvtljePIBL9UhApOi6FBV5eTJ06Ply VpLSW8JSJDlt/cmwT3NaE7uKQ2IqXEfEJLBMsgBm0UMUu2hWVhtsrxEQBhG3NPP+RPuxwD AdXg7ocmntL4hvUYMPlCvGTrRYp/sWY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dGIvhk7n; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672355829; a=rsa-sha256; cv=none; b=MFBJLuAmiRUcGyjtflC1jASZ/Op52CiDj4eMH6IIvM6cq7157oRlyviIUy9AGZbNYRSKx4 A/ohfYlAgdcv/7NwJTe3h5cCWhDPSGUDAdEPX6Vx/79cQ03RutlmDLj1iiXtYy3wC0asVg LrLkYJ+mV20wgVIgZPGxO31A/G2IBTg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B27961990; Thu, 29 Dec 2022 23:17:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63EADC433D2; Thu, 29 Dec 2022 23:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672355827; bh=ntp6Zg5YrqsIy7GSl2YlNqdgGRLR05iroF0aBVjW5fY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dGIvhk7nSSufiC2CMb6F6lPTh60ro7Wm1DhEehS8dr/MJgdBqRTJJ0NOXwFyNlEBt gXApnNxmt+tzZIkIbNgW4wo6ugeifDGD/UWOStD/7moKIUCzvErWNnQ5LFsg9CFKfx nu3toit0lkCrr1kyDtdgpFtpNsI4m2Gpr64p2sm0= Date: Thu, 29 Dec 2022 15:17:06 -0800 From: Andrew Morton To: Uladzislau Rezki Cc: linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-Id: <20221229151706.da16baab4cb6c2bc30e3061a@linux-foundation.org> In-Reply-To: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> <20221228154707.432e8900855122712f98037c@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 69D56A0008 X-Stat-Signature: mtnqtgdcrqmfnhih31xbkd6g19j19ahm X-HE-Tag: 1672355829-825146 X-HE-Meta: U2FsdGVkX1+x6k6Z3RCZqkiff06c2VMiKfjezNDn0jLc+QGMAdvQG6KN9jjJpvqgYTzsHtHtuhbQo9St9Ze4ktDDUEirMCprXsutztvBc64yuxijcrqx5zlnsKF08yIE6jffKv3UVc/eyoXcyMAzP1VTUXVDwqzGg5HmQjAnTzZia7hBsXScplymvaNqDMTEvMY7+7Xzd50RRZ4j4pqg7/ARpnmZmSP//1OSsiB4ethCQ7OIV040jF4TSaWlhFuID3e38hBFqamk7gpaZNTSAu22Et8EC+QByJ8MPZ42YKl9o/58OMLaG0xd5Dao34K4WoRj2dmfRUuLQDF+76pCLJbcF1exmsrESwIdFo5KZ3F/faKKRYYKO0nc9okorhjJGWv0fhuxGlhbQbdPh2VA04SPfh8CUl29cY5JTs4YQ/RBeaIF7BMHSv2v85aijHtA+6gsFiMmsSMefHevP0AOwxJskW6dOmO/av3VrVI8AaavA9Qg1N1TD/N0fc2jsLaKdxo6sb8Kdado8yy4ifQ0/ODQJJE3hCRUeAXRXeDp2/10V3ZZeyDBpgSuvfyg4GF6lxnAAt5NS5rPF/POd3Uci/p/7rbS4ee/tEKr/iGjBpL/csBcOntrszqT8iWJGioyY/bqR2qpnEQeTdIqrVQxHrNpO8vZTUrlPycUYDuuWCZKPKCLirgBEFsZ+uNy3mOk9moHJ0R9TntzT5fbbvJSEGdMdtyWsx4uaqvEO3l+4Vu8VSxiitKp5L6oJq7QoH7SrhroRZ63bS/yMTg2AxVVAaFUXMNPmtjDE872qZhNZqWAoKWJ0q2TT4Gf1XeTShpbxlDSfmdXYEV5DjEPG3ahrMTt9JtfOuyi7wlI6q2xyXU/rnrDFMucAJghqW8hsP3NC/Wj6SQKOlrjQcsAPdxA554YeKRtIxYhUvJOxnLY2X1veOeJFmcGPnfLrgjSuBJJGEsUV15RxvuH2AhTcRT OfYjJZmi e6Erekb1qx4lcwkY76fDmZcwF/JmjwIafQZv5gU05o1d3DJFFdAnER0j85e3xcQk/a95+k7YkPEiSTH2FWGui3zEUoSm11dry1lGIPaSBR6orEqk/nBNvXF7/jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 29 Dec 2022 13:47:43 +0100 Uladzislau Rezki wrote: > [2] > commit 8a85ea97b35924ee39d51e00ecb3f6d07f748a36 > Author: Uladzislau Rezki (Sony) > Date: Wed Dec 21 18:44:53 2022 +0100 > > mm: vmalloc: switch to find_unlink_vmap_area() in vm_unmap_ram() > > [3] > commit a7c84c673c71cdfad20fe25e5d2051ed229859f7 > Author: Uladzislau Rezki (Sony) > Date: Wed Dec 21 18:44:52 2022 +0100 > > mm: vmalloc: avoid calling __find_vmap_area() twise in __vunmap() > > > It would be good if you could fold [2] into [3] making it as one > patch. The problem is that, if we leave it as it is, the bisection > mechanism would consider [3] as a buggy patch, because it is not > fully accomplished and depends on [2]. > > Is that OK for you, i mean to squash on your own? I did that. I updated the "mm: vmalloc: avoid calling __find_vmap_area() twice in __vunmap()" accordingly, thanks.