From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D934C4167B for ; Wed, 28 Dec 2022 17:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DCF68E0003; Wed, 28 Dec 2022 12:46:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C198E0001; Wed, 28 Dec 2022 12:46:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B678E0003; Wed, 28 Dec 2022 12:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 37F188E0001 for ; Wed, 28 Dec 2022 12:46:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 047B7140DC1 for ; Wed, 28 Dec 2022 17:46:28 +0000 (UTC) X-FDA: 80292444498.23.35F096A Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 5456940018 for ; Wed, 28 Dec 2022 17:46:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="mqZG7/On"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672249587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=stKx9UkSIsDhtiGNr4UuvHjIUGxbW5iKWUSJ3b/3AWA=; b=ZaJKYE9GX4KHWKr48nqtdgqeZm4doseoFCdpAVX+Z0bI3FqYl+YkhcRVsEqJ+f0gMXNRPT kQS3NOFuQxvhmMWZqYiSX44xjrfXpa1oyFboJ0e1S91PmYnyLd0ZAUz4+jgKmMynJcMsV2 ioshAbaBgszGxuozxUUa0/0P+Y9x3Bs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="mqZG7/On"; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672249587; a=rsa-sha256; cv=none; b=mgI1f/0aECxcPGg2VIjtFAxwP6nuxlWEzuLM1KJr77L4ehf/mQ0JVk88IxAiFLrtf1OrTt i4pmF317AKib/Ax5kyPK3oUCJZFdRaHMYbDwWlgZJ7YN6CNUirUXqH13gVmdmtoeOBz+wj fbFILLdwn9k5akmKdNBhyU2tfgauJ7Q= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 750E3B818B5; Wed, 28 Dec 2022 17:46:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A93A8C433EF; Wed, 28 Dec 2022 17:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672249584; bh=AH1OxYrcO8YjdjIacmty0G2IXYk7bOFU+c/cWyigp68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mqZG7/OnrcFi2AJsYadz7bEwhPAT2GAXRKYJoNUgWh05hTFfN3OVa/zmvrIe2wW4q miFx9/n+thFJ2qxR4arbQQMLQuqV7NLNAWvzU9myVWu+sF+4gIlNZYIrFFPS0JH7nH YsRv6LkG8joT4ULTKAP8veSddWJ7P8/6nMEuQm4ohfgpyjg+rFUQBTI83cbgANURO1 WdMEUaZZWJV7gWCR3CyT4TtX//eyFYWX4V4Q4lt5WOtSP+Ydu0YvFETulEQsu76e6d beUk54YvJ4AvtCNDjxFPC4UU7GaLLRBvW4x5PRT05QFfaG2PMMUgvOmT/MZ+XCUMxL SIqluDWcRma3A== From: SeongJae Park To: Kefeng Wang Cc: Andrew Morton , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, vishal.moola@gmail.com, willy@infradead.org, david@redhat.com Subject: Re: [PATCH -next v3 1/7] mm: page_idle: convert page idle to use folios Date: Wed, 28 Dec 2022 17:46:21 +0000 Message-Id: <20221228174621.34868-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221228113413.10329-2-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5456940018 X-Stat-Signature: gxwhyfargfz7n73zqxqfgpj3q6r6rhz3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672249587-117025 X-HE-Meta: U2FsdGVkX18DWpSBdRgckzcc2dsc2iQcWXmJTdnfcBbkfr+AcNTaeSnYMBdzLg8Kn0NrVqzF44EYYBZmg4jJtlbsJur3BzuLEKURV6kcUd1MhkHQTZ9Wl93nnFdXW3lnxX1NeTRhe6Y7DVencuvfZmHPIcLDF/jlzy48qsbEaCtkOv4YweIvqU2Hsge3rwrKbdEiZjCmakuubaO7krlw5PDXSW6nQ36SN7U/zj5aUHqiubawpyo0GS4AGRysNgP3KcAU/pZjl1KkKz3SJLQdjFPiW9k+dKGzzx17v6MHe+XDTsy960zFWdhas2t0ldWfos1SAG/1n6pgcH/4lzGzNAZCFfq86jcKxESWXsb+8yRwPsYnpInu0X+nCR3PF8P13RJZ3JO5h7LZo4qcWiALsaX3H+3J0JbdGSM8RnRT/7q0F1iWAsUWXTAeHQe6pPA1eRvqExzVV52fVsORqWMViBdu0c3feADPBrlBTsTMe2aaMJ8YonfnK4B+1WCP30KfjeRSILDKgagTatic/+FHN+8ASh0cahXkb9tXyD74i71anuhLzCkScQoIZCLJ9QtxNlduR2QWIrp2OIESypRS2ZCGBC9EX30vjmg2iTW9ixHZVI4ehhoYo9P8AUw2qJCDl1NCH98gLxeAcHZLh7ZUYMpIpKmFLRsjH5PcpPAjk58NEKFf3/Mg2ndv7UQ5bK9It+6lY3cg5rgsxxIfyRAOOact9T5jCmUWv5uNMhSUOlDoag6x2Ph/QiIevUFr7NMPAt93MXP53Ixk0sP+z0J0MDgJMMF6xb71wYcEQSiU5YVz92Rg7cXH+wcGvRDUOia0xowtaYZvl8rZLeSR6Xx5i4Up/HGQhz+tSIEkD4yqmJX4ZN0YOAcllil1QU6Esb2aHX/tdLA5FnZ/XJndWwwhmQPaymV4s2XPzDrSZnjyt/jlksIVGoBLO238rUpKGGn+9Uc6qweby9Ei80rbdLO +0j5w5Cs Iwr95pHnFk3QkJmU4dKB4/QLpNWqYIujvIo/AFLrsR+ZcIywxdaJjMr1aWzApPBujpJno6J2UtwEs6O41jzDe4a9kt/PeWmgbsYCa0cfbTBl6VQYjj3sAki6SivKwGH9VLhzTIys+MQ48De4GaoRvyAHqXdEMEUZPeRVgSsgQ2Ljw2GZWF807JQx+pqIaWaa8rWLO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, Thank you for your effort on this work, but I forgot mentioning below trivial typos in the previous spin. I should mentioned those earlier, sorry. On Wed, 28 Dec 2022 19:34:07 +0800 Kefeng Wang wrote: > Firtly, make page_idle_get_page() return a folio, also rename it to s/Firtly/Firstly/ > page_idle_get_folio(), then, use it to covert page_idle_bitmap_read() s/covert/convert/ > and page_idle_bitmap_write() functions. > > Signed-off-by: Kefeng Wang Other than the trivial typos, Reviewed-by: SeongJae Park Thanks, SJ