From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C45C3DA7A for ; Wed, 28 Dec 2022 23:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C2CE8E0002; Wed, 28 Dec 2022 18:47:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 87BB28E0001; Wed, 28 Dec 2022 18:47:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7615E8E0002; Wed, 28 Dec 2022 18:47:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6AAAD8E0001 for ; Wed, 28 Dec 2022 18:47:14 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 36CFEC0DD4 for ; Wed, 28 Dec 2022 23:47:14 +0000 (UTC) X-FDA: 80293353588.12.F368ED5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 8794720003 for ; Wed, 28 Dec 2022 23:47:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nvt2kaYj; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672271232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qvB4R7IGE6vPRVggeecWmmWyAJAqnqGbzEXaErUaRY=; b=Na8mztBH1XKFPvicCHSthaBgzPP3LvXUzoaHD7vPzgqrjUo74T0I+JB+RAXndPiOXbERnU ohujHDdwmE7eclIEti5TomUGQVrBYKNw/odDEMUfMzgH+KT6aiWFrrwlLxbvzbTyIcHL1q AMz0C2sw7wcrvME4O9fsc1EFgYeJ8aY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=nvt2kaYj; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672271232; a=rsa-sha256; cv=none; b=glYNnlAScbPd1jWZcYq75tepG6fiufD1b6R5wXNDSDbbhL1WgoLOgL2WOzulOxvbK1ansc xpCW1UwZGHm1GYSEwxEM3BTto5WDC0o+t/16s9Cd022gSRcPY8oYnNVvF+kCeUXX9lttjH H8oGgocqAfs6wLt72UFJ0mu56Vmdm/8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB93CB8188C; Wed, 28 Dec 2022 23:47:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DF1C433EF; Wed, 28 Dec 2022 23:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1672271229; bh=3/RTtSFicmpdJMcYPX+czHQEKMLtoB/Mk0OgRKU9BjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nvt2kaYjYnb3eYuWaail9QKZ+IPZ6IwTquvLqXiTymXSGEj8+qfjT9fzMvjyJmsPW MRTr2UmHVPiGc3fZsrwKvRthjxycvDQNHFN3EggKCRGqW7wt9rbacu5+yWqiD9HW05 sX02ejatj7kd/owmXRIzPUaYU/qQ7sjgPJGv0Z4k= Date: Wed, 28 Dec 2022 15:47:07 -0800 From: Andrew Morton To: Uladzislau Rezki Cc: linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-Id: <20221228154707.432e8900855122712f98037c@linux-foundation.org> In-Reply-To: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8794720003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: o19m9ay641fo9igj7ggerp6dw7m5byhr X-HE-Tag: 1672271232-889550 X-HE-Meta: U2FsdGVkX1/9qv/TpDeMhF0AavjVXyNg8IM6Lh/j4uybDB+VjjpCxtgKu64vj/zmamQ2lfLU7WVCAKsunDeQMrWphlAVw1tGDFBEAwDfs9lSWXkVzV+71qFTfo4TF9DYKGADDnGlcakUkHJy5uj+bgFAxaJGpnxOQ5kKYkISjkX3mZaTMEUTIRDgXDVRzvaD+ZGzTXzYET6NQC7PI+/YSuVD1OReZkHwsNJuqRjJbHryEw+vkUTeH2GsrFv+ZT9IB9TISjdoNgCcqqB/NOxM5KytIbvrBDhkaS4IrnGSBZpoArIcaV8TrvF+LmbxsYr5XeShTQeLxKaIpsCnGuo+vPjnvPmSgTkCdfg4xKG1KZW2M752CeiYM31JFQlMFxs4l/kUZedEMlmRTXN5GNzMtOXNgepaCzlY/PTCXO5rd0hXS9H7FR3sRHuJfds7L1ina74bVi7RfC5nnkFilMb3e7Jjlr3KOSnBY+7W1LDcj/VwwwWjYfr2p249Am4syEngfT7eNvUpcHd1GOotxLqOcPVgDYAgOhGtMan0wgwH+XoQetPn/PfrT+AaL1yf0wX7C3ymlrsmLvmLtBYy4i77EqdLmdU94rGoY8V+hh8LY8s/7luVys5jlGEM4pyuHHdgg0Fir4s6t9XlLu4Yt4ZDxSd3T5GRVNh9sQShbCatqudLiVvHuCnbXNcHvH64dwalpN8ftD35x7MBkof0Hw6GsqlfhVDg1kua9Ifcl5w0cReVLrXWxl7cTdZTjUjHXl8/ghbO/jRW92G0xWzkBbbKnL/J0feJFU69LS4LAA30DvKCX379OZW/fiquwH/C1MzvrVp8/pfX8Bq2feceSif2NS4QZgleUzp26Lq55mMCN3TivBbsjl8Btk/Nyo6+p+jYEF92yVuRggELpepia6LcNmrD5sl+mXF2IL2QtnU9iGSbe7uIRtqsuMPKYNV73JytJ7eRon82C+1ODWH+zGa zkcIIzLX Z9ORUNBXBVbiM7XL0NHOQpYq6hrWG8HicBVXhd0X/9CG9EE9yeRG/8q/y7XcJ9V7nQYaych8XxP3sju9ogeSX78OuYcAMdN4pBIlN/ACvs8gOGUk1NiAgi4Zunw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 23 Dec 2022 17:41:48 +0100 Uladzislau Rezki wrote: > > Don't we also need to remove the manual unlink that was done > > here previously? Actually it seems like that manual unlink is missing > > after patch 1, creating a bisection hazard. So either add it there, > > or just fold this patch into the previous one. > > > Right. In terms of bisection it is not so good. I think folding is the > best. > > Andrew, could you please fold this patch into the: which patch ;) > [PATCH v3 1/3] mm: vmalloc: Avoid calling __find_vmap_area() twice in __vunmap() ? > > or should i send a v4 instead? Yes please.