From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C297C3DA7C for ; Wed, 28 Dec 2022 11:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76B3F8E0001; Wed, 28 Dec 2022 06:18:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7496F8E0008; Wed, 28 Dec 2022 06:18:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54D098E0006; Wed, 28 Dec 2022 06:18:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26D3E8E0003 for ; Wed, 28 Dec 2022 06:18:32 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EF748C0BB2 for ; Wed, 28 Dec 2022 11:18:31 +0000 (UTC) X-FDA: 80291466822.28.05554CA Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf05.hostedemail.com (Postfix) with ESMTP id 80DAA100007 for ; Wed, 28 Dec 2022 11:18:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672226310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6H99sao7Cvbt+F0FO5z1NYRXLj3fZQGHkzFFHDTuAQE=; b=mUUUAd5T7GfkhwhaBgYe/UHn2xU8Mymp3PWeh7KBXs7TH4e0Qq3koCoXnjLKEFmb3e6STr ZgoB6KBTPThpvjqkzD0T1zhQpY/06Cw7LpKnmNxaGJoAH3azzz3BkL9XfwocLlsEGmSng0 sQAJbLN1E0i1KD1izQNuQQ7K5uaQOpE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672226310; a=rsa-sha256; cv=none; b=QgOG48BJUt7Vk4oePnQ+6pLM8jp+Og3yEkFAN1PELDXYiBCsWzBrlWJ56E9LLFa7Mt8ZJ7 X6dPyoqQwMVrihiuaX3BjbjhPHpwO0VQZ/UwqeUxwKg0LX5+xmHJGB5Fw70u61OeV1G33a gqhHWegJgFpUN8xMVAVh+YD4yBkeLWo= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Nhprg2V1kzmWq2; Wed, 28 Dec 2022 19:17:07 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 19:18:24 +0800 From: Kefeng Wang To: Andrew Morton , SeongJae Park CC: , , , , , Kefeng Wang Subject: [PATCH -next v3 2/7] mm/damon: introduce damon_get_folio() Date: Wed, 28 Dec 2022 19:34:08 +0800 Message-ID: <20221228113413.10329-3-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221228113413.10329-1-wangkefeng.wang@huawei.com> References: <20221228113413.10329-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: cacme5ut9u96sgi9junyoiin7rua9hp4 X-Rspam-User: X-Rspamd-Queue-Id: 80DAA100007 X-Rspamd-Server: rspam06 X-HE-Tag: 1672226309-169411 X-HE-Meta: U2FsdGVkX1+lohrsByRNzS//uF4CnIpkY17NBvh4LGAhr+eSDKLXCVkPsdzQpCsglQ2HYj0fdXZo3UHO+ZUyC82KWnZB0OA1ZXUffPkDBHZBdWrLTtSG2Mv/lXLQWLjIF17GshtbF/iG47KtQUJBSXiYNP2D2U+vwa1dAOWUnJIrNjWOrIoVSXRIZNpNs8RDVK3qxEQcCcGq4lJ4WqZoD2oHCmbknFbJLzmMfRC4FUe9KQG/7VFTsod9a9MsHYHBC2nuxYSL9hUOUQLhnK6B7jnXOapOHrrbf1BRgEFBHs2PPNvzfORfZfWRhWla/JTRCRUoQeTfp2D2dVmUZdOCgPGmQA8HGT/dQ9OgVaIy6Wp1549u+BrnyVmg7tykkjPORW14E0/p9R7OL/IYp4Z1zXgl9al1pzY1eoyFktxaguFrrKIrYiqLfY/vYgFo/xAI0OLsEj8nEPAIZ/mnT2EF1rrbB1IJh00THpJwIwiTYlyd12Qx1V3yka2TOc3cazE7mg4J7kYBLCBLD4mmBfcqOVA66zRwFhk/0IZ6KTlzq9zLTyFssAdCv4n8XPBDdp7r6GV7h4RhmVPySWP4mf1FCqqWrnVrkcr34YDNQTnjS0yXXf++qXp4H2NtLNp0sS3s7uXICaN2Fth5VDBbMzeS+ra9P+emMv0wTpug1n0usBx3THW0Y9KIojpkDYWYXZ/bgzdC5u8sHwT7U7FVd08Ze3a/AxZ/E8dcIEAfjYUnSd4rsxej4npongU8GR3vcH6TuyvZgOqqzlObNYZfGXr0eWnLXrk1Yjp9kPhyxMxWHEpH2QoXEbfm5etOlIXrVAmdGmxtl3NaQ2w/FetuLb9OD8xZQbGErGdu8Kn1LvrY7dnP/HrHV9JtIXKPMXsyK06XZy1g6MguiD7DS1nC0488JJmsfTL+ipI4tKtNJChS4U1cNKbPeZBRLipaZsyOWS3p4fHWO0IJ8MWEAghpEFO ZfnUEbuA r9W7kGLa/6EPlRlI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Introduce damon_get_folio(), and the temporary wrapper function damon_get_page(), which help us to convert damon related functions to use folios, and it will be dropped once the conversion is completed. Signed-off-by: Kefeng Wang --- mm/damon/ops-common.c | 18 +++++++++++------- mm/damon/ops-common.h | 9 ++++++++- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index 75409601f934..1294a256a87c 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -16,21 +16,25 @@ * Get an online page for a pfn if it's in the LRU list. Otherwise, returns * NULL. * - * The body of this function is stolen from the 'page_idle_get_page()'. We + * The body of this function is stolen from the 'page_idle_get_folio()'. We * steal rather than reuse it because the code is quite simple. */ -struct page *damon_get_page(unsigned long pfn) +struct folio *damon_get_folio(unsigned long pfn) { struct page *page = pfn_to_online_page(pfn); + struct folio *folio; - if (!page || !PageLRU(page) || !get_page_unless_zero(page)) + if (!page || PageTail(page)) return NULL; - if (unlikely(!PageLRU(page))) { - put_page(page); - page = NULL; + folio = page_folio(page); + if (!folio_test_lru(folio) || !folio_try_get(folio)) + return NULL; + if (unlikely(page_folio(page) != folio || !folio_test_lru(folio))) { + folio_put(folio); + folio = NULL; } - return page; + return folio; } void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr) diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h index 8d82d3722204..65f290f0a9d6 100644 --- a/mm/damon/ops-common.h +++ b/mm/damon/ops-common.h @@ -7,7 +7,14 @@ #include -struct page *damon_get_page(unsigned long pfn); +struct folio *damon_get_folio(unsigned long pfn); +static inline struct page *damon_get_page(unsigned long pfn) +{ + struct folio *folio = damon_get_folio(pfn); + + /* when folio is NULL, return &(0->page) mean return NULL */ + return &folio->page; +} void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr); void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr); -- 2.35.3