From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509E1C4332F for ; Tue, 27 Dec 2022 03:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAC468E0002; Mon, 26 Dec 2022 22:18:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D35218E0001; Mon, 26 Dec 2022 22:18:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAEC28E0002; Mon, 26 Dec 2022 22:18:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A84768E0001 for ; Mon, 26 Dec 2022 22:18:58 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 783E01A0497 for ; Tue, 27 Dec 2022 03:18:58 +0000 (UTC) X-FDA: 80286629556.14.05B1B54 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf27.hostedemail.com (Postfix) with ESMTP id 8F80440005 for ; Tue, 27 Dec 2022 03:18:55 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b=uoG1n4z6; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=iGyPAlCn; dmarc=none; spf=pass (imf27.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.26 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672111135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZCYnFXki7u0QnJz1QySGzrUAbqVjjYGpn0e5VSFUlcU=; b=jTqu9QCSB30e3HrQdGO3OXEeXXRajEyj7vvXoqsUbJng2LAeqLVAuy0plbSS0aV2CvglJh ApsXKbIwQFrJ4axTEJWwvhKENJ0kN6FHGng0uUqrxxAPG8+fqG93pynf+N8fE2D8Dmjqsw D/vxgFTxh5vwAKIhSVycvbkll3DA7yM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b=uoG1n4z6; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=iGyPAlCn; dmarc=none; spf=pass (imf27.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.26 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672111135; a=rsa-sha256; cv=none; b=N1wsIv8pHGcd+EIajzYUAHUZQ7ygRBhA3hOzu12IFfu0E4yxFq6J21FpczZYhz8ciNJvlL 1MZ5KIWTZBFt0oR1ZIAdUTufePRLHNqQamquFdC3svTElLJxdlopm7TpZC02Ijpn4EmaPN ud9OFoS8MIYCPSgIIQMu08HkQhWQAe8= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 04FA85C017F; Mon, 26 Dec 2022 22:18:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 26 Dec 2022 22:18:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1672111135; x=1672197535; bh=ZC YnFXki7u0QnJz1QySGzrUAbqVjjYGpn0e5VSFUlcU=; b=uoG1n4z6ni/BgxxNrY vZzqX3V55aD52nykAF8d0p3Enq5/dJVg51p/NpAKTqaBKcmz3mZepHsD+QN9GJr/ eBdTsdHBTXRgxIxuQwKWnoD/nwoVPvGU3nxttCcb/JZqX1R+GlSaCBf8NtBpfh84 3RbuD1i/x8nAWDcNeReA6tDh9Fhiu3jz38E/PhQ0GL8FWgTz2F9YEJRE992TF2K8 5HmpdIEQf3JFlB8ot9QXLFKZjh6rFPJtlPTQ1Me9HJgWWflUOhOcNrtAym25Ztb7 4Bh6o5DnjSrKPM5nYqwod1UgiE5L0t1BTKCU8kNoaExnKbO1kEGz9Tsb1ZCOSVN9 zJQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672111135; x=1672197535; bh=ZCYnFXki7u0QnJz1QySGzrUAbqVj jYGpn0e5VSFUlcU=; b=iGyPAlCnrtxEeKou1rB2cG6xGfK79cbPLTyoyh2tkW0e beE9MwLgIwhpUi+wrfdWTNWObgzJQL2tC7D64Y64EJh2JcOk294pjIJmJjRbqQuT HP2XVI66zbtwq3xGQxu3nb9HyZ5m3mwnQBypyt3w/4i1FJcT9tlvBT3CsuPWFgTw 3NT8ogqH6qKqBf1KIpS4IJL9UtPxlM7vcHfPxBatj8XW7kIBHoLqI05lDWYicklJ 34YmpapDQOpLQJImPBOLPh+Nde/vnoPQlbMrwNtvOVPwVp5xythCfrBwfJIR+xLd Ag4NK5VITTSJhAzVLKz/6rNMx9NtDRlW4PfHUBXsNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrheelgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttddttddttddvnecuhfhrohhmpedfmfhirhhi lhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrdhnrg hmvgeqnecuggftrfgrthhtvghrnhephfeigefhtdefhedtfedthefghedutddvueehtedt tdehjeeukeejgeeuiedvkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Dec 2022 22:18:53 -0500 (EST) Received: by box.shutemov.name (Postfix, from userid 1000) id 79BC7109CB8; Tue, 27 Dec 2022 06:18:49 +0300 (+03) Date: Tue, 27 Dec 2022 06:18:49 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCHv8 02/14] mm: Add support for unaccepted memory Message-ID: <20221227031849.7sqnnbnn7umhsa63@box.shutemov.name> References: <20221207014933.8435-1-kirill.shutemov@linux.intel.com> <20221207014933.8435-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8F80440005 X-Stat-Signature: ia7bxuhsgrwph1eymrm6qkeeonuo8u5r X-HE-Tag: 1672111135-992203 X-HE-Meta: U2FsdGVkX1/rGV+8ISEG/qgFFYJKuUUmFEpufl2IOgYSZzJXtGJwxf5UPzN7lBtiXx5hmZzf7xujIlMkWv/dTGpnpchYZk1k+UwgXQlOBmdXIsVFZkFOmKLtAflDXSGqU1EXgCO7ODNUbevfU5vVCUexi2KZTsGX6ZoytAdrxmUtfrA5YymRaOhbHpUHFZ8cN6ZVl/ju5fev9luITkq5ZJ5Zz7TJkKZKhFGl+OT26Ja6bfy23XoRdS0NM4G/a64+Yykk680NF+sUYr/hoRV9Fss7sqjc8mMSyZUUYfq5PGOU0mdMVOJgj2leSnfqy8srZMvm8OHWDIAecpuOvxXPHtoH1mwLZobDvnx9ttRzrpCCQAMFnENpI7WL7937JAs7O43b3OzZ1tgruR+eoDV99pPUDpJQXs5e2NG7b5hyMtmqZP0c2UhL+menFsR0z7y+9XNw4CRdIz4CO+lXULP3Up0fR+TL74OYgOyL43TbX09mFS9UCgvUGr8GGLtitDuC1G/6Me95/sYhOk5qkrcxQFAAqjhU6a8g8CbgSFntaQ427aHGIUdes/IxM+kVIZZi0Y5IqINeURf2IRi3irycAw2VVn83eQn2db4SDhx1aHpL5dMOc4v5QPNFCQBr/eTFEwp7SKhV/G+VJxUO4z0PqZEGkQEs6XFaXoxSmV3qwdMBovPY++9/buAMOtCiDhUdGuRCPtgstyZL2rkK/FTm3kb6YVUcWRSALCjKWNKzcXAaIQ7sOVpQPvDPNuWKWpGgKGMsqn/Eg8qtkTxQ62dRe3qX24WEe2+V1cqyg0PfsxQNpPDnC8l6W1jZusey3GIbffMjAiSr8XqKEze79h86UwTyxvh9mGPB4zr5r9pyB9ZqiLXwIaR9h/aBRyysXaORWBJY8kz1p7l4K0ZSrOHX0Ra8qujYzLRL14oKuFq3iKvLPL5yBIY0eeBDnLwLtC89NztrFKJ3xvU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 26, 2022 at 01:23:18PM +0100, Borislav Petkov wrote: > On Wed, Dec 07, 2022 at 04:49:21AM +0300, Kirill A. Shutemov wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 6e60657875d3..6d597e833a73 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -450,6 +450,11 @@ EXPORT_SYMBOL(nr_online_nodes); > > > > int page_group_by_mobility_disabled __read_mostly; > > > > +#ifdef CONFIG_UNACCEPTED_MEMORY > > +/* Counts number of zones with unaccepted pages. */ > > +static DEFINE_STATIC_KEY_FALSE(unaccepted_pages); > > Then call it what it is: > > static DEFINE_STATIC_KEY_FALSE(zones_with_unaccepted_pages); > > so that when reading the code it is self-describing: > > if (!static_branch_unlikely(&zones_with_unaccepted_pages)) > return false; Looks good. Will fix for the next version. -- Kiryl Shutsemau / Kirill A. Shutemov