From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 180F9C46467 for ; Mon, 26 Dec 2022 02:04:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8583B900003; Sun, 25 Dec 2022 21:04:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80868900002; Sun, 25 Dec 2022 21:04:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F885900003; Sun, 25 Dec 2022 21:04:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D8BB900002 for ; Sun, 25 Dec 2022 21:04:41 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 29D254034B for ; Mon, 26 Dec 2022 02:04:41 +0000 (UTC) X-FDA: 80282813562.05.5D2347C Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by imf01.hostedemail.com (Postfix) with ESMTP id C60614000A for ; Mon, 26 Dec 2022 02:04:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf01.hostedemail.com: domain of yang.yang29@zte.com.cn designates 183.62.165.209 as permitted sender) smtp.mailfrom=yang.yang29@zte.com.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672020278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=RRcYd0BIbv1l2hMdePPfbOWbARE2cwJ/mBK4CfFjrwg=; b=qaP/apuDRvo4jNvJgI8oND3t4W08go13EpFiNhymyGjGvdlhPN8/lsq7O6X3SAs+2B91My Rc/CiNrfdgQV1DTt1zMcsn4GftOCFFet/spY7DUgcBZ1RQHDI/RiOCIGRVjNaEMXipkPFt 1RaqxpA8TzXM0ode7gUVw3/VtSV6QLU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf01.hostedemail.com: domain of yang.yang29@zte.com.cn designates 183.62.165.209 as permitted sender) smtp.mailfrom=yang.yang29@zte.com.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672020278; a=rsa-sha256; cv=none; b=CBf6iHD9TXuNqS2X7GILednOVuBuIgltNvCKUEXwmXVuu2tEyBF0/Bxth8x/249+KKF+jW 2a8f5O1l1onAGP0KL/oY0/gUbaA7yki6gFj8NsXhj6Jp9iDmrQNVg17x2VCsPmiJzBIqFa ALFfDwFa02MgIMq7WOBn2cJYFGts5Ic= Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NgLh22Mcvz501Td; Mon, 26 Dec 2022 10:04:34 +0800 (CST) Received: from szxlzmapp07.zte.com.cn ([10.5.230.251]) by mse-fl1.zte.com.cn with SMTP id 2BQ24PHa055013; Mon, 26 Dec 2022 10:04:25 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp01[null]) by mapi (Zmail) with MAPI id mid14; Mon, 26 Dec 2022 10:04:26 +0800 (CST) Date: Mon, 26 Dec 2022 10:04:26 +0800 (CST) X-Zmail-TransId: 2b0363a9012a68f7092b X-Mailer: Zmail v1.0 Message-ID: <202212261004269680139@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , Subject: =?UTF-8?B?W1BBVENIIHY0IDMvNl0ga3NtOiBjb3VudCBhbGwgemVybyBwYWdlcyBwbGFjZWQgYnkgS1NN?= Content-Type: text/plain; charset="UTF-8" X-MAIL:mse-fl1.zte.com.cn 2BQ24PHa055013 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 63A90132.000 by FangMail milter! X-FangMail-Envelope: 1672020274/4NgLh22Mcvz501Td/63A90132.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63A90132.000/4NgLh22Mcvz501Td X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C60614000A X-Rspam-User: X-Stat-Signature: pzszxdn9gnfs9jiuozeuftmn99ox36jw X-HE-Tag: 1672020277-326470 X-HE-Meta: U2FsdGVkX19xyF6GpEfUhA/jGU2+074vpNVIP1J+3yMjx+MrZGBxu8wLDwiSn4vS3SfoZNtlWGRyu67AOxYmHTWiqF5GvWohsafq+j+vkRv0XKBc1Oo9wX/NTlfZ93u3I6L8mtMNu+DPjyN7eMe6mxW7IRnSb6T7pzpu8SvGFsHA3spHbTaejcRPTEc5v2UBMcY4ljNX8hCcCIPgtVToOLdBTsR+i8xo/xArQ6rPukWO+1J4WqHOcT1zL3OWLHFrsyWB9LA68doVBFoggT9/PIeD8opUsgKNfu2tnB3yfSBnhVfKQpa+63YJ4SyKElkL5nd+WrtsP7oM9ubjJ6/ekClwRwlmwxoOh0O5YTEfB/nyQlvqI/GAH+Rq9yA9Jpa3XR2NpRNmTGfnPHb0blBAEjm8MGgBKaL/CKYoQE8yanpvfFKl4UnrlkyX+AkIk94EFW4T2nCvYnIqZ7MQN+e2kiQoEN/o8w+TGsYZTbPY6lp4QYLlvZno+3TtBH3uTzOehh7VJ74CPZGOSEnzmE8FzOXPTpEpF6QCsLpg8Zy6Zj6/L3v4pGMKilLa+YmKbfzFuAiHWsqPNR6ZCkYiftihccO4QXylA+PC0Lp+g4Dj2HkHx079mRT2XzX/+bqVNyKn44nWaO8EFbkPh8AZTekX4v09u1HPcXMyntUvKc7JC4GP+yMkd6vo2afaV2+pXyQ44CU+T8cy0cBouHqDHnR2IktM0AiTPGvDxjIe/LF8iJB0GUTSmW5dv4CEsJuvMv7AELfW1zfNVjSK85LH30L0qc+A4nir12voaOpdescPkQVEZiCGNLbCqVDpSO9Hjostyfb+bjETfQN+AJQSLAJrrtR8m6q2zR3/k/cGOtYo45aMD2HjE6Iyfn7vXUGrcZ4Fy/j6MnncymstfzhSS7g05klERDvCgF3DHVo+PVCc0zo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: xu xin As pages_sharing and pages_shared don't include the number of zero pages merged by KSM, we cannot know how many pages are zero pages placed by KSM when enabling use_zero_pages, which leads to KSM not being transparent with all actual merged pages by KSM. In the early days of use_zero_pages, zero-pages was unable to get unshared by the ways like MADV_UNMERGEABLE so it's hard to count how many times one of those zeropages was then unmerged. But now, unsharing KSM-placed zero page accurately has been achieved, so we can easily count both how many times a page full of zeroes was merged with zero-page and how many times one of those pages was then unmerged. and so, it helps to estimate memory demands when each and every shared page could get unshared. So we add zero_pages_sharing under /sys/kernel/mm/ksm/ to show the number of all zero pages placed by KSM. Signed-off-by: xu xin Cc: Claudio Imbrenda Cc: David Hildenbrand Cc: Xuexin Jiang Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang --- mm/ksm.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index b7fc7d86d11a..e02cc89512cd 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -276,6 +276,9 @@ static unsigned int zero_checksum __read_mostly; /* Whether to merge empty (zeroed) pages with actual zero pages */ static bool ksm_use_zero_pages __read_mostly; +/* The number of zero pages placed by KSM use_zero_pages */ +static unsigned long ksm_zero_pages_sharing; + #ifdef CONFIG_NUMA /* Zeroed when merging across nodes is not allowed */ static unsigned int ksm_merge_across_nodes = 1; @@ -789,8 +792,10 @@ static struct page *get_ksm_page(struct ksm_stable_node *stable_node, */ static inline void clean_rmap_item_zero_flag(struct ksm_rmap_item *rmap_item) { - if (rmap_item->address & ZERO_PAGE_FLAG) + if (rmap_item->address & ZERO_PAGE_FLAG) { + ksm_zero_pages_sharing--; rmap_item->address &= PAGE_MASK; + } } /* Only called when rmap_item is going to be freed */ @@ -2109,8 +2114,10 @@ static int try_to_merge_with_kernel_zero_page(struct ksm_rmap_item *rmap_item, if (vma) { err = try_to_merge_one_page(vma, page, ZERO_PAGE(rmap_item->address)); - if (!err) + if (!err) { rmap_item->address |= ZERO_PAGE_FLAG; + ksm_zero_pages_sharing++; + } } else { /* If the vma is out of date, we do not need to continue. */ err = 0; @@ -3224,6 +3231,13 @@ static ssize_t pages_volatile_show(struct kobject *kobj, } KSM_ATTR_RO(pages_volatile); +ssize_t zero_pages_sharing_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sysfs_emit(buf, "%ld\n", ksm_zero_pages_sharing); +} +KSM_ATTR_RO(zero_pages_sharing); + static ssize_t stable_node_dups_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -3279,6 +3293,7 @@ static struct attribute *ksm_attrs[] = { &pages_sharing_attr.attr, &pages_unshared_attr.attr, &pages_volatile_attr.attr, + &zero_pages_sharing_attr.attr, &full_scans_attr.attr, #ifdef CONFIG_NUMA &merge_across_nodes_attr.attr, -- 2.15.2