linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: Liam.Howlett@oracle.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: should get pivots boundary by type
Date: Sun, 25 Dec 2022 06:16:56 +0000	[thread overview]
Message-ID: <20221225061656.o7bl66m7oez4q67m@master> (raw)
In-Reply-To: <20221112234308.23823-1-richard.weiyang@gmail.com>

May I ask who would pick this?

On Sat, Nov 12, 2022 at 11:43:08PM +0000, Wei Yang wrote:
>We should get pivots boundary by type.
>
>Fixes: 54a611b60590 (Maple Tree: add new data structure)
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
>Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>
>---
>* kernel build looks good
>---
> lib/maple_tree.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>index 73e2e6434e2f..2123d1930a9b 100644
>--- a/lib/maple_tree.c
>+++ b/lib/maple_tree.c
>@@ -669,12 +669,13 @@ static inline unsigned long mte_pivot(const struct maple_enode *mn,
> 				 unsigned char piv)
> {
> 	struct maple_node *node = mte_to_node(mn);
>+	enum maple_type type = mte_node_type(mn);
> 
>-	if (piv >= mt_pivots[piv]) {
>+	if (piv >= mt_pivots[type]) {
> 		WARN_ON(1);
> 		return 0;
> 	}
>-	switch (mte_node_type(mn)) {
>+	switch (type) {
> 	case maple_arange_64:
> 		return node->ma64.pivot[piv];
> 	case maple_range_64:
>-- 
>2.33.1

-- 
Wei Yang
Help you, Help me


  reply	other threads:[~2022-12-25  6:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 23:43 Wei Yang
2022-12-25  6:16 ` Wei Yang [this message]
2023-01-23 21:43 ` Andrew Morton
2023-01-23 22:35   ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221225061656.o7bl66m7oez4q67m@master \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox