Hi David, I love your patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/David-Hildenbrand/mm-userfaultfd-rely-on-vma-vm_page_prot-in-uffd_wp_range/20221224-000206 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20221223155616.297723-3-david%40redhat.com patch subject: [PATCH v1 2/2] mm/mprotect: drop pgprot_t parameter from change_protection() config: mips-malta_defconfig compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project f5700e7b69048de958172fb513b336564e7f8709) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mipsel-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/c77a6bee317925cf3d078bc97a42d644503b9f1a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Hildenbrand/mm-userfaultfd-rely-on-vma-vm_page_prot-in-uffd_wp_range/20221224-000206 git checkout c77a6bee317925cf3d078bc97a42d644503b9f1a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/mprotect.c:523:13: error: use of undeclared identifier 'PAGE_NONE' newprot = PAGE_NONE; ^ 1 error generated. vim +/PAGE_NONE +523 mm/mprotect.c 507 508 unsigned long change_protection(struct mmu_gather *tlb, 509 struct vm_area_struct *vma, unsigned long start, 510 unsigned long end, unsigned long cp_flags) 511 { 512 pgprot_t newprot = vma->vm_page_prot; 513 unsigned long pages; 514 515 BUG_ON((cp_flags & MM_CP_UFFD_WP_ALL) == MM_CP_UFFD_WP_ALL); 516 517 /* 518 * Ordinary protection updates (mprotect, uffd-wp, softdirty tracking) 519 * are expected to reflect their requirements via VMA flags such that 520 * vma_set_page_prot() will adjust vma->vm_page_prot accordingly. 521 */ 522 if (cp_flags & MM_CP_PROT_NUMA) > 523 newprot = PAGE_NONE; 524 525 if (is_vm_hugetlb_page(vma)) 526 pages = hugetlb_change_protection(vma, start, end, newprot, 527 cp_flags); 528 else 529 pages = change_protection_range(tlb, vma, start, end, newprot, 530 cp_flags); 531 532 return pages; 533 } 534 -- 0-DAY CI Kernel Test Service https://01.org/lkp