From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC063C4332F for ; Thu, 22 Dec 2022 13:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 109CA900003; Thu, 22 Dec 2022 08:50:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BA06900002; Thu, 22 Dec 2022 08:50:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC3CC900003; Thu, 22 Dec 2022 08:50:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DD8AC900002 for ; Thu, 22 Dec 2022 08:50:51 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A181180E60 for ; Thu, 22 Dec 2022 13:50:51 +0000 (UTC) X-FDA: 80270077902.26.C229391 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 4F3FD4000D for ; Thu, 22 Dec 2022 13:50:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=M08TLcqe; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671717048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dKCiYQ23O3uBl9KybsaGHQdKwg661OuoQvd3fEpwuvo=; b=PNlJoL1+FYSI0yPkdU66KcDDjQsPuhfdHLU4hbqgcTm97/sN0IbX9SeE+pKaQPQbf7rFUj cx83VgWIun0g8VOoh9MD5N9u4sRTmOv8Q48gwFuraJ9XK1b2tAybhQp48GLfop3FrHiwYK 3SdCtQs1GBJ8Bg6eRXdN4xfVbJQV2ao= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=M08TLcqe; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671717048; a=rsa-sha256; cv=none; b=3bUs2fC2KwRqIcDG13HIxlGqZ9PRBkQBpeqtmxdWXnOTMFLeM4mJRsr6q2JQDLRbwKvaDG Kj0ZH1nGnL50AWBowXv9h9cqOP1FR/oyvllvOTv/yNC4R8/DBfEMX7tQa9aPv7T6FZh66T joeKK6rVLtpAhqfwN6uBYDQX9fubVTU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5C58D23CF6; Thu, 22 Dec 2022 13:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1671717046; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKCiYQ23O3uBl9KybsaGHQdKwg661OuoQvd3fEpwuvo=; b=M08TLcqeLRGth27rtQLEqHTEGmfzGkrqCZ28m6wQlz4q5subWsUifO6MKgLung/h4RS3BB P5H7klPHvF5K/SUmOS5SqH4qKAEn2djJ0sBN8Hs22P5KNCpHvI90xMQc+6tYJHw5YkbVVz NshLbpDNi5HYwlu2rdu7WSWw4CZfKS8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2914A138FD; Thu, 22 Dec 2022 13:50:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JLUfCbZgpGNZOgAAMHmgww (envelope-from ); Thu, 22 Dec 2022 13:50:46 +0000 Date: Thu, 22 Dec 2022 14:50:44 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Roman Gushchin Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Shakeel Butt , Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton Subject: Re: [PATCH RFC 2/2] mm: kmem: add direct objcg pointer to task_struct Message-ID: <20221222135044.GB20830@blackbody.suse.cz> References: <20221220182745.1903540-1-roman.gushchin@linux.dev> <20221220182745.1903540-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline In-Reply-To: <20221220182745.1903540-3-roman.gushchin@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4F3FD4000D X-Stat-Signature: 7rjthncsegu3snxwf3mg9t7p5oycci6q X-HE-Tag: 1671717048-959513 X-HE-Meta: U2FsdGVkX1+lPdwlk2DC+6GKqI0p3GhqUE1dXnj9XPHYT1AnUqshIFgIgTNYKsnWrGXHH3xOhXsTtTf4T7weGE8jiSINg6xjY1G9zvsTT4rM0hch5D9gSUCjF1dWaHnqu/TGHHDuI4JCvuhj1i2hGh1DwPkgnm71WZBttnM/UyCFG6prdarLbgA1bMrqcfdXJH70ZeEIbbSYMLPgvHdxYXTi0o8wrzIgEoVHG0dbe2xCBGgK4tJlFT1H657n1zY6GXsAyVFu1FnUvZZfLQzGesmxaiyrku98NpZblQuEgTwY5PKn/AKzyQU14qqTDhkvi1/z49kbLdtPxRRCrVtxxzz+5+XT9Oi8jtFJzigp56K9n4ElCLq2tHK6gzgvNwt5HQ2BWDRURHCRhm4QUby7v6lkdN5vAvD0Sh2COeFwrmPbX/YGXFEsGUyxD1t3nMoX26//iDL0fUuiFkgcR5om0BUmtodr5oTOKd5QE7sbJJyLOR/m5wU0ZEwqprtoqsAtwKG3gp+BHok+E65g7YTLJOJS0CZujFyP1qFNHpObeSiTl31sJ3IkQiNI8moLg2tz7aYkwi75G/Aul+zoEeT6XvCIhHKCnYmtectP/gyzjXmHNVrt41PrWZmgCndBRmmSuPJGj7dN4P5bwfU8iALGH3gWtBPDxfhz65LyIf7oUc0nGbpJjiC2+KxdT74DckiqaGqZ9M1UgSiR7Du76ew4BrE4bu8RXScAZhnmhQaOGw3cIUckNdA05xpANh7Gm01n+lzEojFOU6yV5JhQVAL/xaQkMv8chszVPpwvzniNbBwTyuozWrxUi53j5YEixIekPU5jKaaAVSpnRaDz3MnaY3nzrNATNzll7YzV0hyxp+Ql+25weCCppboMb0OistkLQ6faAzvHXg37MpPuIAL5Gi04WpJNlnS0UYtCHixvjf1fNO6fYGr0kwMyaGE1jlrPE04Qmmt0FNBezPqghrF 5k3E8H9Z 26ZeI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 20, 2022 at 10:27:45AM -0800, Roman Gushchin wrote: > To charge a freshly allocated kernel object to a memory cgroup, the > kernel needs to obtain an objcg pointer. Currently it does it > indirectly by obtaining the memcg pointer first and then calling to > __get_obj_cgroup_from_memcg(). Jinx [1]. You report additional 7% improvement with this patch (focused on allocations only). I didn't see impressive numbers (different benchmark in [1]), so it looked as a microoptimization without big benefit to me. My 0.02=E2=82=AC to RFC, Michal [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D216038#c5 --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY6RgsgAKCRAkDQmsBEOq uee9AP0XW2wd7WEaYeLk8NGJ88vIfhH8dybRnl5vWnQZqfHw9AEA1OHVGGFOMlz6 lYuj11/kUl2A4R6elqCcLj9yPsw26QY= =OHxW -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML--