From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB1EC4332F for ; Thu, 22 Dec 2022 12:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C722900003; Thu, 22 Dec 2022 07:44:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07605900002; Thu, 22 Dec 2022 07:44:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA8D4900003; Thu, 22 Dec 2022 07:44:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DA4A4900002 for ; Thu, 22 Dec 2022 07:44:18 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 93F561A09D5 for ; Thu, 22 Dec 2022 12:44:18 +0000 (UTC) X-FDA: 80269910196.28.A73A446 Received: from outbound-smtp31.blacknight.com (outbound-smtp31.blacknight.com [81.17.249.62]) by imf14.hostedemail.com (Postfix) with ESMTP id B43B410000A for ; Thu, 22 Dec 2022 12:44:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.62 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671713057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMzJLF2OBCUxcAuogEXsI2RHrrSHWMVsKtuKiPLTiXI=; b=ANt+x6tJGQMYBMoVpKUdMKWg2x0GxOkF5t7pHZehh0hBKcCPiY+rWhf8DXgrl5aBdRNVf2 iqARtkL0VviaT5B3AjBMDf8vv/oy0dJ57Si31tQPS3LaKAfv6UneziEG6DtP7NfFPpzEmL lFCnnojzPkx1OuaKd/N1ZM6BAkUFAAk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.62 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671713057; a=rsa-sha256; cv=none; b=mVKYDzWS5tNo8Mok9oRK4R0S6TvpnnvxZRnJZboKJLk6Tos49RGYo19fv1SsA9WtgwbEt3 XohTjM02Ka75OdCj9YM4n1CI1bJWAIiwdzFTBF4/vUTNGtFgQNrho4Qlap230xKoTHPtMR qMOhba8zRuJNHxjwVYb+/K4feoJDe+8= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp31.blacknight.com (Postfix) with ESMTPS id B6AE4C0B71 for ; Thu, 22 Dec 2022 12:44:14 +0000 (GMT) Received: (qmail 19094 invoked from network); 22 Dec 2022 12:44:14 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 22 Dec 2022 12:44:14 -0000 Date: Thu, 22 Dec 2022 12:44:12 +0000 From: Mel Gorman To: Yang Shi Cc: Lorenzo Stoakes , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: <20221222124412.rpnl2vojnx7izoow@techsingularity.net> References: <20221217001554.554913-1-lstoakes@gmail.com> <20221219100734.jag6zejp4tug77yq@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Stat-Signature: hqedbfbbcsom9cokxriiduzhp75isgxg X-Rspam-User: X-Rspamd-Queue-Id: B43B410000A X-Rspamd-Server: rspam06 X-HE-Tag: 1671713056-148365 X-HE-Meta: U2FsdGVkX1+AoxuqZbxQdGuP6bhShmgW7kBH4WUKlSYTLZD0dENAkm55N6XDQbpQEb86YNj4YQ0B1S959g4x6gPXtUAWAL1YL2w6xu39kj3e4lj3XXhKtfLB96iA6ZWc0zkPxRdAgcXPQgeyYrYPO5m9069wZef8VU+nwfxbb/6GPxVPk53lZtmR1WFwNrAeQYixphqBzEIs8sy6PYp6dVL+Dj1zjVDiu4UCLTtWjqQg1kuC3A2AW4DCedStZxf4Hb23REB6PoDTuFNB5qNeDksz/cfUtECE/5LZRmJ7vRBs2xLKOigOLCmozLmaLVwEzNqo+JmEPI9Rn4DJUZHvF8Q++svCNCDRLpW86EE7ByDyU53AKeTta3I5k7/FK/IWJw68mO4qlhCpAySJN4MxXVeJKMkXqycSrHPTN2M8icxcJ1nrP9d9yNsRZl2glrttedlJmi5owPpTScG0gQdDN9GNl6KZ12absAxbM5fy+NdX7NAYahApleS2aTLr3eDaCtjQnplqCmTj5aBq0VmEEouE+gb0BO/xG1tF3Kc4FS1AVkkFBmRt8HbLaMkyMytzrtZpD+gQpZJHHDiXZTPcQUTSHz6ziXN8wjWeeejMmio3BbfFIOvp2NseWfeP8xQBmQ2zYMec40aJ2fW3lSljETzKWfSudya0K1GT8qGRYj5xEYnwjncZdhKyHoBCXZ5WuL2NtJqNB4ptrCMXfZVJMRHPeEjGFyE8UfShHXhsgLUd2Hi8su7aQaH7Cw5fG23N/O3jNZigStQBAlKhfGVbBErtTuyEUBO0kv/5hdyFC9JAxpeyjNzNH6KmDcW4Eoj8/WnxaboMP+rbFWxdgkTyNvDC8jJ1D9w1oMlKLDqFrDJtRA4vaQ8tQgHYH4u9FG85YQnBc1Yg4oijPW8P3DY9kPtBl2kHbcf6OdDxCj/jd5/xeATjaRT/sA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 09:56:19AM -0800, Yang Shi wrote: > On Mon, Dec 19, 2022 at 2:07 AM Mel Gorman wrote: > > > > On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > > > + Mel > > > > > > On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > > > > I think we're waiting to see if any users show up. It's only been 18 > > > > months or so, so perhaps wait a little longer? > > > > > > Apologies, I should have researched the background of this further. I see it was > > > added speculatively in 0f87d9d30f. > > > > > > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > > > the "list" argument. > > > > > > Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage, > > > otherwise we can drop the idea and wait for users to emerge. > > > > I reckon we should give it another few months until May. There has been > > one user recently that tried to use list but it turned out arrays were > > more appropriate. > > Another recent try was the patches for dm-crypt. However Mel suggested > adding a callback interface instead of using list since list is not > necessary for that usecase. Or are we talking about the same one? > That was the one I was thinking of but forgot the specifics so the array comment was wrong. I only remembered that there was an attempted list user but it wasn't the best solution. > I didn't get time to implement Mel's suggestion yet due to my > employment change. Hopefully I can find some time after the new year. > No rush. -- Mel Gorman SUSE Labs