From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CAFFC001B2 for ; Thu, 22 Dec 2022 20:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691C7900003; Thu, 22 Dec 2022 15:29:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 641B0900002; Thu, 22 Dec 2022 15:29:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50A0F900003; Thu, 22 Dec 2022 15:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 41740900002 for ; Thu, 22 Dec 2022 15:29:44 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DA03F14086C for ; Thu, 22 Dec 2022 20:29:43 +0000 (UTC) X-FDA: 80271083046.20.D7F61E3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 42B412000C for ; Thu, 22 Dec 2022 20:29:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xyQfmfqH; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671740982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cHtRUDfJ8+KPIIIdZp/lV5Me9KLByFDBlDs3+48srbs=; b=sl700oLF941LNmjbrCW6TbRjUCKCG34uINj/2epw7HNpD9wrqokUlYhkcnaQbb4CAm7HCn UYDETRmArOZEaHywZFOTAxl1UGWbn4xP22pxCA1Ah4v0ERKhJePz41qFsa4JkZFui09Z3c KbjQ5227/ciDPzEAma4cC5xYw5MPWIE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xyQfmfqH; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671740982; a=rsa-sha256; cv=none; b=nleI0JFPODUFOW/LfieiBhdWvN1pV7nuRj1gY4FYdz1d2SvCu4UbKLw/8viVOv0K/Vinxw /WDCO6LA4nPdE0pBMFMxBfP7gCpmGxRdm1HFIYzKcN3LqnG+tgGHjtRIRufkTMl8If21tB M4KHo1SUyQNvgCmNrUMmNz8+Bej+/nE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 672F3B81F56; Thu, 22 Dec 2022 20:29:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF61AC433D2; Thu, 22 Dec 2022 20:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671740979; bh=78+XeTaO6EMlC2xgXSJtYAPRNZoQKpOoT72uxN9IWGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xyQfmfqHleLWQeqi0qk3kyOaphPCaS5qie4t74lALvgAZ+RJZDhcSgk0Rjt0Luol2 SgQmFBqK2/nkThRXODkH/0mB2/KFmBSg+30Gw6lQ9wgSx+RCx0KHuOZ7B2gY/iOvWw mQfP7+bj3hW/aKupheNg6Oj0RhjLn/V0cXLnJp5Q= Date: Thu, 22 Dec 2022 12:29:37 -0800 From: Andrew Morton To: Yu Zhao Cc: Yuanchu Xie , Ivan Babrou , Johannes Weiner , Alexander Viro , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: add vma_has_locality() Message-Id: <20221222122937.06b9e9f3765e287b91b14954@linux-foundation.org> In-Reply-To: References: <20221222061341.381903-1-yuanchu@google.com> <20221222104937.795d2a134ac59c8244d9912c@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42B412000C X-Rspam-User: X-Stat-Signature: gkp8imur6gynewkib5csqfuzhhd714d5 X-HE-Tag: 1671740982-428031 X-HE-Meta: U2FsdGVkX18pdTLJM3E2I/atMNVzwmsIXF6OOsrOACxh/z0MPsf/50JlXfY5Vc0QDZ4JKEablrNUvuJzHAC0kaW6/8ta3UmOZ3CfXDvf8YfoclDtyufnLmEBxhdjSlPBNGBnxC4j58RNTw3ds1PIKY4WtgZ4yZFH6TjW9EsGCoWtcltbx8jYikMZR9lyyqMgoclV3mhWBhspyLXqrrawGUvGOwvoHcaHPus97U2Gn9FApSSYPFBLCRuIcwyVbv2CLoLvxe5ErC+IMNMSgQ6MbdolM2AejKTyzUknaEgoaiu917qWja2aptGvVZM8dn4v9k4k/trXMg5FFwXgxmPeDzK2JAeLWZTaxsc8jWW4ZPEAFyndp/CBlv9AGnu0Gn4QiHS8dYA+CHN6Kdq+x2oL9HPdc+wqE5zD+NoVh6UvFg5lFX3uGzuKBJ6XvCnS3AzxthXtobVMud9VHSsmrSjQuTCwIG3JjoZFmNTF1m+F14QTGkZy1f/sb1FU8SihFdcBOEgYw3TOPPqkSYPWmM4FSh0EBFaFfdA0L1YY/SglRVGtHEekuVfxo+8I2PG2xhmDa6mQ7rYrj56XX3OfsD8eFSx1CDKlDPQQsfGlh93faOuzqwB+4rKIkamN7JsqPgnaST2+Sttf0gl/AGRKW6KqhjwD1NDNyp+OOYLozUJpwnWp5v+IX1husdSWADSX94MNSzl27vN3bfqmffdnXjS8PfID4SOxs0U+Z4U2ngfdVBQcpk4NNL60Hlgz3Nk1v17B5qfEzhYonoaSVmCvwd91AVCP/JDaItVTUj9+RMybvTCsVGKkDsIoS51Foy0zg97q6X4z3CrU/IF7vVJ0WrenOk4qfqQMbzohY5a+y5MwGvAoVht77tG4HnIIuvm9DAwHfJXaMN04hnXK+blybyqOBbz5asTArK/F4Tp8JwtrejMoqlsPE9SAT5YecDkp/oo2yKvJ5wUSotX5DTp9zzZ u+SOnqt6 EP7P5ulPeHDYKkkn5hdGOtnhxLOo1FS3+Ti5kIQ+Flsf5SzcfgY6Y4V7PbTAiJcEAP5edysAFHnMkgCViN9Vx+qMyLJptSTAOauFQIJFj6UTSJGyZrK/nkN2otg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 22 Dec 2022 12:44:35 -0700 Yu Zhao wrote: > On Thu, Dec 22, 2022 at 11:49 AM Andrew Morton > wrote: > > > > On Wed, 21 Dec 2022 22:13:40 -0800 Yuanchu Xie wrote: > > > > > From: Yu Zhao > > This works; suggested-by probably works even better, since I didn't do > the follow-up work. > > > > Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and > > > VM_RAND_READ indicate a lack of locality in accesses to the vma. Some > > > places that check for locality are missing one of them. We add > > > vma_has_locality to replace the existing locality checks for clarity. > > > > I'm all confused. Surely VM_SEQ_READ implies locality and VM_RAND_READ > > indicates no-locality? > > Spatially, yes. But we focus more on the temporal criteria here, i.e., > the reuse of an area within a relatively small duration. Both the > active/inactive LRU and MGLRU rely on this. Oh. Why didn't it say that ;) How about s/locality/recency/g?