From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920E0C4332F for ; Thu, 22 Dec 2022 18:49:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1D0D900003; Thu, 22 Dec 2022 13:49:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ACD49900002; Thu, 22 Dec 2022 13:49:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9961D900003; Thu, 22 Dec 2022 13:49:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8C58A900002 for ; Thu, 22 Dec 2022 13:49:46 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5233BA0A4A for ; Thu, 22 Dec 2022 18:49:45 +0000 (UTC) X-FDA: 80270831130.23.3B4AB92 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 24DD4C001A for ; Thu, 22 Dec 2022 18:49:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2p4QRrg4; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671734982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fj3OknKK+ndBozozgXa40Ol3zYW+yH6V/fZGC2jKUPY=; b=UhlAxQ9CO+zsL5R0M44e0UC1bfDA3q4aobGzqaQVKsqy7c3jyp87CKO3OE6nXY5zmFmfSq vf+RTSUdECviP3cCT9DGj1ISTE29KIHnZOsn+DXxXa23dc0hyZx+MRN5pMqCr0eR+pCAxK 0PWjagoHtrI7q1zDIUofIeq+oiUna4o= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2p4QRrg4; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671734982; a=rsa-sha256; cv=none; b=GFerQ9dyeUfnQp9e6JtJ9GRUqq8cfWvB+p6rMbfKpgikioTgWQBO/Qub575/WOAUzIaBcQ qINAwu1PnydJ0BIjLAYOJUxt4ABd71XP9pC/g16dCiRh2xM5p3IQir3cQzVFH8ka4I4jXL QnSQnSv8C8dfvPxdkTC0bDAg+ZynjNI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B3CFB81F39; Thu, 22 Dec 2022 18:49:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F847C433EF; Thu, 22 Dec 2022 18:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671734979; bh=esvXnle1q5+xJ9oU7lbX6Lc9X4hVCJBNGfUntfQ9p8Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2p4QRrg4+Eo6uR0owX7gFqaGTtU5tZx8aqaI7642fWqR46XlfUJrSk33QFfHk4P1c hw+5J1AusVjjLriR6EAUg8y6KVRY/wV91u2VZLFMaFZzDMC8TvGmBGt64E8NgvOXIO 70PYDQLNKMqvwMyg3j/rheYINrWqtYu0QDDfqbKE= Date: Thu, 22 Dec 2022 10:49:37 -0800 From: Andrew Morton To: Yuanchu Xie Cc: Ivan Babrou , Johannes Weiner , Yu Zhao , Alexander Viro , Steven Barrett , Brian Geffon , Oleksandr Natalenko , Suren Baghdasaryan , Arnd Bergmann , Peter Xu , Hugh Dickins , Gaosheng Cui , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: add vma_has_locality() Message-Id: <20221222104937.795d2a134ac59c8244d9912c@linux-foundation.org> In-Reply-To: <20221222061341.381903-1-yuanchu@google.com> References: <20221222061341.381903-1-yuanchu@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: pfe8wink6zriodsfk71ygcwg4npwhfra X-Rspam-User: X-Rspamd-Queue-Id: 24DD4C001A X-Rspamd-Server: rspam06 X-HE-Tag: 1671734981-615575 X-HE-Meta: U2FsdGVkX1/a/TWejN+pNMM3o77/nxKmK6ZXdJ3cRqiZcL0P3NMYZ4L6uxuhHlcREMXDGyrve2aE49ckvzS2bN9V8crhzbuaxZVRYTYUs6afoKBy4dUzFhuxAPwOkRsqe0f/bxWZR1Q/zWtBApWgyq829KI9k/ToSQAZi1Cc58VrQzW2cbU3RoIoK/xGo5UTbKOI2y5GV8UMc0LtaCV5zMP4C/Ruok4FvL3BhHgEou2++kmjMnajmZw3+TBYF2J7sRj/lmxZ1OVJNXBtKwFIdEiYl4258+Efa8JMnnFmSd+OXQX4SKVeihe/xJ5Ls8zKkApx3cSI/MlO59sqluTWcqiGeyaE+ETlxnSptqfJImrNbJnuwy7daPwwI0QHwoog54uNO+TSiwvNwjXNyWK8PjUhfp9QSmChmm+ImazD8DeYRsOmZ2NvHuNl3Jer/IzuDXMBbEYU+DcrnTeoBpoYvuE9j24Ui9JPOrpO2o8FZ+H65VPjxzE8l2S6APkWuBhlFUV/UTbEkGRLQYemWffs65PDF6WUK6r/FrMOQYv4weDAbLOt1QQG75HAuzb2+NN2UoOmVcNHRYnUozCRLK0+niyODBiR5V7Fvrr2Q691Q6K1xDX+/PbCwVhjTjuf45SPXLA/dm38zHtpZStLvFjjHi7esofbo44GIXYl8RvP4EaDqjg5rO8+PSZf1J/AVzlCEd7nKmcPKK67dC+o+/z5rOObYdP4fXAyPWZHSt71LihiOGxsP4i/5V87aqY8xsGLd1JtmnGKA2weKETFu7+YieM9mHbNDtWRQsAnFwb3CGQMyj8jw+47FuksiZjrIuR5WsrXTzXCAmHbwQ/8YNadCmmZ34B1sF5ifvzJF6p3p2KCoCFzEteDCwXhkj6TCsAP3iwC+9QHIKu3G8IEygmPgb4+fdXUx4suZBeBiNW3hHk96fyLZ58LMEMNzxYMm7aQ/f8n/7Xjo6lHeVdDg+F +hRYUR0A wfCh14L4ZrPtecgP4lYDDmJz/fJGWikSp4fs8srEB9zDAWrV9GTcy0wrxtJnC6IkbjIqJEXCKa9KPSLFiXPKDI8d6gQtKGzmGJdPsV5HaUxAHpyhHYIVHgvXmsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Dec 2022 22:13:40 -0800 Yuanchu Xie wrote: > From: Yu Zhao > > Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and > VM_RAND_READ indicate a lack of locality in accesses to the vma. Some > places that check for locality are missing one of them. We add > vma_has_locality to replace the existing locality checks for clarity. I'm all confused. Surely VM_SEQ_READ implies locality and VM_RAND_READ indicates no-locality?