From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C126FC3DA7C for ; Wed, 21 Dec 2022 13:54:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27C308E0002; Wed, 21 Dec 2022 08:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 253B38E0001; Wed, 21 Dec 2022 08:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 142808E0002; Wed, 21 Dec 2022 08:54:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06EDA8E0001 for ; Wed, 21 Dec 2022 08:54:37 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 80954140577 for ; Wed, 21 Dec 2022 13:54:36 +0000 (UTC) X-FDA: 80266458552.07.F3499AB Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf26.hostedemail.com (Postfix) with ESMTP id CFD5014000F for ; Wed, 21 Dec 2022 13:54:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Hoi5o+ot; spf=pass (imf26.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671630873; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VjHL28xIIWZ3H/BvrvTL/SzJsTlT7yr8mn58EIua50k=; b=fTLOdo1KKxMPJ4UivsMou6oyE1bFP8nGs9N06+HF7sC8m499kJvOK64E+GI7u5zOZBXIO5 /9meet3ofY473JlZZfwIGHNLn/9OJRKWnoRkdb0hTBPsY68DQB1K8p/wEoSEodCt24V5Zo A/ogwd3tB6p58OrA+M0eH1t7BQ9u804= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Hoi5o+ot; spf=pass (imf26.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.47 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671630873; a=rsa-sha256; cv=none; b=Wr9N6WP04QDH/By+dJur8pqpyfc4lWmzHpHB+o66EnYXyJqoeQho3qodTBo5srHBhw/Fxk 51C38DZlactTR8EISXzEFrxqIrpa/hLjdmHujHIkDkqgGqffJSBk+AXDnzrCrT2zO2PwK+ 4uO65VcySVCmU+OtsEoYvRylsDyDLTs= Received: by mail-ot1-f47.google.com with SMTP id m7-20020a9d6447000000b0066da0504b5eso9020724otl.13 for ; Wed, 21 Dec 2022 05:54:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=VjHL28xIIWZ3H/BvrvTL/SzJsTlT7yr8mn58EIua50k=; b=Hoi5o+otCqI2B2QM4oTKy3KiqIvRxPA1Cwg0liYMPI28BAGwXdGwg8xJ3zk22MHkC6 3Cog9oXBdSRBubKsbN6PxxIpWPss5//tsRVUOLTNmFSJsGzlOmuWjHDA5lQLluwk6lc3 2+olSRPP5ZMaL1TLPBEXhsm4uAQN/skPmK6YcAQhqf5GwtAg8cqv3EXqQDd0sWG7El2k 3pHzGj8CxWElzsbEjRf05269uhJByIPkz6qmHDt4i8zobvKGauIN/uZLatbwC7MYVv8a TdeNNO6nW9n80N8vzUU37Ie7f8FWoPYuv3761AvdamHoX8sl40QlOBNpuBi9bCbbajp7 nbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VjHL28xIIWZ3H/BvrvTL/SzJsTlT7yr8mn58EIua50k=; b=qj5X+V2hk9D2w+74ssgSgSxpOFaG5P0jEtdVrDTI+Sgyd/OxzDsh+eCV/bb4tlJSVS DlI8KdjS8/nxajtbCfvK8F7wIEIQltEqHCQCIqfCWT3rwjfC6CGuXKG2pvg2O9jm9jsp 2TRK+EwZ9vOenR3rj/XD5yZXsO20E9/RRy5/wvU91kEUP58WkLp3rg/DEOfRlZEdN1g2 7cs2BQzdHAyzzGqtROz6fkIJmxL24T4IfmCcaSx1Qsk8HkoBPQnhdCOP8bSSiG5N3Orh JmMuK1STnSr806C1+hpxRFW8JSm6FGcTKYfx46X9vArf8Xc4kIFCJpsKRqivvhc+vjaW T+8Q== X-Gm-Message-State: AFqh2kp9lHwdvCBsc8PqV6FVoL/MzQR8Fu/8rkMuvP6vsSQN0aPNyaQV +Z72T/Br2ZWKcBxxbhHgrR0= X-Google-Smtp-Source: AMrXdXvnRfz+J2sIuXk2RP7veVaaGfPhrnoRytEF5O2eK35NAqtPf350JeS2E2+/TaCPXivuPUKbow== X-Received: by 2002:a9d:7f12:0:b0:670:9cff:64bf with SMTP id j18-20020a9d7f12000000b006709cff64bfmr677054otq.21.1671630872896; Wed, 21 Dec 2022 05:54:32 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id z3-20020a056830128300b00661a3f4113bsm6800783otp.64.2022.12.21.05.54.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 05:54:32 -0800 (PST) Date: Wed, 21 Dec 2022 05:54:30 -0800 From: Guenter Roeck To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Subject: Re: [PATCH 03/13] sh/mm: Make pmd_t similar to pte_t Message-ID: <20221221135430.GA1510470@roeck-us.net> References: <20221022111403.531902164@infradead.org> <20221022114424.645657294@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221022114424.645657294@infradead.org> X-Rspamd-Queue-Id: CFD5014000F X-Stat-Signature: o4mmyrsq3aogpae93ksxjmasutzsu69u X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671630873-768728 X-HE-Meta: U2FsdGVkX1/8Y0izEYfCqMDpOnLh/Eava15uREHdb9ecDcb0PesPiXfjLLBHLuAz5K3//LiuZFF1co5WIWXktGQU4Om1uPrfgompzCKH2X+/gFZoLRnKR5Phi3HkJrEUHFcoYBphXG2LxeN1tEC2n/C18EdgPW3DRPS9F38InIFpUBUyoCtEfMGzKMRWMzJJGXF04qsPu/FYlkhXu9NBj5hzRr2+5qSEIDywT+aJ2uW6dbRC44u5Dt5UCQ27nMFFs9JGNlnuXl6vDIF2cIkkeMqQ/LYnHcUXMyb5inVIHIoLTakk2/QnepAO0YTUQjtDZJ94QnEQ80Yu8H22AkehftdFE2zmNVKP0G1TWA/0A/A5fCvqB4fo5hK6VEONdApKUyOvI+6Ntt0RyFs70NAA8E4vmNH/Yeex4dyDg7K0r+Zqxv1bN22/Z7y8OB+XhL3ge/1qDiGSBjkOORQTVl6XSLuDvZR4Co1zLTP7o+XHWAsgTL7sVzGPNV+uhU4YtG/3LkcgOPf5OlivHOsfO3jOrdv7bQKgs410PNrDqvjgBOTqJTlI/LuO5AxL6g+IJIeh9qjqW7hg6the/nSHgRsVmOXAFUAqg0IEEIjXn+vHtd4ER5C5lIMcXfszWKQSsjjWUzEw0844WVZLjNWFr2MiyHvMUohsejsRF4s+WLjkA7mku7pX7TasZdWyJiFPv4IHqOzNpsmPSihGMoAfMOnUHPz4wo3vG+0Czi7a5I3SAwnN8K/n60+p7tfAwoQqCA0IQwWrQKoGzwnVW+/Q5xR0R3du6oepPnUUdaIuXggn5thkuFFgAFxAfQh8nPOMcdFkCfnckASBxjq1dGqGkhEtQaJmNM6iEucZXniWy4K/+UPsuYYWsPMy9+3InfeZeBrE6WGtxW0ngI109tdzGid6ZnZMlhK1Ge3ly559mmUtkTxcWJDLwDoECfVQNIh/ciIMyOdQrl3th6a92MkG9Jo o+i36fp+ 4BEFvfEyOvKzp/Mc8jaP5sMQXiJ0UymFg6RpjpGtS4ubaE9/NOkkSamMvKOB+93BnKGnXGyeD5vlOZyZ8xxYMmGGdHxTQ7Yzzaa8m1xyGw4mDvxCDwpxFcfPFVRqGmlSkx24JIxw/n1IdXaKhalkiGDRsqsQDsLP3MBIo10CUm6+Jeo/oC7+xuRDDOTzMNrvd/lcm6pCBz9UxSC3Fkha/xpkn1SBDkxkZL2eIQzyrTws7SkEKOWupZ+1YLcmFl4WlfB5v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 01:14:06PM +0200, Peter Zijlstra wrote: > Just like 64bit pte_t, have a low/high split in pmd_t. > > Signed-off-by: Peter Zijlstra (Intel) This patch causes a compile error when trying to build sh:defconfig. In function 'follow_pmd_mask', inlined from 'follow_pud_mask' at mm/gup.c:735:9, inlined from 'follow_p4d_mask' at mm/gup.c:752:9, inlined from 'follow_page_mask' at mm/gup.c:809:9: include/linux/compiler_types.h:358:45: error: call to '__compiletime_assert_263' declared with attribute error: Unsupported access size for {READ,WRITE}_ONCE(). ... mm/gup.c:661:18: note: in expansion of macro 'READ_ONCE' 661 | pmdval = READ_ONCE(*pmd); > --- > arch/sh/include/asm/pgtable-3level.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > --- a/arch/sh/include/asm/pgtable-3level.h > +++ b/arch/sh/include/asm/pgtable-3level.h > @@ -28,9 +28,15 @@ > #define pmd_ERROR(e) \ > printk("%s:%d: bad pmd %016llx.\n", __FILE__, __LINE__, pmd_val(e)) > > -typedef struct { unsigned long long pmd; } pmd_t; > +typedef struct { Was this supposed to be "union" ? Guenter > + struct { > + unsigned long pmd_low; > + unsigned long pmd_high; > + }; > + unsigned long long pmd; > +} pmd_t; > #define pmd_val(x) ((x).pmd) > -#define __pmd(x) ((pmd_t) { (x) } ) > +#define __pmd(x) ((pmd_t) { .pmd = (x) } ) > > static inline pmd_t *pud_pgtable(pud_t pud) > { > >