From: Vernon Yang <vernon2gm@gmail.com>
To: Liam.Howlett@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
maple-tree@lists.infradead.org, Vernon Yang <vernon2gm@gmail.com>
Subject: [PATCH v2 4/7] maple_tree: use macro MA_ROOT_PARENT instead of number
Date: Wed, 21 Dec 2022 14:00:55 +0800 [thread overview]
Message-ID: <20221221060058.609003-5-vernon2gm@gmail.com> (raw)
In-Reply-To: <20221221060058.609003-1-vernon2gm@gmail.com>
When you need to compare whether node->parent is parent of the
root node, using macro MA_ROOT_PARENT is easier to understand
and for better readability.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
---
lib/maple_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 3d45c515ed42..b3a215dd961e 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -503,8 +503,7 @@ static inline unsigned int mte_parent_slot(const struct maple_enode *enode)
{
unsigned long val = (unsigned long)mte_to_node(enode)->parent;
- /* Root. */
- if (val & 1)
+ if (val & MA_ROOT_PARENT)
return 0;
/*
--
2.34.1
next prev parent reply other threads:[~2022-12-21 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 6:00 [PATCH v2 0/7] Clean up and refinement for maple tree Vernon Yang
2022-12-21 6:00 ` [PATCH v2 1/7] maple_tree: remove extra space and blank line Vernon Yang
2022-12-21 6:00 ` [PATCH v2 2/7] maple_tree: remove extra return statement Vernon Yang
2022-12-21 6:00 ` [PATCH v2 3/7] maple_tree: use mt_node_max() instead of direct operations mt_max[] Vernon Yang
2022-12-21 6:00 ` Vernon Yang [this message]
2022-12-21 6:00 ` [PATCH v2 5/7] maple_tree: remove the redundant code Vernon Yang
2022-12-21 6:00 ` [PATCH v2 6/7] maple_tree: refine ma_state init from mas_start() Vernon Yang
2022-12-21 6:00 ` [PATCH v2 7/7] maple_tree: refine mab_calc_split function Vernon Yang
2022-12-21 18:53 ` [PATCH v2 0/7] Clean up and refinement for maple tree Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221060058.609003-5-vernon2gm@gmail.com \
--to=vernon2gm@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox