From: Roman Gushchin <roman.gushchin@linux.dev>
To: linux-mm@kvack.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>
Subject: [PATCH RFC 0/2] mm: kmem: optimize obj_cgroup pointer retrieval
Date: Tue, 20 Dec 2022 10:27:43 -0800 [thread overview]
Message-ID: <20221220182745.1903540-1-roman.gushchin@linux.dev> (raw)
This patchset improves the performance of get_obj_cgroup_from_current(), which
is used to get an objcg pointer on the kernel memory allocation fast path.
Results (1M 8-bytes accounted allocations):
| version | accounted (us) | delta | unaccounted (us) | delta |
|-----------------+----------------+-------+------------------+--------|
| baseline (6.1+) | 81042 | | 45269 | |
| patch 1 | 78756 | -2.8% | 42731 | -5.6% |
| patch 2 | 73650 | -9.1% | 30662 | -32.3% |
Unaccounted allocations were performed from a user's task belonging to
the root cgroup, so savings are particularly large because previously
the root_mem_cgroup pointer was obtained first just to learn that it's
corresponding objcg is NULL.
Roman Gushchin (2):
mm: kmem: optimize get_obj_cgroup_from_current()
mm: kmem: add direct objcg pointer to task_struct
include/linux/sched.h | 4 ++
mm/memcontrol.c | 102 ++++++++++++++++++++++++++++++++----------
2 files changed, 83 insertions(+), 23 deletions(-)
--
2.39.0
next reply other threads:[~2022-12-20 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 18:27 Roman Gushchin [this message]
2022-12-20 18:27 ` [PATCH RFC 1/2] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2022-12-20 19:55 ` Shakeel Butt
2022-12-20 21:15 ` Roman Gushchin
2022-12-20 18:27 ` [PATCH RFC 2/2] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2022-12-20 20:44 ` Shakeel Butt
2022-12-22 13:50 ` Michal Koutný
2022-12-22 16:21 ` Roman Gushchin
2023-01-02 16:09 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220182745.1903540-1-roman.gushchin@linux.dev \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox