linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Vernon Yang <vernon2gm@gmail.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: [PATCH 0/8] Clean up and refinement for maple tree
Date: Tue, 20 Dec 2022 15:19:08 +0000	[thread overview]
Message-ID: <20221220151858.c3bj33jzwjxa3wct@revolver> (raw)
In-Reply-To: <20221220140829.1665432-1-vernon2gm@gmail.com>

* Vernon Yang <vernon2gm@gmail.com> [221220 09:09]:
> Hello,
> 
> This patchset clean up and refinement some maple tree code, a few small
> changes make the code easier to understand and for better readability.

Thanks for looking at the maple tree.  It seems somehow this cover
letter is detached from the series found here [1].

All of these look good except 6 and 8, which I have responded to the
actual patch.  I've indicated below which is 6/8 and 8/8.


1. https://lore.kernel.org/linux-mm/20221220142606.1698836-2-vernon2gm@gmail.com/

Please add my reviewed-by to all patches besides 6 & 8.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> 
> Vernon Yang (8):
>   maple_tree: remove extra space and blank line
>   maple_tree: remove extra return statement
>   maple_tree: use mt_node_max() instead of direct operations mt_max[]
>   maple_tree: use macro MA_ROOT_PARENT instead of number
>   maple_tree: remove the redundant code
    ^--- 6

>   maple_tree: change return type of mas_commit_b_node()
>   maple_tree: refine ma_state init from mas_start()
>   maple_tree: refine mab_calc_split function
    ^--- 8
> 
>  include/linux/maple_tree.h |  6 ------
>  lib/maple_tree.c           | 41 ++++++++++++++------------------------
>  2 files changed, 15 insertions(+), 32 deletions(-)
> 
> --
> 2.34.1
> 

  reply	other threads:[~2022-12-20 15:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 14:08 Vernon Yang
2022-12-20 15:19 ` Liam Howlett [this message]
2022-12-21  5:03   ` Vernon Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220151858.c3bj33jzwjxa3wct@revolver \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=vernon2gm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox