From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E3BC4332F for ; Tue, 20 Dec 2022 14:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4928E000A; Tue, 20 Dec 2022 09:26:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B547D8E0006; Tue, 20 Dec 2022 09:26:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D128E000A; Tue, 20 Dec 2022 09:26:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9069D8E0006 for ; Tue, 20 Dec 2022 09:26:47 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3EE861C64B5 for ; Tue, 20 Dec 2022 14:26:47 +0000 (UTC) X-FDA: 80262910854.14.6B073DA Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf26.hostedemail.com (Postfix) with ESMTP id 6FC28140007 for ; Tue, 20 Dec 2022 14:26:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CKh2pvjJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671546405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5pCjcE2QSizxYYpcp3Q7JX0pj7AbGWE8N5U6SKdhaY=; b=COlkXtwCwIv9KHYjURxMQu5svfe2KPLgzJCK+R+oRp8quejHXqUAFOlqUGqEssX6SiR71C nQTsAD3zPyGBm5Hmoy/0TMVeBmzfzeQsG2qFqPn2U1dRwNq4PaSS4Vg11aGgeMyAIOvvIo H3afXY1OPOwvzghmcMYMXEG6QAsjeeM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CKh2pvjJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671546405; a=rsa-sha256; cv=none; b=3PAc2C60fYKY1nLzs62ygtCut99HC1H/mCbwMGN7SqsIQ1rYIN+m7g2ZE8sf0PMg2pOWrh dnanalemuEXxv7ywhYsb9IAuSWTcjR2vcxGP9v04PRN3Jf+fBBw7l9bbldHr4jsjs6v0AE CX299EoWpqcxfebXahhkNg1wqa/fBkk= Received: by mail-pj1-f49.google.com with SMTP id o8-20020a17090a9f8800b00223de0364beso3845116pjp.4 for ; Tue, 20 Dec 2022 06:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k5pCjcE2QSizxYYpcp3Q7JX0pj7AbGWE8N5U6SKdhaY=; b=CKh2pvjJEKmz9XfYB+s2Lm4mMBVB5Bv2Os5YbA+gIrD7IqyqI3Ob93H9gszwSnJ9Kf sN2nuI9TfUNHyfeEs4jgD5rfza83LS4rzw8Hne8yskYfTNDothnvWNLAMLQHBC04ByWW doMsWmNEVsHtiSY0wJPVtlAA2ZvQGm2v2fRkvutJroEV3zppdmSd5rC8fzp3IC1nKqDL oOtoxI2NH7HRIX2WY6h6EsocwG5B2iiGUPOwcLa+0QHm11jjm/mcDkbTCV5nkfMwd4hq 3dAQg2580o2Bu0qySrLJycUJS2ObN1ZrF0X/Iy5NMT4PM/B2LovkVvjsOpyIc4i0lj5v WQZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5pCjcE2QSizxYYpcp3Q7JX0pj7AbGWE8N5U6SKdhaY=; b=jyqREXzI3QdfZJffjNEmmIJX/cqhveGkD4CrNkArZqGfwPMxSSXQpAAHya85PRDUEI sFzHKYYhgpVMBYuRi6MxwE+40/qSOXlngyyRopvt+HZRG+G2Aw+dp25QvucS6okEgW6v HRzkMSUHiDp6tZbSTJszDIZaCkpcx5jlfgiD81AjFqzPpsyq3FXMEyQ830AapmO1H9WH gfca8/ltgV1lkfNcPWiOeau4NKSPL7AAFdnLBf83/PMccJTM4qBALG5qTjJLdU+gp/k/ ScoTrGBCxtmDABnBb3mPs3neZ1cbyhGHbZsWdLJynm4+SzleaYZgWrq/ksv9gMYhCslq KSBg== X-Gm-Message-State: AFqh2kphHjfhb3E/QSHQfx+N6mv+SlN+FI5QiHaXPVG2hgcS3MyiWlsj mhOuDZqzM2IF2bhoKGm6P+E= X-Google-Smtp-Source: AMrXdXtlURzlzqLwBRnEXi12q7aZoY+rMiK4Tn9hVg323qyMw/gVzTSdDNY/lWtEe2PfX2SIKLofkA== X-Received: by 2002:a17:902:bd87:b0:18c:1bc5:bd58 with SMTP id q7-20020a170902bd8700b0018c1bc5bd58mr13799535pls.9.1671546404436; Tue, 20 Dec 2022 06:26:44 -0800 (PST) Received: from vernon-pc.. ([114.231.52.81]) by smtp.gmail.com with ESMTPSA id ik11-20020a170902ab0b00b001897bfc9800sm9383398plb.53.2022.12.20.06.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 06:26:43 -0800 (PST) From: Vernon Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang Subject: [PATCH 8/8] maple_tree: refine mab_calc_split function Date: Tue, 20 Dec 2022 22:26:06 +0800 Message-Id: <20221220142606.1698836-9-vernon2gm@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221220142606.1698836-2-vernon2gm@gmail.com> References: <20221220142606.1698836-2-vernon2gm@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6FC28140007 X-Stat-Signature: itm3g5mdqz4fasada6owr3gy3mcuru6o X-HE-Tag: 1671546405-530286 X-HE-Meta: U2FsdGVkX18hbKzvD7SGRcvwPIeJJVZSSfPj7Bi0MVT+CVx2Bw8sT9ciP4eB+axGzhqeV8i7ynevf7Bx5BBhmjPO2XHwDEQWk2ES23DwJ7kMcBdF4pYn6tXTCVNcOh7WHlMbvEZdSOtPgKKqu77Yz0j7hUDhmkbd9tXzu5/Mgwi7W9AJ6p6JyZLsUB76wtlxmCb/ZYPTk2MgkGp3UoqOkkumJiOZX0mbD/BYmY78dQjaKUx8pFfeg0iJ+c0u4KiP3Sy0hkP92QVjZQSVcFUqnGgtIzJ7MQe/1rt+TL8ZAFBv9DJWKswkYGSjUl+C6uGrKVNG6XRGxUqQih1Edtjixmo+4NQ8f2Js2HqcySo3/aMcj6hgsBkSvtS3oxy7VF05z0hAbjUlyOl9pHQPahNvxQu0ts9VHsVNzL2OsOo2uiBP6NoNn1MfRRX75oqMs4R4buSNrksHCxnS62DC6wVwG52psREiJUp4jl3sR4X1/SN6yA1NmpnGQEnlNgr0D9AB7XRCouHRN7zzMM2yBGliNMc4qAt9SkGSzJ2OejcFqi5DsZsKZPT/fxTiRmjk+rntbRkBd6k9gkEEcjbXxDEFM//UtooTYyjBUH2PyPXUStjVuQrBUZ0HN1OCP1pQTF7c7x/YJXlaTbVWnbsmK5JRAYIaOfRpKC2Rver2+w5GxpRq6r0lC+NtDaGEWJ1pj3aC3dPiQiLbxGxOAJ6H+XgPXcJSuPKM4UXlr68kmLcMxQqJbXY3OlzISEhgcla0lolWfeZBSntMcUHa+2iVXXuu92aNk9M7FkbOojTskg/q2PIHcxDarhKhPLnUeTRTQ2ze+tpEYkeTkr68edLvtjq6MLi84JxBcJrXNRmxn1DtLQJxcqah+3Io++8OVzRvP7zHoE3CDIQjnEi7nmk+x0T3QKbDNALRx5IFQThyI36RbWZyepfgoOEHqdKothSR8z0DeD+W+NP2CYY9/xHitZe ZloOWRkJ ysovslluSezftiNTl+vAS5Rh+nyqpzAROOIrpe8Nbf46c3n2rx2xF+ScFy/KzNESdpwnvSoakHgztR4+Ubo4XtGk2xKhnh9QhDJjv/kHjXEWL3F5uvkivKqCdFYQ3Fn42HRf06RziMiN16H4xcHz0xUXH0FH7ePss/xsSQNDJa+tN5BU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Invert the conditional judgment of the mid_split, to focus the return statement in the last statement, which is easier to understand and for better readability. Signed-off-by: Vernon Yang --- lib/maple_tree.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 16cdcf309e97..d147669fb99c 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -1882,10 +1882,9 @@ static inline int mab_calc_split(struct ma_state *mas, /* Avoid ending a node on a NULL entry */ split = mab_no_null_split(bn, split, slot_count); - if (!(*mid_split)) - return split; - *mid_split = mab_no_null_split(bn, *mid_split, slot_count); + if (*mid_split) + *mid_split = mab_no_null_split(bn, *mid_split, slot_count); return split; } -- 2.34.1