From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99002C4167B for ; Tue, 20 Dec 2022 07:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33A6D8E0005; Tue, 20 Dec 2022 02:26:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E9EA8E0001; Tue, 20 Dec 2022 02:26:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 164D58E0005; Tue, 20 Dec 2022 02:26:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0660E8E0001 for ; Tue, 20 Dec 2022 02:26:24 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8548AB1D9 for ; Tue, 20 Dec 2022 07:26:23 +0000 (UTC) X-FDA: 80261851446.20.ECD18B7 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf19.hostedemail.com (Postfix) with ESMTP id 2FADB1A0016 for ; Tue, 20 Dec 2022 07:26:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JZbpM26w; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671521182; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wuRQqb4yRAJ4FEZaEUwyqkhOJuLTRzxeOhNcE74yoH4=; b=lFRxFmenTyTjazaG68CCmDQ7TXibA+LXTKWpIwmhkj56/1ItFkmyo35V1CsbrVBeC7wWPK vvsx2rBG0VfYuU3Nzt5YSYuyd9HVQfp6qFiw6fOk238VCW9E94KM9jdwr40stirZjIi9ls Ou1bHqMW3XXiNOFM7mdZw0ukDwBXdUE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JZbpM26w; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671521182; a=rsa-sha256; cv=none; b=uqxueBmmLUM5XiHlCsevjagjwvCPMCmavoerML1kx5IUuR2Jdt1L4RMNhCd2kGYVTvC15M G92HlH67ykfRBjB97fwz7qSC99y/k/zSPw9g9c6vXdLEeEP7sT5AYaI1SnjbsLIBosBOoG Mt4/JXRXVbyGWrb5qGl4yAN37NRZntc= Received: by mail-pj1-f46.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so15619250pjj.2 for ; Mon, 19 Dec 2022 23:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wuRQqb4yRAJ4FEZaEUwyqkhOJuLTRzxeOhNcE74yoH4=; b=JZbpM26wcX2ho4irepvHJdt5UeqQwiPyu7R+jVVSgN5Gcct1FWav/0nKIlEGG7Wr/t qOCuZ4KF6aR1ag3SCCwiU8Vx74XEDaTYbFrHlL+VmTd9OSwgmj3qg0WHtHlkcvJVyGVY jcyc8LwsTH+EyYQYCEN7cGXRKdGr8E9C2eodr+Tz89EQJprNi2IGMJmxjRy9UrNDymKa /3vyx/6zVl+r9inx3sFkNw4NvkktYhsqVCdfZIPrVzwFpF0IxxP+1hlsaTujxBYl7qa0 YM2TgNkL0USPA/hjL9mRvBEL2I8mlnA1r6IwEUnQVcz1Bdj7gjAMPYEqQMc3o44RT+Lh xCxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wuRQqb4yRAJ4FEZaEUwyqkhOJuLTRzxeOhNcE74yoH4=; b=Vd58V+lklT8YryCL2L1NcPH5saRnmKv2JhiLzeQwl2NS7Rl1anyITDt2cshz0wauPS DIEGegDWiMUC04sK36NhWJ/hwDLEBDHsAn7PKCuxsya4wxEZJ9hxfOYtcYP2MbBhE5DW Dnk80GD2uSkp5nFAXbi9+OnnloEJ192wtZ6tL4rzueiEmzNJ24e7eD7JCyiizGlZlQwh 51tLxGmVxGLegOpi8tfmH2c1d8QiLVHgrJblqC93KcLuaFYUDas0hQpE5N/4BCIsnlOv EkPMSlg0BGM8T7iFPN7c14GpWui96NQ7LL2f32/Ku7Z4/9iKxD9g2YnOETapIqEv8Z3T YU6Q== X-Gm-Message-State: ANoB5pl6tKkyezzybhVN5cO45azerTlnMsyN0bWyl7tuzeh5ZBWjqs3l D+DO5B8U2uW2Hpm6L5GnQ/s= X-Google-Smtp-Source: AA0mqf69bc1ZsvE4df0dFC152fE872Y/xXYRuYjW42k/aHXL1ec2lj+lXh051FmPTEXUg4pStZbx8A== X-Received: by 2002:a05:6a20:7b1b:b0:ae:e972:72a4 with SMTP id s27-20020a056a207b1b00b000aee97272a4mr26568218pzh.36.1671521181236; Mon, 19 Dec 2022 23:26:21 -0800 (PST) Received: from archlinux.localdomain ([140.121.198.213]) by smtp.googlemail.com with ESMTPSA id q15-20020aa7982f000000b00576f9773c80sm7865544pfl.206.2022.12.19.23.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 23:26:20 -0800 (PST) From: Chih-En Lin To: Andrew Morton , Qi Zheng , David Hildenbrand , Matthew Wilcox , Christophe Leroy , John Hubbard , Nadav Amit Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Yang Shi , Peter Xu , Zach O'Keefe , "Liam R . Howlett" , Alex Sierra , Xianting Tian , Colin Cross , Suren Baghdasaryan , Barry Song , Pasha Tatashin , Suleiman Souhlal , Brian Geffon , Yu Zhao , Tong Tiangen , Liu Shixin , Li kunyu , Anshuman Khandual , Vlastimil Babka , Hugh Dickins , Minchan Kim , Miaohe Lin , Gautam Menghani , Catalin Marinas , Mark Brown , Will Deacon , "Eric W . Biederman" , Thomas Gleixner , Sebastian Andrzej Siewior , Andy Lutomirski , Fenghua Yu , Barret Rhoden , Davidlohr Bueso , "Jason A . Donenfeld" , Dinglan Peng , Pedro Fonseca , Jim Huang , Huichun Feng , Chih-En Lin Subject: [PATCH v3 09/14] mm/mprotect: Break COW PTE before changing protection Date: Tue, 20 Dec 2022 15:27:38 +0800 Message-Id: <20221220072743.3039060-10-shiyn.lin@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221220072743.3039060-1-shiyn.lin@gmail.com> References: <20221220072743.3039060-1-shiyn.lin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2FADB1A0016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z345q9weycn381xih7krk6um57bd4hd5 X-HE-Tag: 1671521182-647900 X-HE-Meta: U2FsdGVkX1+yTBWlfWdiofWxzNJKuROyYf4+IP3VVYc+5St7HYjOWW5lYa2OlvgH8zXdowH1FsTKS0UyPAmdA+Po84jVGGgwVEJzRzfcf3MF0AYIz1zh2/geWNrCJol3Yd4qKr31a8ac8CN2vTSAgeQW39zI/KPtElHXHHbHdLdd01ovQ3vspXDoszo19eeIrx9O+4+UufPMJWKHD8pZL/TM/zuwPf6D40SKngCJCYuRD0r17AZb4Qz/KT0t5bWOyYCjU4k42iuJOgNlaRGOVMJhdf/7QUkf/OI4+HgL9fnb+0inf1U3Cts/d3M6iOWxrzgHXxYLulANpdIXHxMD+DbzjVkxgl/TNRpNiXbSvRoJSJ0TUUG9wUoRNHpMJHpmrnqdydpwLrOwhQsPstFRtCRrj5dBLRYJrEKVnCY+jwbsdet6801Q7jTygD7SxxeWqPDFG39DHy91GGQnYnODCDcz9KF6WPGHz+WoxqpS2ZAklAPZCtFR7YDTGpqUTwQE2iRwR5Zixsxc62DTNuh4oxccktd54OL6yqUpkhxiIYIaNtIdneTY3shLkqHmdaIgPyRABiPBSq9vgk/f2rCVKa9ZNB5IW2/CeEgFYrf9noUv1m83t+AfvQvf3Cut91383wnewo0fXAojMH4YKz2jUrsT8kTZHoyu9OuZft4MT/YszWd37Wc5Df9IMTDVLEYNyXMOMmS70pLAy90VEQVWpPUcbKCx8XlgM0dRmBgFULplOqTvUoPf02kA3qYqyVi3guNMm4UzhvZNKzjWcT/1vcgC0GWJFcVgqS4WRxkTc9bejCf48JgzfAvjJrq0DyTLUmoMyXP45VER7AEijgydXJqloX7QIjMuSTQYZCu4OKxOYyr4+NhpB00Vj7Z6w+3c6tJUTU126AsqX+i3D+d/HPG1MoQNMqHbZXHHfaD9iBg4e+4JHiu4VIu569zKEuiIqUoACx8TBj+NXfym5U2 iuDfOQP7 nqvnT0Wxt4iJdyEfF1faSkQ+FlWtzzn1mtPpM0nLWcjwIeKOyDH/16OWD6CR0wpg7xXMI4fTJh8cviAkKOZNt8U8eA4JY09g7gvwffEHgPHoGUub7KhJHQxjDin1XRLSrvJcDW8L64jexYN1gxD9DhqX8dkldey6hwLXNlc5eoFx4I6WeTRFq8EpvQeWKsJ99kuoYa4h2oOpDwNOB8PKnvKq2Ez3u7sztIUBQawrF5r0fFmM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If the PTE table is COW-ed, break it before changing the protection. Signed-off-by: Chih-En Lin --- mm/mprotect.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/mprotect.c b/mm/mprotect.c index 668bfaa6ed2ae..119116ec8f5e5 100644 --- a/mm/mprotect.c +++ b/mm/mprotect.c @@ -95,6 +95,9 @@ static unsigned long change_pte_range(struct mmu_gather *tlb, if (pmd_trans_unstable(pmd)) return 0; + if (break_cow_pte(vma, pmd, addr) < 0) + return 0; + /* * The pmd points to a regular pte so the pmd can't change * from under us even if the mmap_lock is only hold for @@ -305,6 +308,12 @@ static inline int pmd_none_or_clear_bad_unless_trans_huge(pmd_t *pmd) return 1; if (pmd_trans_huge(pmdval)) return 0; + /* + * If the entry point to COW-ed PTE, it's write protection bit + * will cause pmd_bad(). + */ + if (!pmd_write(pmdval)) + return 0; if (unlikely(pmd_bad(pmdval))) { pmd_clear_bad(pmd); return 1; -- 2.37.3