From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8726EC4332F for ; Mon, 19 Dec 2022 22:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8D88E0002; Mon, 19 Dec 2022 17:42:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 871758E0001; Mon, 19 Dec 2022 17:42:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 738DE8E0002; Mon, 19 Dec 2022 17:42:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 609498E0001 for ; Mon, 19 Dec 2022 17:42:58 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3363C80715 for ; Mon, 19 Dec 2022 22:42:58 +0000 (UTC) X-FDA: 80260532436.30.80B0735 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 8BEFC140011 for ; Mon, 19 Dec 2022 22:42:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lpbVP7fJ; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671489775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2DLgRxkuY2I8K4QTeN46X8kdGgp55C0GtJzNVnKN7PU=; b=P5ywIsOXPuIpNZQR87b2b2F7a8pXwJyUiu/Ufsmj4KLa07pnnVTsqwG+3uGZDkFpy2p7X6 9nNtjvqz6Pgb9KuNtrHqf+lnuTyweSwER38I0WulQIhUXiAmFjuzC6Up0hKVpRO9cWlbUb n10Xr4W6X0D9TNJWkJAGSjMhUhDtpu0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lpbVP7fJ; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671489775; a=rsa-sha256; cv=none; b=3S3zBQInDjnHghr+cW+GaEMnStwOt/TeM37En/yczlhfJOxVIEtjct+JXYekjJiezMsCrh HmIPguULJPJcKJ5dKSuY88BhtL1J60zfomokQeQzEbd4QWOndOCcbmeut3JiHMFFs1+/xG hRFUSqU/CwWi5vESf8IOBnpjZbRz2C0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 75DDD61171; Mon, 19 Dec 2022 22:42:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 362ACC433EF; Mon, 19 Dec 2022 22:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1671489773; bh=BGre2r5SHKHnb8b4Q50Q+a/dxymK6XCdQgeYGSWrbak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lpbVP7fJ/uOaGEd9aeQZ3P2o/kt4VheUXmT+dpCikhKJTLyA5nZhN69lTh+1W5j/d qcDyiIudJ3f7/d8OI3zQmbTIiBqFrdiZTeEfCcpiXrHtRWQxjBK5P9AVk4mTHu/NqH JSYoHx0maXMcg7CuyoiiZnQARL/sW0ZOGa8qWNEY= Date: Mon, 19 Dec 2022 14:42:52 -0800 From: Andrew Morton To: Michal Hocko Cc: Mina Almasry , Tejun Heo , Zefan Li , Johannes Weiner , Jonathan Corbet , Roman Gushchin , Shakeel Butt , Muchun Song , Huang Ying , Yang Shi , Yosry Ahmed , weixugc@google.com, fvdl@google.com, bagasdotme@gmail.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] Revert "mm: add nodes= arg to memory.reclaim" Message-Id: <20221219144252.f3da256e75e176905346b4d1@linux-foundation.org> In-Reply-To: References: <20221202223533.1785418-1-almasrymina@google.com> <20221216101820.3f4a370af2c93d3c2e78ed8a@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8BEFC140011 X-Rspam-User: X-Stat-Signature: 3yhnqqgxc4ukag7fx8iu99u9hfasa37c X-HE-Tag: 1671489775-229448 X-HE-Meta: U2FsdGVkX1+Qqhl2roII0pKPDM0uT9GPKBypGJzTwz9R1EdOUaMBnU2ufhxbr7mYwRUP4cx4j9GQqd5y/42iABxiF4xq+g5F0FEb6uW3DUpPkmPkEqFZI99ZbYCyXT9p8ecOAhSZDYIHgGdmDfDMPSW5QyKzMOZKYuTU0V95fptQbYrANG9SbuQncvcEn12teR6RWQ9IxXrjbwfn4gQCoNeSZOD08oKPFcTiOlOM8sFwchBRZgukqfsIInG5x3ewLPIDGJod2bJend1Py9YqDQXdGr7LRPx8J1l1tyA5Fv/j+GbHR6HdEMrp4HsQGb/yqAPfnkClWWWhXXOrV9uSAzY6wN73qqfCYA3MNy4JlENTX25LjZl4tlA/WdHqLA0wDnezFSrRWMbrlcXrUTJQ0Sa/Ll4lbAelbcuFTvvw+NJGLj4K+Um1xLpP8uiLAEFPg0VqBnfxbPU7sxmImEyL0JBsqjJpgnWQHB6P4AV4UdiUt/EPrdFm34dG17wtW8M+qVPJAfAZRt8eiUZv9aL6wLxuBiXsH7gNqW+nu2rKF2/ARFdywrYqCYPZBea6MHUx2NyCOLRXD0O8hz2lK/gt23pozkbGzbfXgREVxW121SzBn8vU3//npkA1FjmR+gYh7nHEZJ7gThTcpxzIOwUgEe2fsCBsfr3m92KBI3giyAK0p/hvAmDnL/rgsvAG5pPdAyozW2uPlp467BQaSF9NDQaUpp+4bHk7KO21X7TCM8f2MHCH6xE0UhLSkI5Xq0jcZJ6aOYfmArR2tUa8VLiuUP+/z6HDesbuoBK0z48ak6kiyO/cAOC9YlezuM4DgaXYNSTJ69MEVP3IxD84C++0rUBBoZwm+Nk+zexDn6RLfLqZjXSfWbuf9Ev0cjxaR3N2GtHpcBJZm/y4GSmMKxUf0qTroNNbsMV7ehlCb7nDcNsfkPpDIHANI8mJjOQwyH8t2oF7yB7vUoj48D2ZIAd QBP/p40X Pr8wGnQmvjwlGr2YAVcyppYGlslbcxKZ02fKMyRUfmGonmoP43b4JsMQ/K/1Y0Zb4bwCN7Jbe5wZUjiE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 17 Dec 2022 10:57:06 +0100 Michal Hocko wrote: > > I think it's a bit premature to revert at this stage. Possibly we can > > get to the desired end state by modifying the existing code. Possibly > > we can get to the desired end state by reverting this and by adding > > something new. > > Sure if we can converge to a proper implementation during the rc phase > then it would be ok. I cannot speak for others but at least for me > upcoming 2 weeks would be mostly offline so I cannot really contribute > much. A revert would be much more easier from the coordination POV IMHO. > > Also I do not think there is any strong reason to rush this in. I do not > really see any major problems to have this extension in 6.2 I'll queue the revert in mm-unstable with a plan to merge it upstream around the -rc5 timeframe if there hasn't been resolution. Please check Mina's issues with this revert's current changelog and perhaps send along a revised one.