From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8893CC10F1B for ; Mon, 19 Dec 2022 10:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 220748E0002; Mon, 19 Dec 2022 05:07:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1C88E0001; Mon, 19 Dec 2022 05:07:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0218E0002; Mon, 19 Dec 2022 05:07:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F15E08E0001 for ; Mon, 19 Dec 2022 05:07:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C3B6EA0B45 for ; Mon, 19 Dec 2022 10:07:42 +0000 (UTC) X-FDA: 80258629164.05.02B1909 Received: from outbound-smtp42.blacknight.com (outbound-smtp42.blacknight.com [46.22.139.226]) by imf12.hostedemail.com (Postfix) with ESMTP id 0A9134000D for ; Mon, 19 Dec 2022 10:07:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.226 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671444461; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WYidNEAbB2rYoBHdjTTOFjUQPxGkKDuZlTqgVNSJ8b8=; b=TeZasa3WFQD5Xl0I7lp1RpAV4pM9rzQY5kaB5KnsEyAKeZwQm+hS4vqjzVSRkhrYtD9gZB rBajNUZjXEofuP02jXTkLGbpTYTrHcyWtWu4Eo0gpLrx6hTspQXQ5ZsDYhkgsUzesAT606 NidDLJaMoWEbTbZG+jvYFIl7LaUhbMA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.226 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671444461; a=rsa-sha256; cv=none; b=oWZfFSpzfYGgHKQt11ibn3/ssIDnbzuugZ3bUIzcYYG4sy0nKI6b1S1rvRDQhMzOWsiOCS YraYFXJQyuSnHObrTa9r+Qwds6LsoHxjUGkrzrQ7BIhnKQK0Gp8dUfxFI6D4ZEUg3N50MS Q7Bb1LlKygoMuQpQjVIgiYpZac+eDeM= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp42.blacknight.com (Postfix) with ESMTPS id 1804B2196 for ; Mon, 19 Dec 2022 10:07:39 +0000 (GMT) Received: (qmail 2594 invoked from network); 19 Dec 2022 10:07:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Dec 2022 10:07:38 -0000 Date: Mon, 19 Dec 2022 10:07:34 +0000 From: Mel Gorman To: Lorenzo Stoakes Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: <20221219100734.jag6zejp4tug77yq@techsingularity.net> References: <20221217001554.554913-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0A9134000D X-Stat-Signature: epib6pidzmwxks5uymsib4emht8ug4w8 X-HE-Tag: 1671444460-628137 X-HE-Meta: U2FsdGVkX1+W5ZqyvaBSyCaABge5snD53UjOzk+bZRtOOwfF1W9LM5THWjHiwkxs8vpTmFOdwo/c9QDWFMJYbypvs1G35fw+5zmiAFbvDaMiUhm3zHVw97/ofMOdcV+kwFRhBeSd0GR5LCaOQ75VNrmQyTRsXU0JeqEgIjteJoIOFg1pvwWzuaWnx721fWzXoNjnZJReaeZkzMpnNa4FE/6oQ0Z2R2xxdFyUkGPHt21rCXcnMKnlImA3oFFjrJe4LNK4vZbyrZOqpm67jKOU1DeHD1Na1VXE+66xzcQZP7f9lJA9laxP9CSdegDP3JsuZ8fGBJOtyQhPWV1rsmdF3aph+8BLR5cInh9ejbeUNnpKHVg/SsAxRJ3fzygOdRoxDSWSP1/vDNKBoGcUihSrHm/xqlLgHjSA+yg6n8GqJatkoYatdzoUdKAY1c/+lJ+VuToQYY0nohr6c345sufTa7aRR+XEPsCVcWcElvSIONf++HzCbQzMv9/Gb5xj069DOnnPpgU2bj1S+sV71qSAy7CN/Jf0HIoBgWAthnwy8u6wAOifKS3FP+Fiv0toJokcYwulBv4REzJbp/1zFzJlE3StDzZN/oKSYh3kGLcFuXZJ6S6bJFbDObKPqRRBV8oy82P6pt3QKuCAxh2QmQIadsNtdo5E0G0Fal69fqbn9wDuz/z6l76hlIXKAnn4/5t2UbevN3vStG5S1U9PFs2bLxWBuNJPWRA9wWdgTJoFVxWGo6k8qIOR4fWOKG81rs0ofHYKFfYCXVeSNiu2AjCTKzlci1wF9iI4oI41zf2AtWmtkNpphY2p/YN3ULmUdZ0J130WggDaB6EgbSWwCWsZIzCQKCnMiFCzWSh/dG9QNHrJegLx9SoiUc7sJQAhtGYWqjieM4JUNy5zkWUi7WKqBaQircovDuE9IB1ZBLucAfrDaXpcecjdRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > + Mel > > On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > > I think we're waiting to see if any users show up. It's only been 18 > > months or so, so perhaps wait a little longer? > > Apologies, I should have researched the background of this further. I see it was > added speculatively in 0f87d9d30f. > > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > the "list" argument. > > Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage, > otherwise we can drop the idea and wait for users to emerge. I reckon we should give it another few months until May. There has been one user recently that tried to use list but it turned out arrays were more appropriate. -- Mel Gorman SUSE Labs