From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7EDC4332F for ; Mon, 19 Dec 2022 07:59:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84C878E0002; Mon, 19 Dec 2022 02:59:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D56C8E0001; Mon, 19 Dec 2022 02:59:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6506A8E0002; Mon, 19 Dec 2022 02:59:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4F5238E0001 for ; Mon, 19 Dec 2022 02:59:04 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B4EC402C3 for ; Mon, 19 Dec 2022 07:59:04 +0000 (UTC) X-FDA: 80258305008.04.3486F4A Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf23.hostedemail.com (Postfix) with ESMTP id 10D2E14000E for ; Mon, 19 Dec 2022 07:59:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MF/ppLjp"; spf=none (imf23.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671436742; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I2GsMiBO5UQyYV5au8wWUdPpP9nnwaxVWViHm/nbWQU=; b=dIKeIjOe2oSY9kWbZIstGAxOS2rwryMlvGjmAIMrUjNOaS0JAXrKeAnnjfwcvSzdO76Pem QFxanabWQ4rjDsRf5AGiwVG0I5QnSTyWWxo6fa3ceS+95E+qngJcMiJuO/tNQfiG+I8eUC FpZX4wGs91rK34T6co/9UV1djS7AFiU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="MF/ppLjp"; spf=none (imf23.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671436742; a=rsa-sha256; cv=none; b=EcDpcGWSSQDw9W7vnDY+442yHIBKZG1773AK589iXipooYN7JeZ+oAwFtPaV42Zr9vs2QA CNZ2xZGN1LynB6+IqM7ebzZKs7RyAZVxwtYPsFEHuIoVNeAhekYqWQaOCLHgzDLBQr0RQM 5qcCETlfZNr+4zBo69RBzlp8ktZzcwg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671436742; x=1702972742; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:content-transfer-encoding:in-reply-to; bh=LTCN5nc9sJT3ve1jNEbkwKdzxPjXUiJ2eqZmznP7zEs=; b=MF/ppLjp7a8f7lpFQKOKUUNxwm7exn/CvHIKrFhHDcp9rFV/liMij+9G q0NfWA14qy3TlfVnXnJiQtae2t5cuOdX4fgznNFVPUUKZBdhPSJijW/dv MgQQ18NH8az0UiVBEhHEOWBuBhfX+fZBKgKHilNbuA0P5CJXDJ5GX/gMo C0WdBSl3h29osv3tpow5NDcKNc62LbqkDvbZKlM9BZRsqwkNrqe8Ztt+R bZ+PZo8Sxyr3i5e5aft5yvJHok4QCm//y8c2kpf6MdHaODkHv1Sso712N KoKj8Tvb3/9NGPTnNrs6OeX2yB/wPSf3GfN6SwaLBcvB73X4TJYm004H6 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="383638128" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="383638128" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 23:58:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="895959169" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="895959169" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga006.fm.intel.com with ESMTP; 18 Dec 2022 23:58:49 -0800 Date: Mon, 19 Dec 2022 15:54:32 +0800 From: Chao Peng To: "Huang, Kai" Cc: "linux-api@vger.kernel.org" , "linux-mm@kvack.org" , "qemu-devel@nongnu.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-doc@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "tglx@linutronix.de" , "jmattson@google.com" , "Lutomirski, Andy" , "pbonzini@redhat.com" , "ak@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "david@redhat.com" , "tabba@google.com" , "Hocko, Michal" , "michael.roth@amd.com" , "corbet@lwn.net" , "bfields@fieldses.org" , "dhildenb@redhat.com" , "x86@kernel.org" , "bp@alien8.de" , "vannapurve@google.com" , "rppt@kernel.org" , "shuah@kernel.org" , "vkuznets@redhat.com" , "vbabka@suse.cz" , "arnd@arndb.de" , "mail@maciej.szmigiero.name" , "qperret@google.com" , "Christopherson,, Sean" , "ddutile@redhat.com" , "naoya.horiguchi@nec.com" , "aarcange@redhat.com" , "wanpengli@tencent.com" , "yu.c.zhang@linux.intel.com" , "hughd@google.com" , "mingo@redhat.com" , "hpa@zytor.com" , "Nakajima, Jun" , "jlayton@kernel.org" , "joro@8bytes.org" , "steven.price@arm.com" , "Hansen, Dave" , "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "Wang, Wei W" Subject: Re: [PATCH v10 6/9] KVM: Unmap existing mappings when change the memory attributes Message-ID: <20221219075432.GC1691829@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-7-chao.p.peng@linux.intel.com> <0889bab999cbb464e63490bdb5b3c68c07791979.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0889bab999cbb464e63490bdb5b3c68c07791979.camel@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 10D2E14000E X-Rspam-User: X-Stat-Signature: wkutkz45kgfoj1iq9w4pnx6r9g5he3nx X-HE-Tag: 1671436741-566521 X-HE-Meta: U2FsdGVkX19Y0CMBniuKj5cmL3tFycuoXwoghGtzcOHhnaX+CSq29G8iQGP6wIGglhqMdwVtqZQD6FM0C4Bw+OSeomqMEHg5e/cbkRNoSny0xfzdXMCHu1sHHJdesXZLEK7JX5pcKF9g313GEGGYtJ3zYMz4Hk9ZHWNmmAGTl1Hv/WTuWwuJNi3rqI88tnBmQcE63lIvrjuWXNdaVdzaq/5D9T2nfV4ML/eia5Lx3W6T+scapm2844GTDpSnn9x6LG4T2iIUBvcGE49OUVyYLlG/IbDu9+nYdyF5F1j/HFPend3nLJQ5nDitgYxvl9unnzt45QY4b7CSlFye2vj7EuyvWl+sIE/pOIIPjfwqzgS9UNydmM0P11RZrWT6O8G5If4ikHsQwOhnBZQTtXXnn/Q1Jo4xM1sm6He9zw7mvSMJj9FvfWqTKqtBy/HWjK8fjbdkdXnmTNk19Z4GqUou9k0Iv+BrTdZ/ei+sfNvtv6tJ6FgSOa3XUjaCZSpCBYXEfx9bU054qAx5GxbH57Qg8dZdG7sUsFIZev5dBz70hUoPuyFe+kxLAxhnBtdugErragWPRMg01VWrUTrMnynEK25WU8++WQ0FQOdYr5fKrH2a/C3J3eS8YzkxkbwIvP1YIkmFNOKxAg+R45A9crTBcyighBQpBDOR5tv1gD1KsU2ISKVhwlzVO4jx4DJrJRecGZ5jTbzCulVNbvZ7j9667ygE6wIgGSupyYmfhdSs5o+hsI2n5Mq2kRAK03Wzy+n54HiXngwVbrMjTmXOYdVzqxMyPT401tCXMFuwxZ+phHMzgriiOhiTpfnO6NuEne0kk1vs7do8YVxSrrfbPHAxJCbwK/NRqzeK56cr8fAKiUwlW6Dz3HuxNkV7svTn5RpduJwYa4FiU5QO5KYlkMXtu+QkT9AyAHdNGcBvv6w7Da02kbCeaxfl8nBOQMaiNn4qXKUBZZ4LeWOgafjTvmV qT1LEoJE gfrFk4TCvddUXZ6awQ7vsgNSL0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 13, 2022 at 11:51:25PM +0000, Huang, Kai wrote: > On Fri, 2022-12-02 at 14:13 +0800, Chao Peng wrote: > >   > > - /* flags is currently not used. */ > > + /* 'flags' is currently not used. */ > >   if (attrs->flags) > >   return -EINVAL; > > Unintended code change. Yeah! Chao