From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A143C4332F for ; Sun, 18 Dec 2022 12:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 843728E0002; Sun, 18 Dec 2022 07:12:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3418E0001; Sun, 18 Dec 2022 07:12:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BBC98E0002; Sun, 18 Dec 2022 07:12:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5A3F18E0001 for ; Sun, 18 Dec 2022 07:12:55 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29E76A03CC for ; Sun, 18 Dec 2022 12:12:55 +0000 (UTC) X-FDA: 80255315910.15.FBF545F Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by imf17.hostedemail.com (Postfix) with ESMTP id 55A9440007 for ; Sun, 18 Dec 2022 12:12:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gouhao@uniontech.com designates 54.254.200.128 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671365573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CkXumCPbT7AlLQUTaMCCrIg4vJxHEvL4bKuVigTyrs4=; b=iZtuSQJ62S/v1RGeNqpYjoIiONH3NGhy87TU13ydCUG+3DSEibig/7UgQ3uNz75RK7GUjb cSB5WaefdRihetiYuAKYs4IVvNLj9/2bKOz+qaCw9XJMtuQvz0OaR1VklvKUdfWYArZfk6 8KYLNHPN+3vXuUBxSGe9HSpMt4Zxnw4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of gouhao@uniontech.com designates 54.254.200.128 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671365573; a=rsa-sha256; cv=none; b=wjZ/u8nr3OVw85JhS3a6G3+zojtvTWh2PsjkRNVMSF7y2tIxfizmlucbU2ExWovM7Zc9vC YlNkbt23SUNhnl7sdqmSuclkaK62ZwoRmKQUXEp+yG1EaeWTfCDZuBnbYbsuMKNVzJIwsz +xpk7jmSjlvkvSCmOWnezB3kA/AIHzM= X-QQ-mid: bizesmtp70t1671365528ty2do9ap Received: from localhost.localdomain ( [113.200.76.118]) by bizesmtp.qq.com (ESMTP) with id ; Sun, 18 Dec 2022 20:12:06 +0800 (CST) X-QQ-SSF: 01400000002000B0D000B00A0000000 X-QQ-FEAT: ILHsT53NKPgCay+doqSjgGYDcvmOKqmjpjYEJiGb0MHrDMNATU/mizb2BeNtV dz35PUxh6RnVFkkJo6gWp4xYAhpMUnD9QgHopfv/dlK2NcNrjik/IiCYllIhhySxxCnkefn ZvAFVawg0VXM7YdDfEvENB7B10dYgTc+luTaUULnKc0/QV7h6+CiVxWv1D+TYV8hBCdmYA+ CfUu+gy66DEsNQ0aNWqgGcOx79b72l1q4fYlOBCj8iB+PSMJ8+62Y36/vfk/o5qaCtpA4op Yf2e+zaDDMd3iYuTot3fNUlMKMwdP7doGKWaY5QrighKW45Nyc+HVKfv8T6uQzVB/+xqhUD krbdCoLz6otPeeh+ggcSwlHSONbDd/uzgt/OSQcS4XvLBYbT3oCVa/je4nJzg== X-QQ-GoodBg: 2 From: gouhao@uniontech.com To: 42.hyeyoo@gmail.com Cc: akpm@linux-foundation.org, cl@linux.com, gouhao@uniontech.com, gouhaojake@163.com, iamjoonsoo.kim@lge.com, keescook@chromium.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@elte.hu, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, vbabka@suse.cz Subject: Re: [PATCH] mm/slab: remove unused slab_early_init Date: Sun, 18 Dec 2022 20:12:04 +0800 Message-Id: <20221218121204.27720-1-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr7 X-Rspamd-Queue-Id: 55A9440007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4xmozwj8cioqx6nc8ccck5heas8jbsd4 X-HE-Tag: 1671365569-392270 X-HE-Meta: U2FsdGVkX1/H2QxUQ90kHV5cwDl2WI+8XKULjv78D7Enmlk2duyQa4ytTuYDOMXhwuFf89DRHfBEZTRKdFFSyNp1/zqPtpLQJERXKJXa7RWy7TBEUevw6tsuCfjNHYHpIJ4Mr7uSs/Zej3VBqYBRYAx1fZPSrWxvUzzCNd2Lmzb1BtsKYWD0F5Vi2adGg2UdfuOsKfHVLxpzft+5dLSgv7eWeVAY5SHT5dYJNxcZfvsmGUojeJNMhoT7YkdHTv/6VHy0l/Zn1GlnmRnOVQwmJ3GbUsYN3c/2RorXx4LwB0rk/A9ncRJURu3F6n/+m1ESwtups0RvMBL3saoBychouTbnMKvKqV9YV5jbld+xMdM8lQmjxdkl1/7tE7fiSXjVTSH1q8b7mXKsbTb+dE2gFSFQXRO2qvwqemrIKFKhq1yIUpCmTzNzUWoPoblTNac1+gfPCLZCdx794GMkOW7R/qSs/0lx1tUmwrIHRv2svHYPtNPkmCBIO8WQF1kTFVtWV+rqjt8ZHGPXj9wE4ezokWckDur+HBUfQnTRniMCwalQiUgMseOaIa5CV652GYQRra0EEt6F9Ty5EMPLioFWMpHUGkOBdWU7fIrz0vGo9JpxJkcY2adKrNTkBcMAnijI3IYO49OlBtzIjeyqJy1xmpF3Z3ndD15J6vXWN27PekYLd21iwCBAoueeLPufRJjflJJWAdxw2FaLSky4Sm+o4vfTfdVlwCDwztWU7kXoZlsTsXrgJJ7QzxrlW/bbOdN5hbTCe9OYcz/rgrEyGBkzDrUq+4ht/D4/4iw5jqowUGgYJCruIIe35+52+7cSDkoRr+p1ic32hcYM4aV2/bI4eoDhyMeecx4JQ2BVYrskr2IVF2hgmgo9HEVHbHVevzgVi2FYFDsn9pzsfzE9FKye4hcE5FXXo3YOVohDXhGwxXx92SuLphYkWkP057lWHtM6RAN9CdoEI8TLQ5PbeO0 ymEgKZsy OS2YPi2q1FXlNUKziD/HxTYLBaXGLiPEqcguHVEjfdeolvV8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for your review, i will fix it in next version patch. :) Thanks, Gou Hao > > > so early during bootup. > > > > The only user of 'slab_early_init' was removed in commit > > '3217fd9bdf00 ("mm/slab: make criteria for off slab > > determination robust and simple")'. > > > > Signed-off-by: Gou Hao > > --- > > mm/slab.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/mm/slab.c b/mm/slab.c > > index 7a269db050ee..ede1f29fd81c 100644 > > --- a/mm/slab.c > > +++ b/mm/slab.c > > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep, > > static inline void fixup_slab_list(struct kmem_cache *cachep, > > struct kmem_cache_node *n, struct slab *slab, > > void **list); > > -static int slab_early_init = 1; > > > > #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node)) > > > > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void) > > slab_state = PARTIAL_NODE; > > setup_kmalloc_cache_index_table(); > > > > - slab_early_init = 0; > > - > > /* 5) Replace the bootstrap kmem_cache_node */ > > { > > int nid; > > -- > > 2.20.1 > > Nice cleanup, thanks! > > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>