From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E7AC4332F for ; Sun, 18 Dec 2022 01:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F2A38E0002; Sat, 17 Dec 2022 20:20:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A4A38E0001; Sat, 17 Dec 2022 20:20:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56AA88E0002; Sat, 17 Dec 2022 20:20:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4509A8E0001 for ; Sat, 17 Dec 2022 20:20:37 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 14294A0ACA for ; Sun, 18 Dec 2022 01:20:37 +0000 (UTC) X-FDA: 80253672114.07.FC1A754 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 79DC4140008 for ; Sun, 18 Dec 2022 01:20:35 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XDl3DIkV; spf=pass (imf23.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671326435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B9b9aIRM0M4jTyQJc+P8+kRTSKywdESEX3AEYjpGHr8=; b=TDLnXhO60tkqZf9hNul4wa/VdZOMZgVVfBMqhIGH7/cO1eQPvXyC7q2+MfVwtyvjsBx0Rc JYDIcbhdQGzBzMgixZbJECc5fgqj3SwxmbcNN4FP3teT1kLQwM5BZLrJ+aWhjY9LsJcR9Z KB53S/5GH/3w8vnZz0pgkMl0g9cvl60= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XDl3DIkV; spf=pass (imf23.hostedemail.com: domain of mhiramat@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671326435; a=rsa-sha256; cv=none; b=AW8CoAj2Nu/6mt2FjGijHvDELZpasRKf0xcbINDjafJ5QE40M5hUcmzBYJaop7IdbfUhb9 QSSzpx4Pu0aYHkzEOix8dHFmrdc7UUzPLwFJSqZVhrAtSGK1k9hdRTsGhP7UyUUj11NOA9 v5RSqPS85IIqQcNZJ0otP8U1SijMPwg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 795C960C3C; Sun, 18 Dec 2022 01:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8939EC433EF; Sun, 18 Dec 2022 01:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671326433; bh=qicT3rQp6kWdT0Id/4bJcgSa3iwqNxcqhRvhQqCfeAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XDl3DIkV+QwdD6dsGqTVixU5UQ2j2XdOm806Gc1GpR82h4ysD4rG/ud61oMt6RSjn K92MRY9vYK1hbDjkB4hvvLEqaEt64/eHHG9X4+n8vIkhK8NA/47Wp/RS2ZdC6qg/ZN 04SRJEfOz5F9PU5cIfqwyKgVJy6Ct0HEZLCFBSKuStnmWmuvy6dZH2SP64iXLfsTMm v9kxHqoZeS7oN5vKVew0DETsjTXOtZy2LE6qyYQiDR2Ru+Rl+sxdm6W8oNuTGxMDF2 sFzgsCrpilDzRxxXztd8n8800tZyCoUCjTK3lqsWSOWGjH8eWXfLxPbGiqe/0I1Lbi PLWqcvjpCFdwQ== Date: Sun, 18 Dec 2022 10:20:30 +0900 From: Masami Hiramatsu (Google) To: Wenchao Hao Cc: Steven Rostedt , Andrew Morton , , , , Subject: Re: [PATCH] cma:tracing: Print alloc result in trace_cma_alloc_finish Message-Id: <20221218102030.94b44e62608f20fd9decf9a0@kernel.org> In-Reply-To: <20221208142130.1501195-1-haowenchao@huawei.com> References: <20221208142130.1501195-1-haowenchao@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 79DC4140008 X-Stat-Signature: gh748qobjsq4oscqtupdftrw961x9dqc X-HE-Tag: 1671326435-917719 X-HE-Meta: U2FsdGVkX19ZkbShFeM0CKwwvWrZOMRn3g42rh7kXmoHNEphqyEiXIdDSzSPZqrqiNnuABUOklpdbfM7q9mWxQEHFLkCZodSo0hKcHfOChxQfUkd6aw4eJTbxJJNyD9Qh7o3VJ8NjXWAbt/oMic8xiZfu6lhZ4qNiJKUw0pEtUIB9u+p9uftd1CdEfXfhML6QIvRrJdTl7Snnzm7XCvg0CVL6WHCNJfh5bcXOj7v52YZeJ1rAB1ud1iauiOG1ul+so0RJZ5RCCn+Czps+FDjJQFtsqv/IPl8nEHYoHzzDLHjmI7nGnSuGVXLwsHAkwp2iWOhmNt82veAPxt+ZSDWtq8NldYprBfvI6SjCX0Kak7ElJDbVxEvC39Kr23ffTwJ7/bv9Pf5bWnQL4JeZY4KSbAFfSw3sUGhK6CKHDYKQWt0f7+CHBeva+oUd/WyQuDnqXHdcUNCcJmxQSaADxreXl8eWWUYR/yRCT0kXLMH0zRPDols9OqbIONTQBSLxShPPkYceBZ+MDN/SLD7Y9qx/KSiSIv3wPY6tJi0HXFYkOQOWHz9sWIFPnKbJf0jelFZ+f/j9c89V9NoO2cSq3vfdTWiali2gjlPCUEYx/jX1YYNZ1LkUf0SvjuCfkVPJQErfujKf6GQK6AfdXiWEuZJquwv/JQqQhItXS02uhtVGkmVM6YedJVMyJpt7bLuO60R1pFRoolVgHFRJxXnO05Vc2wHJUONpjL1Hq9IZOg7XW8nWc2U7MzM3n4oMy8cb6gU4PAuFDGWUh4/EkZCG0nc3HRv4LSFgN0EbuHvlZ3st5f/nAvwc1A262dJ7GDpLQsF0RMDju12RZ/2conzPtcxmbpoS6r6jUpc1GJ1fTn9yAkY4tHvaZpgDKkK3wuqcnFBzjJSB+RhXlWcqOsHdkJYkOg6AkyYHxhaHHYNii4cgvozxD4wMGDmRw0NRztIx4IB4nJ0Or6gRyoX02lqfiT O2D9ctcV DqWcP6YoECXGUMnuLhi/jmDyoymtjEpXFwgFlPrlprC21esIXUCSBccW+NRDbPQo1wSWcH64cIei5xYTe4WauPHpGU+9ux7saU73sLTNR9NOj36w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 8 Dec 2022 22:21:30 +0800 Wenchao Hao wrote: > The result of allocation is not printed in trace_cma_alloc_finish > now, while it's important to do it so we can set filters to catch > specific error on allocation or trigger some operations on specific > error. > > Although we have printed the result in log, but the log is > conditional and could not be filtered by tracing event. > > What's more, it introduce little overhead to print this result. > The result of allocation is named as errorno in trace. This looks good to me. BTW, with this change, cma_alloc_class has only one event - cma_alloc_busy_retry. If so, can we remove the cma_alloc_class? Thank you, > > Signed-off-by: Wenchao Hao > --- > include/trace/events/cma.h | 32 +++++++++++++++++++++++++++++--- > mm/cma.c | 2 +- > 2 files changed, 30 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/cma.h b/include/trace/events/cma.h > index 3d708dae1542..ef75ea606ab2 100644 > --- a/include/trace/events/cma.h > +++ b/include/trace/events/cma.h > @@ -91,12 +91,38 @@ TRACE_EVENT(cma_alloc_start, > __entry->align) > ); > > -DEFINE_EVENT(cma_alloc_class, cma_alloc_finish, > +TRACE_EVENT(cma_alloc_finish, > > TP_PROTO(const char *name, unsigned long pfn, const struct page *page, > - unsigned long count, unsigned int align), > + unsigned long count, unsigned int align, int errorno), > > - TP_ARGS(name, pfn, page, count, align) > + TP_ARGS(name, pfn, page, count, align, errorno), > + > + TP_STRUCT__entry( > + __string(name, name) > + __field(unsigned long, pfn) > + __field(const struct page *, page) > + __field(unsigned long, count) > + __field(unsigned int, align) > + __field(int, errorno) > + ), > + > + TP_fast_assign( > + __assign_str(name, name); > + __entry->pfn = pfn; > + __entry->page = page; > + __entry->count = count; > + __entry->align = align; > + __entry->errorno = errorno; > + ), > + > + TP_printk("name=%s pfn=0x%lx page=%p count=%lu align=%u errorno=%d", > + __get_str(name), > + __entry->pfn, > + __entry->page, > + __entry->count, > + __entry->align, > + __entry->errorno) > ); > > DEFINE_EVENT(cma_alloc_class, cma_alloc_busy_retry, > diff --git a/mm/cma.c b/mm/cma.c > index 4a978e09547a..a75b17b03b66 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -491,7 +491,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > start = bitmap_no + mask + 1; > } > > - trace_cma_alloc_finish(cma->name, pfn, page, count, align); > + trace_cma_alloc_finish(cma->name, pfn, page, count, align, ret); > > /* > * CMA can allocate multiple page blocks, which results in different > -- > 2.32.0 > -- Masami Hiramatsu (Google)