From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 908D4C4332F for ; Sun, 18 Dec 2022 10:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 147508E0003; Sun, 18 Dec 2022 05:19:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D0A98E0001; Sun, 18 Dec 2022 05:19:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB2EC8E0003; Sun, 18 Dec 2022 05:19:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DCCD88E0001 for ; Sun, 18 Dec 2022 05:19:32 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AE34C405B0 for ; Sun, 18 Dec 2022 10:19:32 +0000 (UTC) X-FDA: 80255030184.27.C9F1419 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf10.hostedemail.com (Postfix) with ESMTP id 1A7CEC0013 for ; Sun, 18 Dec 2022 10:19:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cRiTctr0; spf=pass (imf10.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671358771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uvPBeK/uQOTkS5bCd9KHq/uJNQrs6bRmNyv7cBW90YM=; b=Mi1C4Juah6u2eED3fkIXFISofittCbjJUt2cyWkC1m+8/dme3jQREi6GCgQVGKFfwcBbpA tTY6NZNclp3UYAseQsa6awdpTtBBEOzSxB4/dnv48bvVaQ4F9bqG6AJJLII01qPqkT1JPj P/0Lo4GUmR1ViCx8xpDsaC2AbYUEA3s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cRiTctr0; spf=pass (imf10.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671358771; a=rsa-sha256; cv=none; b=U47BJoJYLAQ1Y6ttYU3KxDxq0PwuZxqVSHYamg5T+A7R8f9YcfQBsuneawmkVdFDjvZLZw CBJoit1uv3JfSf0ggbpWEiZkFZzrT66nCfA+tosy0LJO7CgTzPsITWjU7MHwAO1F0lJXM9 8gNHxVAEoxW994XA+cbxz1bcdCFCfgs= Received: by mail-pj1-f47.google.com with SMTP id e7-20020a17090a77c700b00216928a3917so10267929pjs.4 for ; Sun, 18 Dec 2022 02:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uvPBeK/uQOTkS5bCd9KHq/uJNQrs6bRmNyv7cBW90YM=; b=cRiTctr0c+Y3PZWbi7kGhJ+34MYU3MF+KKnkl+m0yvYmeh883ce+JGBji2dZkDL2Wo hjL9TAemPLQTDRquzBzZeh7gEX9K3HNYkHV9ZLZRDL/TKyUe+k5cg4kICjxEiUuvvHzT /vjo03Bq5Fa77BDp79CFdE+HJdkWVffsveAnjyPESBtjDEWf9g6LV007LJr9icmfaraT gHoQiwsNbbjf8JegEPhFcZi7XGz0hJeLpj0Vp09qF6fDBlDkBxajEVETAzGafjUiRTKy mugTC9WZqfGT42wqXkQrr+4GNPLFab7/vpOtwly1RRFOOudqMFYz5g8lbt3jqqjaOK5W tGpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uvPBeK/uQOTkS5bCd9KHq/uJNQrs6bRmNyv7cBW90YM=; b=b3Nerx5zRz/OUts15IclMsLxHiud7NKpCPzZe9wD7phXViHOwebOaQnWctKciEJj3e uwQ8RSmg0M4Ri/OXLu4Thqfaiy4X60Nz1N9VjsDg/7UdXF9q3rpA6nP4PDGz6KIetFLR dt1wc/m7y4NRkOAjpUbylREeh8iJiZU5fYhZV5ae5fjyrIUgCfZ+ChUOhe3+Nx+I9wBh RpJYVfs4GaRhylKV8zYIhuUzODnIKxJzpx2CYm1tGb3P2HZYt2rmbh6LleBg5UU2nFS+ WqDBoCQh72RYmds3R2v3ZS36MZT4pACA8dqstkOKcqXW1BN/lI8zmzGbwMNyoIRayyip X35g== X-Gm-Message-State: ANoB5plFN8CS1V/8Bh3FD+gNKoBxQiQzsKoiGTSIP1J4t0pPgtrKIPVt xsc0x/8yt7siZ4XbcosNem4= X-Google-Smtp-Source: AA0mqf6JsU6eO2pxoS+w8HrBGNWmgAWd/51Yb3PiWN6hBjoaQOTnmocm7rbasPDj7XkU/fiBlRC6nw== X-Received: by 2002:a17:902:b618:b0:189:af28:fd8d with SMTP id b24-20020a170902b61800b00189af28fd8dmr37386097pls.1.1671358770040; Sun, 18 Dec 2022 02:19:30 -0800 (PST) Received: from hyeyoo.. ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id ik11-20020a170902ab0b00b001897bfc9800sm4789791plb.53.2022.12.18.02.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 02:19:29 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, =?UTF-8?q?HORIGUCHI=20NAOYA=28=E5=A0=80=E5=8F=A3=E3=80=80=E7=9B=B4=E4=B9=9F=29?= , Joe Perches , Petr Mladek , Andy Shevchenko , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types Date: Sun, 18 Dec 2022 19:18:58 +0900 Message-Id: <20221218101901.373450-2-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221218101901.373450-1-42.hyeyoo@gmail.com> References: <20221218101901.373450-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1A7CEC0013 X-Stat-Signature: kd6o8f9padhw6uis58tge4d8cdf49wyd X-Rspam-User: X-HE-Tag: 1671358770-92141 X-HE-Meta: U2FsdGVkX1/zAFu8qQufg1iFCQEtYLV507GEM1W6qmXN1XBuG27RsAWuPYOSRLXFXCAfIIW5lBe/onANkFbObYZELVvf+oZThhZ8fUeKZCKJdMmSgHov4nebpTjO17FpGlhQe+0JBr4I0jR3MCxaeyRaMeuk92SSnv9xlvr6NSIw5tBu2666YAdKdwynshegh+wjkVwwaQ1Zv5aLrlN/Qf6FOVJN7QZZDf/Yp1IFaUTvoEGlrVpqTShoxkOKEnaCalYb5VV0Hbcs1G0Cfjk+1X6AW3ItKLPo3V52Z6leFpSoETF2MJ3STtnoYSTXkEUTSkzdU4Nf02wJDVcXS/gbMUHz/uAE1mRjZSaefFvEc0bOCnv2tEu5df8y5K2bmnk1++63koxVfJvDaM/PXA/uWABVKHoryB1dbadRjKJCOHDV8MFoTgxbF/VstuzqZTAbkZGys7R8I9gbdECTfKTjYJgQgFCXQztcJdf0zIYR2vfvOeYToR80B/83yuTyIL16sTV+eDNbEIDkwUCw39GPrMkwrv9TruzEX9ccs8Xl6M0XW0hO2DJF+8lSDfGYRIsYP+5CzjXO2fxZu7tcLXyLCuZWbJ9nMcmYrsNwodx5cYA+jXwT24n/sAq/rXv2llVkzzOhHdD3DOuYtvAtxgvERePpRE3rtISHNd5JqIT2Vf+RWtKQr0Fwn0uxlfWNLuofQ9b7RWqAfnyI7WphBc1NQ63LEzkCLkoA/Dqo4CzHpiLGbww2ju79tSEANPEcrr6QRNJx5vR/A7eOLYEYyQ5sXsRKKpqGEDVRui5NZxpeN2EVWmxfQOjVftp48LBKG1Ita0Va5xaNnyRG//1CgSFo4warqB6A8dTworcM3hK23SApCnRVeL5vUdWJ9szz4iDJ5ZtExmfIoDGshzTx/fO+hS+YwAF5kjxHBAJ2tP3hdq7PjIH/r76hwlql8PHRfullnqBTQ8xEkahtUuwIOud i2We/WI9 tmMFEXj8NxGlTle7w9KpXVL/YX1UjDUxewa9WxmjfJkTzNwmsbcAmXasqhfwpEvIyPQTjim8PxwzruncBLdJLzaZJL9svpC04Co8awG/fdyyQUbbL0+guZ+cGU5XqTGaL71g0i2Q0b6a8LFgoQmyZXMWB2BkzN1eU8HZ8iqoWjU9XnqZgMpm/TSY4dXaBZO5VEWpFX7oJQwGbZwSgPk2o7KfS7pkvfoHsHctmCJNTmCkiODhfu+iBWsQouarQnUwFwf8/PB+7+stB9B2cGvDar+v4Cg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As suggested by Naoya [1], identify_page_state() is never called when handling memory error on a slab page. Clean this up before moving PG_slab flag to page_type in later patch. [1] https://lore.kernel.org/linux-mm/Y2s+dnBsHAJu19ob@hyeyoo/#r Suggested-by: Naoya Horiguchi Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/memory-failure.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index c77a9e37e27e..74ad1db989e3 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -783,7 +783,6 @@ static const char *action_name[] = { static const char * const action_page_types[] = { [MF_MSG_KERNEL] = "reserved kernel page", [MF_MSG_KERNEL_HIGH_ORDER] = "high-order kernel page", - [MF_MSG_SLAB] = "kernel slab page", [MF_MSG_DIFFERENT_COMPOUND] = "different compound page after locking", [MF_MSG_HUGE] = "huge page", [MF_MSG_FREE_HUGE] = "free huge page", @@ -1146,7 +1145,6 @@ static int me_huge_page(struct page_state *ps, struct page *p) #define mlock (1UL << PG_mlocked) #define lru (1UL << PG_lru) #define head (1UL << PG_head) -#define slab (1UL << PG_slab) #define reserved (1UL << PG_reserved) static struct page_state error_states[] = { @@ -1156,13 +1154,6 @@ static struct page_state error_states[] = { * PG_buddy pages only make a small fraction of all free pages. */ - /* - * Could in theory check if slab page is free or if we can drop - * currently unused objects without touching them. But just - * treat it as standard kernel for now. - */ - { slab, slab, MF_MSG_SLAB, me_kernel }, - { head, head, MF_MSG_HUGE, me_huge_page }, { sc|dirty, sc|dirty, MF_MSG_DIRTY_SWAPCACHE, me_swapcache_dirty }, @@ -1189,7 +1180,6 @@ static struct page_state error_states[] = { #undef mlock #undef lru #undef head -#undef slab #undef reserved /* -- 2.32.0