From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Hyeonggon Yoo" <42.hyeyoo@gmail.com>,
"HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Joe Perches" <joe@perches.com>, "Petr Mladek" <pmladek@suse.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Matthew WilCox" <willy@infradead.org>,
"David Hildenbrand" <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types
Date: Sun, 18 Dec 2022 19:18:58 +0900 [thread overview]
Message-ID: <20221218101901.373450-2-42.hyeyoo@gmail.com> (raw)
In-Reply-To: <20221218101901.373450-1-42.hyeyoo@gmail.com>
As suggested by Naoya [1], identify_page_state() is never
called when handling memory error on a slab page.
Clean this up before moving PG_slab flag to page_type in later patch.
[1] https://lore.kernel.org/linux-mm/Y2s+dnBsHAJu19ob@hyeyoo/#r
Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
---
mm/memory-failure.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index c77a9e37e27e..74ad1db989e3 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -783,7 +783,6 @@ static const char *action_name[] = {
static const char * const action_page_types[] = {
[MF_MSG_KERNEL] = "reserved kernel page",
[MF_MSG_KERNEL_HIGH_ORDER] = "high-order kernel page",
- [MF_MSG_SLAB] = "kernel slab page",
[MF_MSG_DIFFERENT_COMPOUND] = "different compound page after locking",
[MF_MSG_HUGE] = "huge page",
[MF_MSG_FREE_HUGE] = "free huge page",
@@ -1146,7 +1145,6 @@ static int me_huge_page(struct page_state *ps, struct page *p)
#define mlock (1UL << PG_mlocked)
#define lru (1UL << PG_lru)
#define head (1UL << PG_head)
-#define slab (1UL << PG_slab)
#define reserved (1UL << PG_reserved)
static struct page_state error_states[] = {
@@ -1156,13 +1154,6 @@ static struct page_state error_states[] = {
* PG_buddy pages only make a small fraction of all free pages.
*/
- /*
- * Could in theory check if slab page is free or if we can drop
- * currently unused objects without touching them. But just
- * treat it as standard kernel for now.
- */
- { slab, slab, MF_MSG_SLAB, me_kernel },
-
{ head, head, MF_MSG_HUGE, me_huge_page },
{ sc|dirty, sc|dirty, MF_MSG_DIRTY_SWAPCACHE, me_swapcache_dirty },
@@ -1189,7 +1180,6 @@ static struct page_state error_states[] = {
#undef mlock
#undef lru
#undef head
-#undef slab
#undef reserved
/*
--
2.32.0
next prev parent reply other threads:[~2022-12-18 10:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 10:18 [RFC v3 0/4] move PG_slab flag to page_type Hyeonggon Yoo
2022-12-18 10:18 ` Hyeonggon Yoo [this message]
2022-12-20 23:53 ` [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types HORIGUCHI NAOYA(堀口 直也)
2022-12-21 17:00 ` Andy Shevchenko
2022-12-29 13:18 ` Hyeonggon Yoo
2022-12-29 13:17 ` Hyeonggon Yoo
2022-12-18 10:18 ` [RFC v3 2/4] mm: move PG_slab flag to page_type Hyeonggon Yoo
2023-01-12 16:27 ` Vlastimil Babka
2023-01-30 4:34 ` Hyeonggon Yoo
2023-01-30 5:11 ` Matthew Wilcox
2023-02-03 16:00 ` Hyeonggon Yoo
2023-02-03 16:19 ` Matthew Wilcox
2023-02-08 13:56 ` Hyeonggon Yoo
2023-02-03 16:04 ` David Hildenbrand
2023-02-08 9:44 ` Mike Rapoport
2023-02-08 10:13 ` David Hildenbrand
2022-12-18 10:19 ` [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Hyeonggon Yoo
2022-12-19 9:44 ` Andy Shevchenko
2022-12-19 19:35 ` Randy Dunlap
2022-12-20 10:58 ` Andy Shevchenko
2022-12-29 13:35 ` Hyeonggon Yoo
2022-12-20 15:20 ` Petr Mladek
2022-12-29 13:30 ` Hyeonggon Yoo
2022-12-18 10:19 ` [RFC v3 4/4] mm/debug: use %pGt to print page_type in dump_page() Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221218101901.373450-2-42.hyeyoo@gmail.com \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox