linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@meta.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <willy@infradead.org>
Cc: Tony Battersby <tonyb@cybernetics.com>,
	Kernel Team <kernel-team@meta.com>,
	Keith Busch <kbusch@kernel.org>
Subject: [PATCHv2 08/11] dmapool: consolidate page initialization
Date: Fri, 16 Dec 2022 12:16:22 -0800	[thread overview]
Message-ID: <20221216201625.2362737-9-kbusch@meta.com> (raw)
In-Reply-To: <20221216201625.2362737-1-kbusch@meta.com>

From: Keith Busch <kbusch@kernel.org>

Various fields of the dma pool are set in different places. Move it all
to one function.

Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 mm/dmapool.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index f77e2af4941de..33d20ceff18c5 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -202,6 +202,8 @@ static void pool_initialise_page(struct dma_pool *pool, struct dma_page *page)
 	unsigned int offset = 0;
 	unsigned int next_boundary = pool->boundary;
 
+	page->in_use = 0;
+	page->offset = 0;
 	do {
 		unsigned int next = offset + pool->size;
 		if (unlikely((next + pool->size) >= next_boundary)) {
@@ -211,6 +213,8 @@ static void pool_initialise_page(struct dma_pool *pool, struct dma_page *page)
 		*(int *)(page->vaddr + offset) = next;
 		offset = next;
 	} while (offset < pool->allocation);
+
+	list_add(&page->page_list, &pool->page_list);
 }
 
 static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags)
@@ -229,10 +233,6 @@ static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags)
 #ifdef	DMAPOOL_DEBUG
 	memset(page->vaddr, POOL_POISON_FREED, pool->allocation);
 #endif
-	pool_initialise_page(pool, page);
-	page->in_use = 0;
-	page->offset = 0;
-
 	return page;
 }
 
@@ -354,8 +354,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
 		return NULL;
 
 	spin_lock_irqsave(&pool->lock, flags);
-
-	list_add(&page->page_list, &pool->page_list);
+	pool_initialise_page(pool, page);
  ready:
 	page->in_use++;
 	offset = page->offset;
-- 
2.30.2



  parent reply	other threads:[~2022-12-16 20:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16 20:16 [PATCHv2 00/11] dmapool enhancements Keith Busch
2022-12-16 20:16 ` [PATCHv2 01/11] dmapool: add alloc/free performance test Keith Busch
2022-12-16 20:16 ` [PATCHv2 02/11] dmapool: remove checks for dev == NULL Keith Busch
2022-12-23 16:27   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2022-12-23 16:28   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 04/11] dmapool: cleanup integer types Keith Busch
2022-12-23 16:29   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 05/11] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Keith Busch
2022-12-23 16:29   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 06/11] dmapool: move debug code to own functions Keith Busch
2022-12-23 16:31   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 07/11] dmapool: rearrange page alloc failure handling Keith Busch
2022-12-23 16:31   ` Christoph Hellwig
2022-12-16 20:16 ` Keith Busch [this message]
2022-12-23 16:35   ` [PATCHv2 08/11] dmapool: consolidate page initialization Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 09/11] dmapool: simplify freeing Keith Busch
2022-12-23 16:38   ` Christoph Hellwig
2022-12-27 20:21     ` Keith Busch
2022-12-16 20:16 ` [PATCHv2 10/11] dmapool: don't memset on free twice Keith Busch
2022-12-23 16:39   ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 11/11] dmapool: link blocks across pages Keith Busch
2022-12-17  2:39   ` kernel test robot
2022-12-17  3:49   ` kernel test robot
2022-12-23 16:58   ` Christoph Hellwig
2022-12-23 17:08     ` Tony Battersby
2022-12-23 17:15       ` Christoph Hellwig
2022-12-24 14:55         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221216201625.2362737-9-kbusch@meta.com \
    --to=kbusch@meta.com \
    --cc=kbusch@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tonyb@cybernetics.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox