From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EFBC3DA6E for ; Fri, 16 Dec 2022 20:17:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143268E0008; Fri, 16 Dec 2022 15:17:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07E1C8E0001; Fri, 16 Dec 2022 15:17:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5F1C8E0008; Fri, 16 Dec 2022 15:17:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D688F8E0001 for ; Fri, 16 Dec 2022 15:17:23 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ADFC0161168 for ; Fri, 16 Dec 2022 20:17:23 +0000 (UTC) X-FDA: 80249279166.07.1F4F552 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf19.hostedemail.com (Postfix) with ESMTP id C587E1A001F for ; Fri, 16 Dec 2022 20:17:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=MbCoiSgf; spf=pass (imf19.hostedemail.com: domain of "prvs=33494f0754=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=33494f0754=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671221842; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P/KRpfmdlQUKxAAPrLlGtIIYCnA6qEIJS0aGmE3w/OM=; b=pOD7L4IiOeQRQq5hcnM7ocvcWf018Mmt+Nwkq7mDY51haotA3pTz++1CI3chdqoqHhnHVV 9MlNMA5JvZv0yc7sw/8pMeycVWmGb/LgHfbD9k2ltky75TfDr4WvLoOADcDcyR1xkeKwfm /t5VfbyEmXXAQ/nZMD9WceYAqEW9x30= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=MbCoiSgf; spf=pass (imf19.hostedemail.com: domain of "prvs=33494f0754=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=33494f0754=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671221842; a=rsa-sha256; cv=none; b=ycaqu9fBzUUrNRWi23OD1dop5YVGWftjr/1BAmvNZPXpvNZuFs02Fzwf+hBav00vhBPblo mM00YJcTBAg9scduXYlojougAihsaDACvMfYsYTmi13r4cq/NG0rrrz/xjIFjI9JQMaFnm uaIe+AvEt5j0Ntz0f5u5kyChmA1WM+s= Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BGJxe1s026562 for ; Fri, 16 Dec 2022 12:17:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=P/KRpfmdlQUKxAAPrLlGtIIYCnA6qEIJS0aGmE3w/OM=; b=MbCoiSgfMSiseLUY8bCAs3dbyFZQ3Rl0CLAubF9uzrqkfr/MvHkNbhvABzz3rPOT94Uw sTTUx6fDbStVDEpl/yLxoFGe5kd913/iZPC8NzP4KNck043HmxwxPnhDpEln4pd8i9jN 6Cw3Lal8BKx/kX+3JkIH1HhFzFzt7+aMQf/q36VH/uV+dYPUng6PyeXINbyO+CNAX5wU 9z2qD1wgvH7IFT9nDRQIKIlr5VhzMpcPlVILYm71FLYPu22UN5iWFdsEGlZAz1Kdfl3g vSiVkdpvfAUdtxLcTxFzUw2ZW8+WSkwiTrstgXw3VCJtgTgDtji/8m1fiSDv2xYl4U6n QQ== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3mgh7v57s3-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 16 Dec 2022 12:17:20 -0800 Received: from twshared8047.05.ash9.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 16 Dec 2022 12:17:19 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 289EAD042AB9; Fri, 16 Dec 2022 12:17:10 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox CC: Tony Battersby , Kernel Team , Keith Busch Subject: [PATCHv2 05/11] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Date: Fri, 16 Dec 2022 12:16:19 -0800 Message-ID: <20221216201625.2362737-6-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221216201625.2362737-1-kbusch@meta.com> References: <20221216201625.2362737-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: yNJtwiQsQRDRxvGJFXmEmL2pB48m00Gk X-Proofpoint-ORIG-GUID: yNJtwiQsQRDRxvGJFXmEmL2pB48m00Gk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-16_14,2022-12-15_02,2022-06-22_01 X-Rspamd-Queue-Id: C587E1A001F X-Stat-Signature: ihnbxas6c6qchx8pyc9t84yhyxa7n4pf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671221841-953650 X-HE-Meta: U2FsdGVkX18nMRRQ5DJJNmxd6C28espzlM08su8jDsHhbBdSBwwIouEPxksWeDZ2ux816faypMFhSqE8PHqfJW0h87Xo/7p6zMZF0ZnS08PY6EJdfNBYN5lDvTVTVwJ0edfR+4AUsJZJMZgtNk7FYBG1n57xwTOg2lsc9bDp9m/Lvvs2e9/TS9RWUrn2/eJfUB6x1zPAnZst/5CkWT/bv8U7MIzumW8tmmNkm4jRS+2RpMrV7WqP3+yovXamyWMBj4aTbyR/hLlv4CE0RNiVCYN4DLzmA9NGTkgTAkCBfCYNYJlG/Hs0sF61GtrZ2WlyLf1Wl0iupsWdpQrKKewmOqqqdxHyKhkvmXMczQyNW29BdSyo+fqd5Vd7N8lMr6P/ACvUVxXpFfgIKwywcPCtVkV4VaD5ZccWy33wTUfkRUDg/9JEbQuh6WXxchP7oURjJ5oGpJ7AA+zWPjk2cHeQKzzcuEAa2XyLqKsOnR3inLAffq24Pi1CUTZGKvHLZevoxeI1X8xtjEn8b8K7rJ7KkaRJvudLUazF0NLPCb4pOuFyVelhWSsZ107l6RThhRQOM0uPRKN1dup4Ay6pVCCadZaeDLPS3HuH+RcB2ZLslAwEunt8Mq47G0uHQ/upZYl8wkjTJDLDL8pVd/bwbllsAx3eynnsGUdbO1LsLKQZD+lnPprLroKsJR7BBlt0Equzvc0MYpY/l2trZlPwfe4BsWWPWoXzSBVUnCoFgrSrDJBvsUy2t5CZeBnh9hyEo7kFXQPjW89HWIgafk6LyOs9Kp20gPKn8nQmZkBgkWGmPJcsJLW7JE9qzSfnpDbxcXYy80yL+/4NVzvNswHr4jgTkeS2wk0Z3WUqJqfzIsqwFvw+DWwroqE9/ULey8JyBp/9rC6Rc3PDQXKQqX5D1VKV135Yu1+QDWhC0kEEW1qVoq2vqh3NX8r07BHzPQ1HNsgDk6IHJlPbUIT5+SXO/9H 8xpL8Bo9 8n7RP9CcPAx8MmwKk9qWLE02rgpJRnQY/YomyZvnZq8FlCocfeP1Wfl/zzYm1aWtuGckb7jxsg56zfk4lxaVPkIIWDJ/A1SMbvVb7mCmReLYvchA4FteKBPRSV20bmaeHJ6TXt6RjKiZXLndYaVF/VgQEXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Avoid double-memset of the same allocated memory in dma_pool_alloc() when both DMAPOOL_DEBUG is enabled and init_on_alloc=3D1. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch --- mm/dmapool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index ee993bb59fc27..eaed3ffb42aa8 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -356,7 +356,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem= _flags, break; } } - if (!(mem_flags & __GFP_ZERO)) + if (!want_init_on_alloc(mem_flags)) memset(retval, POOL_POISON_ALLOCATED, pool->size); #endif spin_unlock_irqrestore(&pool->lock, flags); --=20 2.30.2