From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B1EFC4167B for ; Fri, 16 Dec 2022 20:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89578900002; Fri, 16 Dec 2022 15:17:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84588940007; Fri, 16 Dec 2022 15:17:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70C9B900004; Fri, 16 Dec 2022 15:17:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FDD5900002 for ; Fri, 16 Dec 2022 15:17:28 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 35FD5121203 for ; Fri, 16 Dec 2022 20:17:28 +0000 (UTC) X-FDA: 80249279376.24.F3A54A5 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 499D0C0004 for ; Fri, 16 Dec 2022 20:17:26 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=mfMn7jRA; dmarc=pass (policy=reject) header.from=meta.com; spf=pass (imf28.hostedemail.com: domain of "prvs=33494f0754=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=33494f0754=kbusch@meta.com" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671221846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=i/bwXbhAJD92yrUapsEuR4jtOBuU6fxiHbKYQzH0qk8ZM4zSGfw5EvbaBsJAzQ+Dgv5gYa Ljgt5mLo1UF6g4RK85OfCWTyAeqDWtOS5/q9iZb43FnyYesdwrqREmaJhpnQsdVUzqfqPm K+fR+orYqewOtueQyoT5eqCD1vDoujQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=mfMn7jRA; dmarc=pass (policy=reject) header.from=meta.com; spf=pass (imf28.hostedemail.com: domain of "prvs=33494f0754=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=33494f0754=kbusch@meta.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671221846; a=rsa-sha256; cv=none; b=d9haDR15t5vig5p3aC4z61wtfoFcFMpUVhaxLvLeyI70cDGv2kuX515pzRTp/vC1tf+vDj syNHr4WFfCmiWdY5PhY43ykDMT54B0we87wU/xR7rHSD9fCD9kfGWXk4HMaYdmY7yMV5Tf HOzbOkt4nSjKUjzQb0pC/dGKw81QkoY= Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BGJxDso024432 for ; Fri, 16 Dec 2022 12:17:25 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=mfMn7jRAj1JALvXAGMrFFL2ynhUTkET2GZUP//Au3O898Gj3HgP6C83+obVffTaI9AEC LdH93rl62N9EjRD5+os0ye+85TMSG1HNxCqKKwVjcnoo9AYzjB9WKpmso7prETZ5tjzc 3HRP9xgLaR+p0coaQsxcCgS66JxPo99d6u33bkLP+D12zFt3zYgcMC02JjfrlJuH8gXo LYvJCI7ZTuPhY8i7TzUUu5iEU6bFUrUlcg/HAud+/dv1BAINn8D3AdXdX6uIibAi8w1U ySKVjeRciobFpyq04tF0c/gbUyK/rd7Wx3oq7ad63OgUBOIRgxK+2AB1dxOA/1eD9v5e Jg== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3mgxjy8gd2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 16 Dec 2022 12:17:25 -0800 Received: from twshared15216.17.frc2.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:11d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 16 Dec 2022 12:17:24 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 143E1D042AB5; Fri, 16 Dec 2022 12:17:10 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox CC: Tony Battersby , Kernel Team , Keith Busch Subject: [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf() Date: Fri, 16 Dec 2022 12:16:17 -0800 Message-ID: <20221216201625.2362737-4-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221216201625.2362737-1-kbusch@meta.com> References: <20221216201625.2362737-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: 5Yb8I9slxfJAiB8j0KDp69qN73EDNyYm X-Proofpoint-ORIG-GUID: 5Yb8I9slxfJAiB8j0KDp69qN73EDNyYm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-16_14,2022-12-15_02,2022-06-22_01 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 499D0C0004 X-Stat-Signature: nx188g1be9grmhq8sbkpsktz5bt7kem1 X-HE-Tag: 1671221846-952513 X-HE-Meta: U2FsdGVkX1+Jz0ZJZb7nBRgPijwiLbrfX+oeQJsWTvzFExyr4vuWrh0UT4p/dLYhz0EabmA2jdu2QApj8DfX2PmslTGHlMvbFnOa74yX8GjFGUmusoUfAKdo3pb2zTeq7X9psdJZLiVmFqVF/wloXkPnXkIMXhULeqmLVQ1B7WJqH3YN6+JjrR7rWQcvhMtWtpsAQnasCwAXU3Lh0+ue6PStn8kp85FzY2Xlhjf0FnPX8aGdaORzh5Mby7xuKVKZIliPE9wAi0zGOj/Q3rAZZ/CO6v6fI0Sh8k5zNuqKdTYZu031S3S6dhtUKYFBgFyaxPn50Itg2SuRgT9WPX0/lPHsUtn/h33+M4AbFtLUkORD5GzFdttiIjxEYGDR1AdXHlE1ecOl/BmhevHdWooCHtqEuejhmw9ZdWu2/B9rH+kTi1sIm3hMr18bH3nVEvrTEoeYC46AG8xm4ag6IW993xMOr5LMbQQnvA1TIPeG7JYo4Fi26VZk9EyFJN28pEvaJoazf39c+ZJvAvHScdPp5ewfRuhbbKqYGSyyOeMTzD+xXS4cn7GyIIFEs1ExkA/UAq4PBrDrUcRIRFwO0qw0XturdULUbFM/y1Eope4ww13FCq8HzyUPjRgG8l72GQnp9d+zfNoj/woIBjsenuu4F9D49je/12J0DiiqjepzoKC9Vnq0iwEcJrPjAaWi5yIgdufHdx2kKLwjBnPPHdaWfd70EDpmh9v0X+C0876CmcXw4sWtLVNFyaa+J2vCNCPg9s81X0u8+VrwU/0/W/9lgIrGrv/LO7wjQIA+6B6k2IEA3rM1M/JZ/JypYRGnc1snSRNUFlHkbbJgmXaNitQKMAGetsycAutILW9iBaVjThTDX3RzBb0rzlCzSiqcDBhEhnaslPz2Nwh9arlz4Tn7t2Fy2hWS13ONMr5VrRJPE/QryeucBDmka2+r0Y1Va8FRjv6WDoOUMQWS0mbvwQD Vt5vwnHk 57olqGKcaXadd/Et8Q6uh1CZkZNC53HtCJCOYprhAlmABiflu74FtJUSjSZRBkJtRL+tgq3/JOMg/EQXobymBcoQURcpxz6JayqZrJDae/mbqFaa1SywQ3J9D1kpfRcENrwJ15if1uJ6YDZ9evcSgoZ9SMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Use sysfs_emit instead of scnprintf, snprintf or sprintf. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch --- mm/dmapool.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index 559207e1c3339..20616b760bb9c 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock); =20 static ssize_t pools_show(struct device *dev, struct device_attribute *a= ttr, char *buf) { - unsigned temp; - unsigned size; - char *next; + int size; struct dma_page *page; struct dma_pool *pool; =20 - next =3D buf; - size =3D PAGE_SIZE; - - temp =3D scnprintf(next, size, "poolinfo - 0.1\n"); - size -=3D temp; - next +=3D temp; + size =3D sysfs_emit(buf, "poolinfo - 0.1\n"); =20 mutex_lock(&pools_lock); list_for_each_entry(pool, &dev->dma_pools, pools) { @@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct = device_attribute *attr, cha spin_unlock_irq(&pool->lock); =20 /* per-pool info, no real statistics yet */ - temp =3D scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n", - pool->name, blocks, - pages * (pool->allocation / pool->size), - pool->size, pages); - size -=3D temp; - next +=3D temp; + size +=3D sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", + pool->name, blocks, + pages * (pool->allocation / pool->size), + pool->size, pages); } mutex_unlock(&pools_lock); =20 - return PAGE_SIZE - size; + return size; } =20 static DEVICE_ATTR_RO(pools); --=20 2.30.2